[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG951f362e2560: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it (authored by thakis). Herald added a project: clang. Changed prior to c

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. In D109828#3002495 , @thakis wrote: > In D109828#3002114 , @hans wrote: > >> The /winsysroot part makes sense to

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis added a comment. In D109828#3002114 , @hans wrote: > The /winsysroot part makes sense to me, but what's the case for the new > /diasdkdir flag? - If you do have a vcvars shell, you don't need the full sysroot path and it's kind of useful (see

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis updated this revision to Diff 372782. thakis marked an inline comment as done. thakis added a comment. move arch functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 Files: clang/include/clang/Driver/Options.td clang/lib/Driver

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans added a comment. The /winsysroot part makes sense to me, but what's the case for the new /diasdkdir flag? Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:66 +static const char *llvmArchToLegacyVCArch(llvm::Triple::ArchType Arch); + Maybe move the arch

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, pengfei. thakis requested review of this revision. D109708 added "DIA SDK" to our win sysroot for hermetic builds that use LLVM_ENABLE_DIA_SDK. But the build system stil