[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

2021-08-17 Thread Brian Cain via Phabricator via cfe-commits
bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + || defined(

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

2021-08-17 Thread Brian Cain via Phabricator via cfe-commits
bcain added a comment. In D108083#2949815 , @vitalybuka wrote: >> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can provi

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

2021-08-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D108083#2948056 , @bcain wrote: > In D108083#2947914 , @vitalybuka > wrote: > >> Do we have public bot for hexagon? > > I think we have one intended to for checking hexagon-unknown-

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

2021-08-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Sorry, approved accidentally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

2021-08-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Please correct me if I am wrong, but LLVM does not use [PATCH *] tags for series. Please remove them from title and git patches. You can link dependent patches into Phabricator "stack"