bcain added a comment. In D108083#2949815 <https://reviews.llvm.org/D108083#2949815>, @vitalybuka wrote:
>> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can provide their build machines to work as build workers to > public LLVM Buildbot. I was prepared to write / test / enable a build recipe but I don't have access to a public system that can be added as a worker. But I can work with our team to get the ball rolling, it just doesn't seem like it would be a quick process. ================ Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:162 +#elif SANITIZER_LINUX && defined(__hexagon__) +#include "sanitizer_syscall_linux_hexagon.inc" #else ---------------- vitalybuka wrote: > bcain wrote: > > Most of the feedback from `clang-format` checks don't seem to really be the > > format we use here. We should probably apply a more specific > > `.clang-format` file if these aren't useful. > clang-format pre-merge check uses .clang-format files. > If you apply it it locally make sure to use -style=file. > > Actually this place is ugly. Current .clang-format will indent when the rest > of the block is not. > So up to you, keep it as-is, or clang-format entire block 152-165 (ideally in > a separate patch) I did apply clang-format-diff via pre-commit hook and I don't believe it made significant changes, but this is after that formatting. I prefer to keep it as-is because the style near here seems to match. ================ Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + || defined(__hexagon__) ---------------- vitalybuka wrote: > but please fix ones like this which do not require significant reformatting > of unchanged code. Ok that's no problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
