vitalybuka added a comment. In D108083#2948056 <https://reviews.llvm.org/D108083#2948056>, @bcain wrote:
> In D108083#2947914 <https://reviews.llvm.org/D108083#2947914>, @vitalybuka > wrote: > >> Do we have public bot for hexagon? > > I think we have one intended to for checking hexagon-unknown-elf and perhaps > not one for hexagon-unknown-linux-musl. I believe that only the Linux target > uses the compiler-rt libraries, though. > > We can help create a bot for hexagon-unknown-linux-musl. What's the process? Thank you. https://llvm.org/docs/HowToAddABuilder.html ================ Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:162 +#elif SANITIZER_LINUX && defined(__hexagon__) +#include "sanitizer_syscall_linux_hexagon.inc" #else ---------------- bcain wrote: > Most of the feedback from `clang-format` checks don't seem to really be the > format we use here. We should probably apply a more specific `.clang-format` > file if these aren't useful. clang-format pre-merge check uses .clang-format files. If you apply it it locally make sure to use -style=file. Actually this place is ugly. Current .clang-format will indent when the rest of the block is not. So up to you, keep it as-is, or clang-format entire block 152-165 (ideally in a separate patch) ================ Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + || defined(__hexagon__) ---------------- but please fix ones like this which do not require significant reformatting of unchanged code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
