[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3104558 , @dblaikie wrote: > In D107049#3103984 , @lhames wrote: > >> In D107049#3101456 , @dblaikie >> wrote: >> >>> Yeah, seems we've

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3103984 , @lhames wrote: > In D107049#3101456 , @dblaikie > wrote: > >> In D107049#3100630 , @rnk wrote: >> >>> So, to back up a bit,

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3101456 , @dblaikie wrote: > In D107049#3100630 , @rnk wrote: > >> So, to back up a bit, do I understand correctly that this change adds tests >> to the check-clang test suite t

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3100939 , @lhames wrote: > In D107049#3096727 , @uabelho wrote: > >> Hi, >> >> We're seeing a problem with this patch in our downstream (not public) >> buildbots. With an asan-

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3100630 , @rnk wrote: > So, to back up a bit, do I understand correctly that this change adds tests > to the check-clang test suite that JIT compiles C++ code for the host and > throws C++ exceptions? Can we reconsid

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the following: > > ... > 10:08:55 [ RUN ] InterpreterTes

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rnk added a subscriber: dblaikie. rnk added a comment. So, to back up a bit, do I understand correctly that this change adds tests to the check-clang test suite that JIT compiles C++ code for the host and throws C++ exceptions? Can we reconsider that? We have a policy of not running execution t

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3099941 , @v.g.vassilev wrote: > Can you also paste the configure output of cmake? Attached in file.txt F20006228: file.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#3099816 , @uabelho wrote: > In D107049#3096807 , @v.g.vassilev > wrote: > >> Can you share your cmake config line, the target triple and architecture? > > CC='/mycompiler/

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. If we run without z3 it still fails, but in another way: [ RUN ] InterpreterTest.CatchException JIT session error: Symbols not found: [ __gxx_personality_v0, _ZSt9terminatev, _ZTVN10__cxxabiv117__class_type_infoE, __cxa_allocate_exception, __cxa_begin_catch, __

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. In D107049#3096807 , @v.g.vassilev wrote: > Can you share your cmake config line, the target triple and architecture? CC='/mycompiler/compiler-clang/bin/clang -march=corei7' CXX='/mycompiler/compiler-clang/bin/clang++ -march=co

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the followin

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

uabelho added a comment. Hi, We're seeing a problem with this patch in our downstream (not public) buildbots. With an asan-built compiler we see the following: 10:08:55 FAIL: Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException (25832

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) thakis wrote: > v.g.vassilev wrote: > > v.g.vassilev wrote: > > > thakis wrote: > > > > Why are t

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) v.g.vassilev wrote: > v.g.vassilev wrote: > > thakis wrote: > > > Why are these additions needed here again? This change doesn't add any > > > code t

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) v.g.vassilev wrote: > thakis wrote: > > Why are these additions needed here again? This change doesn't add any code > > to ClangReplInterpreter

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#3052557 , @leonardchan wrote: > Hi. I think our clang builders are failing from this after the reland > (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overv

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

leonardchan added a comment. Hi. I think our clang builders are failing from this after the reland (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overview): Script: -- /b/s/w/ir/x/w/staging/llvm_build/tools/clang/unittests/Interprete

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) thakis wrote: > Why are these additions needed here again? This change doesn't add any code > to ClangReplInterpreterTests as far as I can tell

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) Why are these additions needed here again? This change doesn't add any code to ClangReplInterpreterTests as far as I can tell. Are these remnants fro

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:102 + } catch (...) { +printf("Unknown exception\n"); + } karies wrote: > How is that provoking a test failure? What about `exit(1)` or

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377307. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/examples/CMakeLists.txt clang/exa

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377303. v.g.vassilev added a comment. Upload the newest version of this patch. It has several improvements that came from various bot failures. We just need to outline the `llvm::consumeError` to be able to call it from exceptions land and fix the last

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

karies added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt:2 +# The interpreter can throw an exception from user input. The test binary needs +# to be compiled with exception support to expect and catch the thrown +# exception. ---

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

Hahnfeld added a comment. In D107049#2984835 , @v.g.vassilev wrote: > It looks like we hit https://bugs.llvm.org/show_bug.cgi?id=49692 I agree. Unfortunately, as described in the report, this is something that needs to be fixed on Apples side first.

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added subscribers: karies, Hahnfeld. v.g.vassilev added a comment. In D107049#2982224 , @thakis wrote: > Thanks for fixing! Intel macs are happy now. > > But the test is still failing on arm macs: > http://45.33.8.238/macm1/17292/step_7.txt

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#2982224 , @thakis wrote: > Thanks for fixing! Intel macs are happy now. > > But the test is still failing on arm macs: > http://45.33.8.238/macm1/17292/step_7.txt > > FAIL: Clang-Unit :: > Interpreter/Exception

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Thanks for fixing! Intel macs are happy now. But the test is still failing on arm macs: http://45.33.8.238/macm1/17292/step_7.txt FAIL: Clang-Unit :: Interpreter/ExceptionTests/./ClangReplInterpreterExceptionTests/InterpreterTest.CatchException (28440 of 28440) ***

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. > I did not find a good way to 'find back' the clang resource-dir and it seems > to be put in a constant place. The test needs to have a compiled and > interpreted parts -- it throws an exception from the interpreter land and > expects a compiled binary to be able to cat

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#2976603 , @thakis wrote: > The test fails for me on macOS (normal cmake build): > > % > tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests > [==] Running 1 test from 1

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Also failing on the bots: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/23343/execution/node/39/log/ (that's for the original land, but from what I can tell nothing has changed in this regard for the reland, and I'm still seeing the same failure

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Herald added a subscriber: ormris. The test fails for me on macOS (normal cmake build): % tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests [==] Running 1 test from 1 test suite. [--] Global test environment set-up.

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG319ce9801174: [clang-repl] Re-implement clang-interpreter as a test case. (authored by v.g.vassilev). Herald added a project: clang. Changed prior t

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:101-105 + // FIXME: Somehow when we build this test in release mode argc is not 0. + // printf("%d\n", argc); + // for (int I = 0; I < argc; ++I) + // pr

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 369729. v.g.vassilev marked 3 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst cl

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rsmith added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:73-76 +#ifdef _MSC_VER +// Tell the windows linker to export the type_info symbol required by exceptions +#pragma comment(linker, "/export:??_7type_info@@6B@") +#en

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 367114. v.g.vassilev added a subscriber: sgraenitz. v.g.vassilev added a comment. Disable the case exception test of windows. cc: @sgraenitz CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: c

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 367015. v.g.vassilev added a comment. Try fix the win pre-merge bot. Clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst clang/examples/CMakeLi

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 366978. v.g.vassilev added a comment. Split the exception handling test into a separate unittest and compile it with exceptions on. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 365134. v.g.vassilev added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst clang/examples/CMakeLists.txt clang/examples/clang-interpr

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 365005. v.g.vassilev added a comment. Try to appease the windows pre-merge bot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst clang/examples/CMakeLists

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 363289. v.g.vassilev added a comment. Try to fix the issues reported by the pre-merge-checks. clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64 +// address of main, and some platforms can't implement GetMainExecutable +// without being given the address of a function in the main executable). +std::string GetExecutablePath(c

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64 +// address of main, and some platforms can't implement GetMainExecutable +// without being given the addre

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a reviewer: rnk. v.g.vassilev added a subscriber: rnk. v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:134 + // Instead we expect std::terminate to be called upon thrown exception. + EXPECT_DEATH(Main(), "termin

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. LGTM, but a clang dev should probably check this out too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, teemperor, lhames, bkramer. Herald added subscribers: mstorsjo, mgorny. v.g.vassilev requested review of this revision. The current infrastructure in lib/Interpreter has a tool, clang-repl, very similar to clang-interpreter