v.g.vassilev marked an inline comment as done.
v.g.vassilev added inline comments.
================
Comment at: clang/unittests/Interpreter/CMakeLists.txt:5
+ OrcJIT
+ Support
)
----------------
thakis wrote:
> v.g.vassilev wrote:
> > v.g.vassilev wrote:
> > > thakis wrote:
> > > > Why are these additions needed here again? This change doesn't add any
> > > > code to ClangReplInterpreterTests as far as I can tell. Are these
> > > > remnants from before the exception tests were in a different binary?
> > > Thanks for noticing that. The story was that
> > > `clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt` required
> > > `${LLVM_TARGETS_TO_BUILD} Core OrcJIT Support` as a dependency -- I was
> > > not sure why but I added the same here. I am testing now if I can get rid
> > > of both. I do not understand why we will need different set of
> > > dependencies for these tests as they should be using more or less the
> > > same set of functionality...
> > I dropped these dependencies as you mentioned -- thanks again.
> Looks like they're back in the reland. Mind dropping them again?
Yeah, thanks for keeping an eye on this. Not sure what I did wrong there.. Too
many reverts I guess...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107049/new/
https://reviews.llvm.org/D107049
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
