v.g.vassilev added inline comments.
================ Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64 +// address of main, and some platforms can't implement GetMainExecutable +// without being given the address of a function in the main executable). +std::string GetExecutablePath(const char *Argv0, void *MainAddr) { ---------------- rsmith wrote: > I don't follow why this can't be static. Is there some problem with using the > address of this function if it's static? That's a standard comment for each `GetExecutablePath` and I copy pasted it as done elsewhere. That requirement might be lifted in recent systems but I do not know the platform coverage to check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits