[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in 3c8e94bc20e5829ab5167d21d242b6b624dd934e , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364783. cor3ntin added a comment. - Update the release version to Clang 14 in cxx_status - Remove unused parameter - Remove WS only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://rev

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept(0+1)

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:81 -ExprResult Sema::ActOnNoexceptSpec(SourceLocation NoexceptLoc, - Expr *NoexceptExpr, +ExprResult Sema::ActOnNoexceptSpec(SourceLocation, Expr *NoexceptExp

[PATCH] D106216: Disallow narrowing conversions to bool in noexcept specififers.

cor3ntin updated this revision to Diff 364719. cor3ntin added a comment. Remove whitespace only change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/include/clang/Basic/DiagnosticSemaKind