aaron.ballman added inline comments.
================ Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:81 -ExprResult Sema::ActOnNoexceptSpec(SourceLocation NoexceptLoc, - Expr *NoexceptExpr, +ExprResult Sema::ActOnNoexceptSpec(SourceLocation, Expr *NoexceptExpr, ExceptionSpecificationType &EST) { ---------------- You should just get rid of this parameter entirely if it's no longer going to be used. ================ Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879 EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept)); - EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept)); + EXPECT_TRUE(notMatches("void foo() noexcept(0+1);", NoExcept)); EXPECT_TRUE(matches("void foo() noexcept(noexcept(1+1));", NoExcept)); ---------------- Was there a reason this test needed to change? ================ Comment at: clang/www/cxx_status.html:1299 <td><a href="https://wg21.link/P1401R5">P1401R5</a></td> - <td class="partial" align="center">Clang 13</td> + <td class="unreleased" align="center">Clang 13</td> </tr> ---------------- We're on Clang 14 now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits