aaron.ballman added inline comments.
================
Comment at: clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp:879
EXPECT_TRUE(notMatches("void foo() noexcept;", NoExcept));
- EXPECT_TRUE(notMatches("void foo() noexcept(1+1);", NoExcept));
+ EXPECT_TRUE(notMatches("void foo() noexcept(0+1);", NoExcept));
EXPECT_TRUE(matches("void foo() noexcept(noexcept(1+1));", NoExcept));
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > Was there a reason this test needed to change?
> yup, 2 is not convertible to bool here. I use 0+1 to keep the kind of
> expression the same
I kinda figured that was the case, thanks for confirming!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106216/new/
https://reviews.llvm.org/D106216
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits