[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-19 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9da70ab3d43c: [clang-format] Break an unwrapped line at a K&R C parameter decl (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-19 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. In D106112#2885604 , @owenpan wrote: > I just reviewed the differences between K&R C (circa 1978) and ANSI/ISO C > again and didn't see anything else that would impact clang-format, so a new > S

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer modes. > It ma

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-16 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer mod

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer modes.

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-16 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Looks okay, but I was wondering if we don't want to guard all K&R-related changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce strange bugs in newer modes. It may be an overkill if there are 2 patches like this, but if there are more, that might be

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for this, LGTM, maybe give the others some time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106112/new/ https://reviews

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-15 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: djasper, klimek, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Break an unwrapped line b