[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

2021-07-07 Thread Jinsong Ji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG31d10ea10ee1: [AIX] Don't pass no-integrated-as by default (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llv

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

2021-07-07 Thread ChenZheng via Phabricator via cfe-commits
shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llvm.org/D105512 _

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

2021-07-07 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable integrated-as explictly. + if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser()) CmdArgs.push_back("-no-integrated-as"); shchenz wrote: > D

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

2021-07-07 Thread ChenZheng via Phabricator via cfe-commits
shchenz added a comment. I think it is ok to not passing `-no-integrated-as` to cc1 as the default value for backend for XCOFF is no integrated assembler. Can we make the logic be simpler here? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable int

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

2021-07-06 Thread Jinsong Ji via Phabricator via cfe-commits
jsji created this revision. jsji added reviewers: PowerPC, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D105314 added the abibility choose to use AsmParser for parsing inline asm. -no-int