pengfei added a comment.
Thanks Craig!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
craig.topper added inline comments.
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197
+ else if (PatchedName.endswith("sh"))
+PatchedName = IsVCMP ? "vcmpsh" : "cmpsh";
+ else if (PatchedName.endswith("ph"))
pengfei wrote:
> LuoYua
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1de9d6dae17: [X86] AVX512FP16 instructions enabling 2/6
(authored by pengfei).
Changed prior to commit:
https://reviews.llvm.org/D105264?vs=36619
pengfei added a comment.
Thanks for the review!
Comment at: clang/lib/Headers/avx512vlfp16intrin.h:368
+_mm256_reduce_add_ph(__m256h __W) {
+ return __builtin_ia32_reduce_fadd_ph256(0.0f16, __W);
+}
LuoYuanke wrote:
> From https://llvm.org/docs/LangRef.html#ll
pengfei updated this revision to Diff 366194.
pengfei added a comment.
Address Yuanke's comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
Files:
clang/include/clang/Basic/BuiltinsX86.def
clang/
LuoYuanke accepted this revision.
LuoYuanke added a comment.
This revision is now accepted and ready to land.
LGTM, but may wait 1 or 2 days for the comments from others.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llv
LuoYuanke added inline comments.
Comment at: clang/lib/Headers/avx512vlfp16intrin.h:368
+_mm256_reduce_add_ph(__m256h __W) {
+ return __builtin_ia32_reduce_fadd_ph256(0.0f16, __W);
+}
From https://llvm.org/docs/LangRef.html#llvm-vector-reduce-add-intrinsic,
-0.
pengfei added inline comments.
Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838
{ X86::VMULSDZrr_Intk,X86::VMULSDZrm_Intk,
TB_NO_REVERSE },
+ { X86::VMULSHZrr_Intk,X86::VMULSHZrm_Intk,
TB_NO_REVERSE },
{ X86::VMULS
pengfei updated this revision to Diff 365995.
pengfei marked an inline comment as done.
pengfei added a comment.
Address Yuanke's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
Files:
clang/i
LuoYuanke added inline comments.
Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838
{ X86::VMULSDZrr_Intk,X86::VMULSDZrm_Intk,
TB_NO_REVERSE },
+ { X86::VMULSHZrr_Intk,X86::VMULSHZrm_Intk,
TB_NO_REVERSE },
{ X86::VMU
pengfei updated this revision to Diff 365899.
pengfei added a comment.
Update missing changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
Files:
clang/include/clang/Basic/BuiltinsX86.def
clang/li
pengfei added inline comments.
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197
+ else if (PatchedName.endswith("sh"))
+PatchedName = IsVCMP ? "vcmpsh" : "cmpsh";
+ else if (PatchedName.endswith("ph"))
LuoYuanke wrote:
> There is
pengfei updated this revision to Diff 365895.
pengfei marked 3 inline comments as done.
pengfei added a comment.
Address Yuanke's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
Files:
clang/i
LuoYuanke added inline comments.
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197
+ else if (PatchedName.endswith("sh"))
+PatchedName = IsVCMP ? "vcmpsh" : "cmpsh";
+ else if (PatchedName.endswith("ph"))
There is no cmpsh?
=
pengfei added a comment.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
pengfei added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsX86.def:1860
+TARGET_BUILTIN(__builtin_ia32_minph512, "V32xV32xV32xIi", "ncV:512:",
"avx512fp16")
+
+TARGET_BUILTIN(__builtin_ia32_minph256, "V16xV16xV16x", "ncV:256:",
"avx512fp16,avx512vl")
pengfei updated this revision to Diff 365738.
pengfei marked 6 inline comments as done.
pengfei added a comment.
1. Rebase to the first merged FP16 patch.
2. Address Yuanke's comments.
3. Add parentheses around casts.
4. Remove OptForSize predicate for vmovsh.
5. Add more immediate value for encod
LuoYuanke added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsX86.def:1860
+TARGET_BUILTIN(__builtin_ia32_minph512, "V32xV32xV32xIi", "ncV:512:",
"avx512fp16")
+
+TARGET_BUILTIN(__builtin_ia32_minph256, "V16xV16xV16x", "ncV:256:",
"avx512fp16,avx512vl
pengfei updated this revision to Diff 357721.
pengfei added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
Files:
clang/include/clang/Basic/BuiltinsX86.def
clang/lib/CodeGen/CGBuil
pengfei updated this revision to Diff 356364.
pengfei marked 2 inline comments as done.
pengfei added a comment.
Add prefix AVX512BW for non FP16 cases.
Thanks Simon for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://revi
RKSimon added inline comments.
Comment at: llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll:7
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512f,+avx512bw |
FileCheck %s --check-prefixes=ALL,AVX512
; RUN: llc < %s -mtriple=x86_64-unknown-unknown
-mattr=+avx512f,+
pengfei created this revision.
pengfei added reviewers: craig.topper, RKSimon, spatel, LiuChen3, FreddyYe,
yubing, LuoYuanke.
Herald added a subscriber: hiraditya.
pengfei requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
E
22 matches
Mail list logo
