pengfei added a comment.
Thanks for the review!
================
Comment at: clang/lib/Headers/avx512vlfp16intrin.h:368
+_mm256_reduce_add_ph(__m256h __W) {
+ return __builtin_ia32_reduce_fadd_ph256(0.0f16, __W);
+}
----------------
LuoYuanke wrote:
> From https://llvm.org/docs/LangRef.html#llvm-vector-reduce-add-intrinsic,
> -0.0f16 is better?
Yes. Cood catch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
