pengfei added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:4838
{ X86::VMULSDZrr_Intk, X86::VMULSDZrm_Intk,
TB_NO_REVERSE },
+ { X86::VMULSHZrr_Intk, X86::VMULSHZrm_Intk,
TB_NO_REVERSE },
{ X86::VMULSSZrr_Intk, X86::VMULSSZrm_Intk,
TB_NO_REVERSE },
----------------
LuoYuanke wrote:
> Is this because intrinsics always assume the arguments are passed in register?
No. Because the register size of scalar intrinsics is larger than corresponding
memory size:
https://github.com/llvm/llvm-project/blob/main/llvm/utils/TableGen/X86FoldTablesEmitter.cpp#L493
================
Comment at: llvm/test/CodeGen/X86/avx512fp16-fmaxnum.ll:26
+; CHECK: # %bb.0:
+; CHECK-NEXT: vmaxph %xmm0, %xmm1, %xmm2 # encoding:
[0x62,0xf5,0x74,0x08,0x5f,0xd0]
+; CHECK-NEXT: vcmpunordph %xmm0, %xmm0, %k1 # encoding:
[0x62,0xf3,0x7c,0x08,0xc2,0xc8,0x03]
----------------
LuoYuanke wrote:
> Is it legal without avx512vl?
`avx512fp16` implies `avx512vl`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105264/new/
https://reviews.llvm.org/D105264
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
