Re: [PATCH] D10365: Add cmd to compilation database file format

klimek closed this revision. klimek added a comment. Submitted as r245036. Thanks! http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Solved the line ending problem. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Unfortunately I can't get the patch to apply cleanly due to different line endings. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a comment. Yes, please land it. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Cool, looks good! If you need me to land it let me know. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 32099. diltsman marked an inline comment as done. diltsman added a comment. Added test for command and arguments in same object. Fixed bug where parse failed if command and argument resolved to empty lists. http://reviews.llvm.org/D10365 Files: ../llvm/t

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a comment. Where/how does documentation (http://clang.llvm.org/docs/JSONCompilationDatabase.html) get updated? http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. LG with a happy path test. Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45 @@ -41,1 +44,3 @@ + expectFailure

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 32082. diltsman marked an inline comment as done. diltsman added a comment. Arguments and Command can now be in the same compilation database for the same file. Arguments are preferred when both are present. http://reviews.llvm.org/D10365 Files: ../llv

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added inline comments. Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:295 @@ +294,3 @@ +if (CommandFound) { + ErrorMessage = "Multiple command and arguments found"; + return false; You're probably right. I

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 31952. diltsman marked an inline comment as done. http://reviews.llvm.org/D10365 Files: ../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp ../llvm/tools/clang/unittests/Toolin

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added inline comments. Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299 @@ +298,3 @@ +if (CommandFound) { + ErrorMessage = "Multiple command and arguments found"; + return false; klimek wrote: > Any rea

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Ok, we're very close now :) Thanks for taking the time to work through this! Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299 @@ +298,3 @@ +if (CommandFound) { + ErrorMessage = "Multiple command and arguments fo

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 31824. http://reviews.llvm.org/D10365 Files: ../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp Index: ../ll

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a subscriber: diltsman. diltsman added a comment. I'm trying to upload a new patch and I get an error from Phabricator: 'Unhandled Exception ("Exception")'. Any ideas how to get this to work? I have attached the diff file. - F722854: Arguments.patch