[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added a comment. In D100756#3088035 , @nickdesaulniers wrote: > thanks for this patch @mstorsjo ! This is help AOSP LLVM move our windows > builds of LLVM away from MinGW to LLVM! > https://android-review.googlesource.com/c/toolchain/llvm_andr

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

nickdesaulniers added a comment. thanks for this patch @mstorsjo ! This is help AOSP LLVM move our windows builds of LLVM away from MinGW to LLVM! https://android-review.googlesource.com/c/toolchain/llvm_android/+/1867380/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8de9aaef2f4: [llvm-rc] Add a GNU windres-like frontend to llvm-rc (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D1007

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added a comment. In D100756#2717331 , @amccarth wrote: > There's a lot going on here, but I don't see anything wrong. Thanks for the > completeness of the tests and the comments, as that helps a lot in > understanding what's going on here. Th

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. There's a lot going on here, but I don't see anything wrong. Thanks for the completeness of the tests and the comments, as that helps a lot in understanding what's going on here. =

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added a comment. Any further comments on this one, or is tolerable in this form? I'd prefer to not move the unescaping to shared code for now (as the exact definition of what it should do is a bit open). Repository: rG LLVM Github Monorepo

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; aganea wrote: > mstorsjo wrote: > > aganea wrote: > > > I would also need this fun

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; mstorsjo wrote: > aganea wrote: > > I would also need this function in D43002 (see unescapeSlashes), do you > > think we can m

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 339263. mstorsjo added a comment. Updated the capitalization of one variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100756/new/ https://reviews.llvm.org/D100756 Files: clang/test/CMakeLists.txt cla

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:259 -} // anonymous namespace +static bool consume_back_lower(StringRef &S, const char *str) { + if (!S.endswith_lower(str)) aganea wrote: > `s/str/Str/` Thanks, will fix. ===

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

aganea added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:259 -} // anonymous namespace +static bool consume_back_lower(StringRef &S, const char *str) { + if (!S.endswith_lower(str)) `s/str/Str/` Comment at: llvm/tools/llvm-rc

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 339158. mstorsjo added a comment. Rebased, updated with fixes making the full preprocessing test pass on windows, including fixes for the default arch when running on arches that aren't normally supported as windows targets. Repository: rG LLVM Github M

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 338978. mstorsjo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebased on top of the updated preceding patch. Adjusted the logic for picking th e default triple, to preserve the exact spelling of the default triple, i