amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land.
There's a lot going on here, but I don't see anything wrong. Thanks for the completeness of the tests and the comments, as that helps a lot in understanding what's going on here. ================ Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:295 + .Case(".o", Coff) + .Default(Unknown); + if (F != Unknown) ---------------- ".obj"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100756/new/ https://reviews.llvm.org/D100756 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits