mstorsjo added a comment.
In D100756#2717331 <https://reviews.llvm.org/D100756#2717331>, @amccarth wrote:
> There's a lot going on here, but I don't see anything wrong. Thanks for the
> completeness of the tests and the comments, as that helps a lot in
> understanding what's going on here.
Thanks!
With this in the tree, it'll be easier to reason about further requests to the
preprocessing, when both use cases are available at once.
================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:295
+ .Case(".o", Coff)
+ .Default(Unknown);
+ if (F != Unknown)
----------------
amccarth wrote:
> ".obj"?
Good point, I'll add that too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100756/new/
https://reviews.llvm.org/D100756
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
