[PATCH] D100085: [X86] Support -march=rocketlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fc1fe8db830: [X86] Support -march=rocketlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D100085: [X86] Support -march=rocketlake

skan accepted this revision. skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SG

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. s

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. Shouldn't

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 ___

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, @craig.topper, @skan, reviewers, I've addressed your comments. Any more concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 __

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336738. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/attr-target-mv

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. In D100085#2682080 , @craig.topper wrote: > Thanks. I also found this > https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff >can you create a new patch to do the same for llvm/clang and rebase

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added a comment. Thanks. I also found this https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff can you create a new patch to do the same for llvm/clang and rebase this patch on top of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @craig.topper and @skan , THX for review! I tested that deleting sgx indeed leads to not generating "+sgx" in 'target-features', didn't know before:) '+sgx' is not a recognized feature for this target (ignoring feature) Repository: rG LLVM Github Monorepo CH

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336303. FreddyYe added a comment. revert clang-format and revert deleting FeatureSGX def. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Ta

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336301. FreddyYe added a comment. cancel the clang-format in constexpr ProcInfo Processors[] = {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt", "

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt", "HasCLFLU

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271 "Invalidate Process-Context Identifier">; -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:293-301 +// Empty processor. Include X87 and CMPXCHG8 for backwards compatibility. +{{""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B}, +// i386-generation processors. +{{"i386"}, CK_i38

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336295. FreddyYe added a comment. delete FeatureSGX in the backend since there are no IR intrinsics for SGX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = RKSimon wrote: > Using ICLTuning suggests we should still be avoiding

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, FreddyYe wrote: > craig.topper wrote: > > Is this list t

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay , I tried to refactor the test file by assembling the common CHECKs. But I found it will lead to too many check-prefixes ine one RUN line. For example, // RUN: %clang -march=c3 -m32 -E -dM %s -o - 2>&1 \ // RUN: -target i386-unknown-linux \ // RUN

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336133. FreddyYe added a comment. Herald added a subscriber: jfb. update lit test and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib

[PATCH] D100085: [X86] Support -march=rocketlake

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = Using ICLTuning suggests we should still be avoiding 512-bit ops (Feat

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. In D100085#2675965 , @MaskRay wrote: > In D100085#2675919 , @FreddyYe > wrote: > >> Hi @MaskRay, I tried to refactor, but met some difficulties. Since these >> defines are dictionary or

[PATCH] D100085: [X86] Support -march=rocketlake

MaskRay added a comment. In D100085#2675919 , @FreddyYe wrote: > Hi @MaskRay, I tried to refactor, but met some difficulties. Since these > defines are dictionary ordered, a new #define may insert into a common CHECK. > So it is difficult to let differe

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs. // RUN: %clang -march=pentium-mmx -m32 -E -dM %s -o - 2

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336007. FreddyYe added a comment. Updating according to comments. Test refactoring not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. THX for review! Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1396 +// RUN: %clang -march=rocketlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ MaskRay wrote: > The file may need some refactor

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:101 INTEL_COREI7_ALDERLAKE, + INTEL_COREI7_ROCKETLAKE, AMDFAM19H_ZNVER3, This order is defined by libgcc. We can't insert in the middle unless ZNVER3 was in the wrong pla

[PATCH] D100085: [X86] Support -march=rocketlake

MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1396 +// RUN: %clang -march=rocketlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ The file may need some refactoring first. You can let RUN lin

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://revi