MaskRay added inline comments.
================ Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1396 +// RUN: %clang -march=rocketlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ ---------------- The file may need some refactoring first. You can let RUN lines share some common check prefixes, instead of adding a bunch of defines for every new processor. ``` // CHECK_X86_64_V2: ... // CHECK_X86_64_V2: ... // CHECK_X86_64_V3: ... // CHECK_PROCESSOR1_M32: // CHECK_PROCESSOR1_M64: // CHECK_PROCESSOR2_M32: // CHECK_PROCESSOR2_M64: ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
