[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGf253bb640d97: [WebAssembly] Fix simd bit shift intrinsics codegen (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https:/

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

junparser updated this revision to Diff 497935. junparser added a comment. Replace rem with bitmask operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https://reviews.llvm.org/D144169 Files: clang/lib/Headers/wasm_simd128.h cl

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

junparser created this revision. Herald added subscribers: pmatos, asb, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. junparser requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. According to gith

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } ChuanqiXu wrote: > junparser wrote: > > I mean, remove the if statements here since the retuen expr is null. > We cou

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } I mean, remove the if statements here since the retuen expr is null. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: clang/lib/CodeGen/CGCoroutine.cpp:650 - if (Stmt *Ret = S.getReturnStmt()) + if (Stmt *Ret = S.getReturnStmt()) { +// Since we already

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

junparser added a comment. Herald added a subscriber: pcwang-thead. @eopXD, hi, this patch make us lost +relax and -save-restore by default, would you please fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

junparser added a reverting change: rG07333810caee: Revert "Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default…. BRANCHES EmptyLineAfterFunctionDefinition, fix_asan, main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 __

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

junparser added a comment. In rGc93f93b2e3f28997f794265089fb8138dd5b5f13#1040054 , @lkail wrote: > Looks a more general way should be implemented in tailduplicator to avoid > adding quadratic edges in CFGs. yep， firs

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

junparser added a comment. Since we already have LowerSwitchPass to transform switchinst, can we add a cost modle and run it before vectorization? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108138/new/ https://reviews.llvm.org/D108138

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { bsmith wrote: > junparser wrote: > > I

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

junparser added inline comments. Herald added a subscriber: ctetreau. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { I

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG599b2f00370e: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser updated this revision to Diff 360690. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106333/new/ https://reviews.llvm.org/D106333 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaChec

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8677 + return Ty->getKind() == BuiltinType::SveBool + ? Context.getLangOpts().ArmSveVectorBits / Context.getCharWidth() + : Context.getLangOpts().ArmSveVectorBits;

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser updated this revision to Diff 360352. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106333/new/ https://reviews.llvm.org/D106333 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaChec

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. In D106333#2889859 , @paulwalker-arm wrote: > In D106333#2889168 , @junparser > wrote: > >> @efriedma with this patch, all of conversion between VLST and VLAT should >> have same vec

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. In D106333#2889168 , @junparser wrote: > @efriedma with this patch, all of conversion between VLST and VLAT should > have same vector size(getElementType() * getElementCount()). The regression > in D105097

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. @efriedma with this patch, all of conversion between VLST and VLAT should have same vector size(getElementType() * getElementCount()). The regression in D105097 will be fixed by using bitcast + vector.insert/extract directly Repos

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser created this revision. junparser added reviewers: efriedma, bsmith, joechrisellis, c-rhodes, paulwalker-arm. Herald added subscribers: psnobl, kristof.beyls, tschuett. junparser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Acc

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c:108 +// CHECK-128-NEXT:[[CASTFIXEDSVE:%.*]] = bitcast <2 x i8>* [[SAVED_VALUE]] to * +// CHECK-128-NEXT:[[TMP1:%.*]] = load , * [[CASTFIXEDSVE]], align 16, !tbaa [[TBAA6]]

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG3afbf898044a: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae5433945f91: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser updated this revision to Diff 355484. junparser added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new/ https://reviews.llvm.org/D105097 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2103 + if (const CallExpr *CE = dyn_cast(E)) +Ty = CE->getCallReturnType(CGF.getContext()); + efriedma wrote: > I don't think we need to call getCallReturnType() here. A

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser updated this revision to Diff 355460. junparser added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new/ https://reviews.llvm.org/D105097 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); efriedma wrote: > junparser wrote: >

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); junparser wrote: > efriedma wrote: >

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); efriedma wrote: > I don't think it's

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser created this revision. junparser added reviewers: joechrisellis, c-rhodes, efriedma, aeubanks, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. junparser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This chang

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354857. junparser added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_cnt

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354846. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_cnt

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:662 +return IC.replaceInstUsesWith(II, StepVal); + } else if (Pattern == AArch64SVEPredPattern::vl16 && NumElts == 16) { +Constant *StepVal = ConstantInt::get(II.getType()

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser added a comment. @sdesmalen @david-arm @paulwalker-arm kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 ___ cfe-commits mailing list cfe-c

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354427. junparser added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

junparser added a comment. In D98638#2630786 , @lxfind wrote: > Well, I guess another potential solution is to force emitting lifetime > intrinsics for this part of coroutine in the front-end. > Like this: > > diff --git a/clang/lib/CodeGen/CGDecl.cpp b

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. In D89066#2325358 , @lxfind wrote: > In D89066#2324291 , @junparser wrote: > >> In D89066#2324151 , @lxfind wrote: >> >>> In D89066#2324115

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. In D89066#2324151 , @lxfind wrote: > In D89066#2324115 , @junparser wrote: > >> why we should not do this with normal await call? > > To be honest, I don't know yet. My understanding of ho

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. why we should not do this with normal await call? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89066/new/ https://reviews.llvm.org/D89066 ___ cfe-commits mailing list cfe-comm

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Herald added a subscriber: modimo. @lxfind , could you backport this to branch 11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Thanks for the change. LGTM, and testcase？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D82442: [Coroutines] Warning if the return type of coroutine_handle::address is not void*

This revision was automatically updated to reflect the committed changes. Closed by commit rG8849831d55a2: [Coroutines] Warning if return type of coroutine_handle::address is not void* (authored by ChuanqiXu, committed by junparser). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D82442: [Coroutines] Warning if the return type of coroutine_handle::address is not void*

This revision was automatically updated to reflect the committed changes. Closed by commit rG8849831d55a2: [Coroutines] Warning if return type of coroutine_handle::address is not void* (authored by ChuanqiXu, committed by junparser). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2125713 , @lxfind wrote: > In D82314#2124662 , @junparser wrote: > > > In D82314#2124661 , @junparser > > wrote: > > > > > @lxfind This

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. @lxfind This patch causes some mismatch when variable is used in both resume and destroy function. Besides, we should move this patch and the check in buildCoroutineFrame. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2124661 , @junparser wrote: > @lxfind This patch causes some mismatch when variable is used in both resume > and destroy function. Besides, we should move this patch and the check in > buildCoroutineFrame. @lxfind,

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM， Thank you！ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 _

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. @lxfind, Thank you! And could you please add some testcases? Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1286 +continue; + if (CastInst) { +// If we have multiple cast instructions for the alloca, don't -

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2109437 , @lxfind wrote: > In D82314#2107910 , @junparser wrote: > > > Rather than doing it here, can we build await_resume call expression with > > MaterializedTemporaryExpr wh

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2109893 , @rsmith wrote: > In D82314#2109728 , @lxfind wrote: > > > @rsmith Thanks. That's a good point. Do you know if there already exists > > optimization passes in LLVM that

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. Rather than doing it here, can we build await_resume call expression with MaterializedTemporaryExpr when expand the coawait expression. That's how gcc does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

junparser added a comment. In D82029#2100675 , @modocache wrote: > Excellent, thank you! The test failures on the diff appear to be legitimate, > they reproduce for me when I apply this patch to my local checkout and run > `ninja check-clang`. Could you

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1776979fd8: [CodeGen][TLS] Set TLS Model for __tls_guard as well. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https:

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. @aaron.ballman thanks for the review. I have updated the patch. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622 Guard->setThreadLocal(true); +Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel()); aaron.ballman wrote

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser updated this revision to Diff 270969. junparser marked an inline comment as done. junparser added a comment. address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. @rnk @aaron.ballman any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser created this revision. junparser added reviewers: chh, rnk, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. junparser edited the summary of this revision. For now we do not set tls model for tls_guard with/without option -ftls-model which

[PATCH] D80979: [clang] Implement VectorType logic not operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0de3335edcf: [clang] Implement VectorType logic not operator. (authored by junparser). Changed prior to commit: https://reviews.llvm.org/D80979?vs=268649&id=269084#toc Repository: rG LLVM Github Mon

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268649. junparser added a comment. address the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/Sema

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:2 +// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s + +typedef __attribute__((__vector_size__(16))) float float4; erichkeane wrote: > I do

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:183 +// CHECK: @_Z5test7Dv4_j +int4 test7(uint4 V0) { + // CHECK: [[CMP0:%.*]] = icmp eq <4 x i32> [[V0:%.*]], zeroinitializer logic operatio

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268366. junparser added a comment. address the comment. hi @erichkeane, most of the function in vector-1.cpp are copied from ext-vector.c with vector type changed to gcc vector type, they should emit same ir. I add test7 and test8 which test logic opera

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. This patch implement the logic not operation of vector type. it keeps same behavior as gcc does (only allows in C++). I'll update the wrong testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://revi

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 3 inline comments as done. junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { erich

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. @erichkeane @aaron.ballman , kindly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___ cfe-commits mailing list cfe-comm

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser created this revision. junparser added reviewers: erichkeane, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. As title. This patch implement unary operator ! of vector type. TestPlan: check-clang Repository: rG LLVM Github Monorepo ht

[PATCH] D70555: [coroutines] Don't build promise init with no args

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. I'm not sure whether I can approve this. If not, @modocache please ignore this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/

[PATCH] D76119: [Coroutines] Insert lifetime intrinsics even O0 is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f4af8f3088: [Coroutines] Insert lifetime intrinsics even O0 is used (authored by junparser). Herald added a project: cla

[PATCH] D70555: [coroutines] Don't build promise init with no args

junparser added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D76118: [Coroutines] Do not evaluate InitListExpr of a co_return

This revision was automatically updated to reflect the committed changes. Closed by commit rG53c2e10fb8a6: [Coroutines] Do not evaluate InitListExpr of a co_return (authored by junparser). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. In D71903#1804016 , @modocache wrote: > I'm currently working on ensuring that CGSCC optimizations are rerun to > optimize coroutine funclets -- the primary feedback I received on this and on > D71899

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. There is another issue we should consider: clang is crashed when compile coroutine with -disable-llvm-passes and output an object file. Is it reasonable to run coroutine passes even -disable-llvm-passes is enabled? Comment at: clang/lib/CodeGen/Ba

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePass())); + MPM.addPass(createModuleT

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

junparser added a comment. This also fix same ice when build cppcoro with current trunk. FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits mai

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. In D69022#1756138 , @modocache wrote: > LGTM, thanks! Please let me know if you'd like me to commit this change. commit it please, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. In D69022#1755636 , @modocache wrote: > Sorry for the slow response here, @junparser! > > The test case you came up with here is great! I can see the issue is that > `ScopeInfo->CoroutineParameterMoves` are built up when Clang p

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser updated this revision to Diff 230581. junparser added a comment. update as @modocache's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/SemaCXX/coroutines.cpp Index: c

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a subscriber: rjmccall. junparser added a comment. In D69022#1720645 , @rjmccall wrote: > Despite generally knowing about coroutines and generally knowing about Clang, > I actually don't know the Clang coroutine code and can't review this

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. gental ping~ @modocache @GorNishanov Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser created this revision. junparser added reviewers: modocache, GorNishanov. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. The assertion of CoroutineParameterMoves happens when build coroutine function with arguments multiple time while fails to build promi