junparser added inline comments.

================
Comment at: clang/lib/AST/ASTContext.cpp:8677
+  return Ty->getKind() == BuiltinType::SveBool
+             ? Context.getLangOpts().ArmSveVectorBits / Context.getCharWidth()
+             : Context.getLangOpts().ArmSveVectorBits;
----------------
paulwalker-arm wrote:
> Out of interest is this indirection necessary? I mean we know sve predicates 
> are exactly an eighth the size of sve vectors so why not just use `8`?
Just want to keep same style since HandleArmSveVectorBitsTypeAttr use this.  8 
is make sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106333/new/

https://reviews.llvm.org/D106333

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to