junparser added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:662
+ return IC.replaceInstUsesWith(II, StepVal);
+ } else if (Pattern == AArch64SVEPredPattern::vl16 && NumElts == 16) {
+ Constant *StepVal = ConstantInt::get(II.getType(), NumElts);
----------------
david-arm wrote:
> Could you potentially fold these two cases into one somehow? Maybe with a
> switch-case statement? I'm just imagining a situation where we might want
> other patterns too like vl32, vl64, etc.
>
There is no other special pattern except vl16. But I do think switch-case is
more straightforward
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
https://reviews.llvm.org/D104852
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
