Re: [clang] c149ff3 - [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (#69817)

On Friday, October 27, 2023 10:43:23 AM CEST via cfe-commits wrote: > Author: Brad Smith > Date: 2023-10-27T04:43:19-04:00 > New Revision: c149ff3d372a70e7d9de838a1ff0357394b8d017 > > URL: > https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357 > 394b8d017 DIFF: > https://git

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

jsonn wrote: Can you as a small follow-up just update the comment to include that part? E.g. ``` # On ELF platforms, link tests with -Wl,--export-dynamic if supported by the linker. ``` Side note: the much older way for doing this is actually `-rdynamic`. https://github.com/llvm/llvm-project/p

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

jsonn wrote: Is this really desirable? It can actually break applications as it changes ELF semantics. https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

Re: How can Autoconf help with the transition to stricter compilation defaults?

Am Thu, Nov 17, 2022 at 10:58:52AM -0800 schrieb Paul Eggert via cfe-commits: > On 2022-11-16 10:59, Zack Weinberg wrote: > > I'm generally in agreement with Rich Felker's argument > > (inhttps://ewontfix.com/13/) that AC_CHECK_FUNC*should not* just probe for > > linkability of a symbol > > So

Re: [clang] e6629be - [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

On Mon, Jun 07, 2021 at 07:04:36PM -0700, via cfe-commits wrote: > > Author: =Jake Egan > Date: 2021-06-07T22:04:18-04:00 > New Revision: e6629be31e67190f0a524f009752d73410894560 > > URL: > https://github.com/llvm/llvm-project/commit/e6629be31e67190f0a524f009752d73410894560 > DIFF: > https://gi

[clang] 2628e91 - [NetBSD] Use cortex-a8 as default CPU for ARMv7

Author: Joerg Sonnenberger Date: 2021-02-18T01:53:04+01:00 New Revision: 2628e9146120507b2cf025f5c4ccc857cc3724c4 URL: https://github.com/llvm/llvm-project/commit/2628e9146120507b2cf025f5c4ccc857cc3724c4 DIFF: https://github.com/llvm/llvm-project/commit/2628e9146120507b2cf025f5c4ccc857cc3724c4.

[clang] 9d2d6e7 - Emit Objective-C constructors as writable

Author: Joerg Sonnenberger Date: 2020-04-14T22:32:34+02:00 New Revision: 9d2d6e71f096ad43b178c576adf94fc922034c73 URL: https://github.com/llvm/llvm-project/commit/9d2d6e71f096ad43b178c576adf94fc922034c73 DIFF: https://github.com/llvm/llvm-project/commit/9d2d6e71f096ad43b178c576adf94fc922034c73.

Re: [clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

On Thu, Mar 12, 2020 at 03:25:49PM -0700, Nick Desaulniers via cfe-commits wrote: > > Author: Nick Desaulniers > Date: 2020-03-12T15:13:59-07:00 > New Revision: 246398ece7115b57a02dbe7876d86ae8e72406ef > > URL: > https://github.com/llvm/llvm-project/commit/246398ece7115b57a02dbe7876d86ae8e72406

Re: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

On Mon, Mar 23, 2020 at 09:09:31AM -0700, Yaxun Liu via cfe-commits wrote: > > Author: Yaxun (Sam) Liu > Date: 2020-03-23T12:09:07-04:00 > New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > > URL: > https://github.com/llvm/llvm-project/commit/b670ab7b6b3d2f26179213be1da1d4ba376f50a3 > DIFF

[clang] 09d4021 - Fix compatibility for __builtin_stdarg_start

Author: Joerg Sonnenberger Date: 2020-03-28T23:24:13+01:00 New Revision: 09d402185394fdbf1f60233a7f42a4a1108c2cd3 URL: https://github.com/llvm/llvm-project/commit/09d402185394fdbf1f60233a7f42a4a1108c2cd3 DIFF: https://github.com/llvm/llvm-project/commit/09d402185394fdbf1f60233a7f42a4a1108c2cd3.

[clang] eb812ef - Explicitly include when using assert

Author: Joerg Sonnenberger Date: 2020-03-02T22:45:28+01:00 New Revision: eb812efa12fb82ca338794fa18b610ca9581aef5 URL: https://github.com/llvm/llvm-project/commit/eb812efa12fb82ca338794fa18b610ca9581aef5 DIFF: https://github.com/llvm/llvm-project/commit/eb812efa12fb82ca338794fa18b610ca9581aef5.

r375468 - Fix -fuse-init-array decision logic on NetBSD

Author: joerg Date: Mon Oct 21 16:35:33 2019 New Revision: 375468 URL: http://llvm.org/viewvc/llvm-project?rev=375468&view=rev Log: Fix -fuse-init-array decision logic on NetBSD For NetBSD 9 and later, it is the default. On older versions, only ARM and AArch64 use it by default. Modified: cf

r374742 - Improve __builtin_constant_p lowering

Author: joerg Date: Sun Oct 13 15:33:46 2019 New Revision: 374742 URL: http://llvm.org/viewvc/llvm-project?rev=374742&view=rev Log: Improve __builtin_constant_p lowering __builtin_constant_p used to be short-cut evaluated to false when building with -O0. This is undesirable as it means that const

Re: r371437 - [Driver] Add -static-openmp driver option

On Mon, Sep 09, 2019 at 06:31:41PM -, Pirama Arumuga Nainar via cfe-commits wrote: > Author: pirama > Date: Mon Sep 9 11:31:41 2019 > New Revision: 371437 > > URL: http://llvm.org/viewvc/llvm-project?rev=371437&view=rev > Log: > [Driver] Add -static-openmp driver option This still needs tes

Re: [PATCH] D67200: Add -static-openmp driver option

On Wed, Sep 04, 2019 at 11:28:34PM +, Pirama Arumuga Nainar via Phabricator via cfe-commits wrote: > pirama created this revision. > pirama added reviewers: Hahnfeld, danalbert, srhines, joerg. > Herald added a subscriber: guansong. > Herald added a reviewer: jdoerfert. > Herald added a projec

Re: [PATCH] D66361: Improve behavior in the case of stack exhaustion.

On Tue, Sep 03, 2019 at 06:02:28PM +, Richard Smith - zygoloid via Phabricator via cfe-commits wrote: > rsmith added a comment. > > In D66361#1655903 , @krytarowski > wrote: > > > This change broke on NetBSD. > > > > http://lab.llvm.org:8011/builders

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, Apr 17, 2019 at 05:34:04PM +, Kamil Rytarowski via Phabricator wrote: > Right now this blocks upgrades on NetBSD as a number of CPUs is affected (but > not x86, so it was overlooked before 8.0 by others than @joerg). Note that this is not about anything really specific to NetBSD, the

r355058 - Ensure that set constrained asm operands are not affected by truncation.

Author: joerg Date: Wed Feb 27 16:55:09 2019 New Revision: 355058 URL: http://llvm.org/viewvc/llvm-project?rev=355058&view=rev Log: Ensure that set constrained asm operands are not affected by truncation. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/test/Sema/inline-asm-

r355033 - Use Secure PLT as default on NetBSD/PowerPC.

Author: joerg Date: Wed Feb 27 13:46:01 2019 New Revision: 355033 URL: http://llvm.org/viewvc/llvm-project?rev=355033&view=rev Log: Use Secure PLT as default on NetBSD/PowerPC. Modified: cfe/trunk/lib/Driver/ToolChains/Arch/PPC.cpp cfe/trunk/test/Driver/netbsd.c Modified: cfe/trunk/lib/D

r354937 - Fix inline assembler constraint validation

Author: joerg Date: Tue Feb 26 16:40:59 2019 New Revision: 354937 URL: http://llvm.org/viewvc/llvm-project?rev=354937&view=rev Log: Fix inline assembler constraint validation The current constraint logic is both too lax and too strict. It fails for input outside the [INT_MIN..INT_MAX] range, but

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

On Thu, Jan 10, 2019 at 09:58:39AM -0800, Nick Desaulniers via cfe-commits wrote: > On Thu, Jan 10, 2019 at 7:26 AM Nico Weber wrote: > > > > Aren't C names sometimes slightly mangled too? For example, on macOS > > they're prefixed by a _, doesn't that have to be undone there? > > Sure, but sho

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Wed, Jan 09, 2019 at 12:20:06AM +, Kamil Rytarowski via Phabricator via llvm-commits wrote: > krytarowski added inline comments. > > > > Comment at: ELF/Driver.cpp:781 > + } > +} > + > > There is need to add a fallback for a native triple. Not really. T

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Tue, Jan 08, 2019 at 10:58:37PM +, Alexander Richardson via Phabricator via cfe-commits wrote: > arichardson added inline comments. > > > > Comment at: ELF/Driver.cpp:770 > + // Start with a default initial triple > + Config->TargetTriple = llvm::Triple(getDefaultTarget

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Fri, Jan 04, 2019 at 02:48:35PM +, Alexander Richardson via Phabricator wrote: > Or if you really need to call the linker directly without specifying > search paths you could also install a shell script as /usr/bin/ld that > passes the appropriate flags to /usr/bin/ld.lld? That's not a hon

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Fri, Jan 04, 2019 at 05:52:46AM +, Michał Górny via Phabricator via llvm-commits wrote: > mgorny added a comment. > > For the record, another option is to actually fix other software not to call > LD directly. See thousand monkeys. It doesn't really scale. Joerg

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 10:26:38PM +, Rui Ueyama via Phabricator via cfe-commits wrote: > I see there are pros and cons to not have host-specific config in ld. > That said, if other operating systems can live without host-specific > config in lld, why can't NetBSD do? I really don't like to be

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > I think that this place is not the right place to bash GNU ld for performance > issues. I didn't. > I will refer just to slides and paper from Ian Lance Taylor to get overview > why it is unacce

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > > > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > > via cfe-commits wrote: > > >

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Jan 03, 2019 at 05:01:00PM +, Ximin Luo via cfe-commits wrote: > My patch that Roman quoted in the email below was an additional > mechanism to set -fmacro-prefix-map and -fdebug-prefix-map via an > environment variable. This was not accepted into GCC because they are > (in summary) all

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 06:58:41PM +, Kamil Rytarowski via Phabricator wrote: > But the result is that we don't have GNU gold either and are stuck with > 40min linking times of LLVM. It's destructive to productivity and > damages any LLVM related development. The reason noone cared much about

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > Actually I find it frustrating and unfair as GNU ld doesn't have builtin > knowledge either.. it's passed with gross 'super hack' comments from build > scripts...

Re: [PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

On Sat, Dec 22, 2018 at 03:22:11AM +, Petr Hosek via Phabricator via cfe-commits wrote: > phosek created this revision. > phosek added a reviewer: echristo. > Herald added subscribers: cfe-commits, atanasyan, jrtc27, dberris, sdardis. > > This change introduces support for object files in add

Re: r349752 - Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

On Thu, Dec 20, 2018 at 01:09:30PM -, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Thu Dec 20 05:09:30 2018 > New Revision: 349752 > > URL: http://llvm.org/viewvc/llvm-project?rev=349752&view=rev > Log: > Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] > > Replace

Re: [PATCH] D55828: [clang] [Driver] Disable -faddrsig by default on NetBSD

On Tue, Dec 18, 2018 at 04:35:54PM +, Michał Górny via Phabricator via cfe-commits wrote: > mgorny created this revision. > mgorny added reviewers: krytarowski, pcc. > > Avoid passing -faddrsig by default on NetBSD. This platform is still > using old GNU binutils that crashes on executables

Re: [PATCH] D53922: [clangd] fix non linux build

On Wed, Oct 31, 2018 at 08:53:03AM +, Sam McCall via Phabricator via cfe-commits wrote: > sammccall accepted this revision. > sammccall added a comment. > This revision is now accepted and ready to land. > > Thanks! > We should work out what to do on BSD+Mac (and windows at some point), but

Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

On Wed, Sep 05, 2018 at 02:56:21PM -, Diogo N. Sampaio via cfe-commits wrote: > Author: dnsampaio > Date: Wed Sep 5 07:56:21 2018 > New Revision: 341475 > > URL: http://llvm.org/viewvc/llvm-project?rev=341475&view=rev > Log: > Fix arm_neon.h and arm_fp16.h generation for compiling with std=c

[libunwind] r337312 - The semantics of DW_CFA_GNU_args_size have changed subtile over the

Author: joerg Date: Tue Jul 17 12:00:51 2018 New Revision: 337312 URL: http://llvm.org/viewvc/llvm-project?rev=337312&view=rev Log: The semantics of DW_CFA_GNU_args_size have changed subtile over the years. Adopt the new convention that it is call-site specific and that it should be applied before

r337277 - Always use __mcount on NetBSD. Some platforms don't provide _mcount.

Author: joerg Date: Tue Jul 17 06:13:34 2018 New Revision: 337277 URL: http://llvm.org/viewvc/llvm-project?rev=337277&view=rev Log: Always use __mcount on NetBSD. Some platforms don't provide _mcount. Modified: cfe/trunk/lib/Basic/Targets/OSTargets.h cfe/trunk/test/CodeGen/mcount.c cf

r337274 - For NetBSD, unwind data is emitted by default, so also enable frame

Author: joerg Date: Tue Jul 17 05:38:57 2018 New Revision: 337274 URL: http://llvm.org/viewvc/llvm-project?rev=337274&view=rev Log: For NetBSD, unwind data is emitted by default, so also enable frame pointer optimisation by default when using optimisation. Modified: cfe/trunk/lib/Driver/ToolC

r337271 - By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64

Author: joerg Date: Tue Jul 17 05:33:19 2018 New Revision: 337271 URL: http://llvm.org/viewvc/llvm-project?rev=337271&view=rev Log: By popular demand, switch in64_t on NetBSD/AArch64 and NetBSD/PowerPC64 to long for consistency with other 64bit platforms. Modified: cfe/trunk/lib/Basic/Targets

r336947 - Support linking static PIE binaries on NetBSD

Author: joerg Date: Thu Jul 12 14:21:29 2018 New Revision: 336947 URL: http://llvm.org/viewvc/llvm-project?rev=336947&view=rev Log: Support linking static PIE binaries on NetBSD Modified: cfe/trunk/lib/Driver/ToolChains/NetBSD.cpp cfe/trunk/test/Driver/netbsd.c Modified: cfe/trunk/lib/Dr

Re: r328040 - Set dso_local on string literals.

On Tue, Mar 20, 2018 at 05:01:24PM -0700, Rafael Avila de Espindola wrote: > Joerg Sonnenberger via cfe-commits writes: > > > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > > wrote: > >> Author: rafael > >> Date: Tue Mar 20 13:

Re: r328040 - Set dso_local on string literals.

On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits wrote: > Author: rafael > Date: Tue Mar 20 13:42:55 2018 > New Revision: 328040 > > URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev > Log: > Set dso_local on string literals. I wonder if unnamed_addr shouldn'

Re: [PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

On Mon, Feb 12, 2018 at 08:54:56PM +, Stephen Hines via Phabricator via cfe-commits wrote: > srhines added a comment. > > LGTM, but we should make sure that there are no objections, especially since > there is no rationale for why this was present to begin with. Older versions of the GNU un

Re: r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

On Wed, Oct 18, 2017 at 12:00:51AM -, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Tue Oct 17 17:00:50 2017 > New Revision: 316046 > > URL: http://llvm.org/viewvc/llvm-project?rev=316046&view=rev > Log: > Basic: fix __{,U}INTPTR_TYPE__ on ARM > > Darwin and OpenBSD ar

Re: [PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

On Tue, Sep 12, 2017 at 08:12:26PM +, Blower, Melanie via cfe-commits wrote: > How is platform opt-in accomplished, is it part of the configure step? It is part of the Linux toolchain, other platforms interested in this or equivalent functionality would have to duplicate the hook. Joerg _

Re: r312595 - [Darwin] Enable -fstack-protector (back) by default with -ffreestanding

On Tue, Sep 05, 2017 at 11:50:58PM -, Bruno Cardoso Lopes via cfe-commits wrote: > Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=312595&r1=312594&r2=312595&view=diff >

[libcxx] r311156 - Spelling

Author: joerg Date: Fri Aug 18 05:57:36 2017 New Revision: 311156 URL: http://llvm.org/viewvc/llvm-project?rev=311156&view=rev Log: Spelling Modified: libcxx/trunk/include/__tree Modified: libcxx/trunk/include/__tree URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__tree?rev=3

Re: r309940 - [mips] Implement -muninit-const-in-rodata

On Thu, Aug 03, 2017 at 02:01:17PM -, Simon Dardis via cfe-commits wrote: > Author: sdardis > Date: Thu Aug 3 07:01:17 2017 > New Revision: 309940 > > URL: http://llvm.org/viewvc/llvm-project?rev=309940&view=rev > Log: > [mips] Implement -muninit-const-in-rodata > > This option when combined

Re: [PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

On Tue, Jul 25, 2017 at 03:09:00PM -0400, Nico Weber via cfe-commits wrote: > On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote: > > > On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote: > > > If you need this behavior for something, that sounds like something a >

Re: [PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote: > If you need this behavior for something, that sounds like something a > -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++ > stdlib and nothing else. But the -lm is only there because -lc++ alone (

Re: [PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

On Sun, Jul 23, 2017 at 03:17:32PM -0400, Nico Weber via cfe-commits wrote: > On Sun, Jul 23, 2017 at 3:08 PM, Joerg Sonnenberger via Phabricator via > cfe-commits wrote: > > > joerg added a comment. > > > > I don't really like this. > > That's cool, you don't need to use the flag. I'm not talk

Re: [PATCH] D34440: [Clang] Expand response files before loading compilation database

On Fri, Jul 14, 2017 at 02:40:25PM +, Manuel Klimek via Phabricator via cfe-commits wrote: > klimek added a comment. > > In https://reviews.llvm.org/D34440#809581, @vladimir.plyashkun wrote: > > > > Are there any concerns using the alternative? > > > > I can't say that it's a big problems, b

r307665 - NetBSD uses soft-float by default, unless the environment is EABIHF or

Author: joerg Date: Tue Jul 11 08:50:48 2017 New Revision: 307665 URL: http://llvm.org/viewvc/llvm-project?rev=307665&view=rev Log: NetBSD uses soft-float by default, unless the environment is EABIHF or GNUEABIHF. Modified: cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp cfe/trunk/test/Prepr

r307664 - Run the preprocessor test as frontend test for NetBSD, since CC1 mode

Author: joerg Date: Tue Jul 11 08:49:45 2017 New Revision: 307664 URL: http://llvm.org/viewvc/llvm-project?rev=307664&view=rev Log: Run the preprocessor test as frontend test for NetBSD, since CC1 mode doesn't get flags like the default target CPU. Update for test to reflect the difference. Modif

Re: r307104 - Enable LLVM asan support for NetBSD/amd64

On Tue, Jul 04, 2017 at 07:55:56PM -, Kamil Rytarowski via cfe-commits wrote: > Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp?rev=307104&r1=307103&r2=307104&view=diff > =

r306965 - Add an option group for deprecated warnings. Add the removed

Author: joerg Date: Sat Jul 1 14:36:21 2017 New Revision: 306965 URL: http://llvm.org/viewvc/llvm-project?rev=306965&view=rev Log: Add an option group for deprecated warnings. Add the removed -fslp-vectorize-aggressive and -fno-slp-vectorize-aggressive flags back under this group and test for the

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Thu, Jun 22, 2017 at 11:09:48AM -0700, Akira Hatanaka wrote: > Do you want the same encoding for the bitfield “int : 1” you saw before > r297792, which is just “i"? > > The encoding for bitfield is normally bN where N is the number of bits, > but the comment in function EncodeBitField says GNU

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Mon, Jun 12, 2017 at 09:03:10PM +0200, Joerg Sonnenberger wrote: > On Thu, Jun 01, 2017 at 05:58:41PM -0700, Akira Hatanaka wrote: > > It crashes when there is an anonymous ivar of a bitfield type. > > > > @interface FormatScanner { > > int : 1; > > } > > @end > > > > @implementation FormatS

Re: r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

On Fri, Jun 16, 2017 at 10:40:18PM -, Petr Hosek via cfe-commits wrote: > @@ -53,8 +53,15 @@ using namespace clang::driver; > using namespace llvm::opt; > > std::string GetExecutablePath(const char *Argv0, bool CanonicalPrefixes) { > - if (!CanonicalPrefixes) > -return Argv0; > + if (

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Thu, Jun 01, 2017 at 05:58:41PM -0700, Akira Hatanaka wrote: > It crashes when there is an anonymous ivar of a bitfield type. > > @interface FormatScanner { > int : 1; > } > @end > > @implementation FormatScanner > @end > > I'm not sure if the code above is valid or not, but out of curiosit

Re: r303317 - The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop.

On Tue, May 30, 2017 at 07:01:22PM -0700, Nick Lewycky wrote: > Joerg Sonnenberger wrote: > > On Wed, May 17, 2017 at 11:56:55PM -, Nick Lewycky via cfe-commits > > wrote: > > > Author: nicholas > > > Date: Wed May 17 18:56:54 2017 > > > New Revision: 303317 > > > > > > URL: http://llvm.org/v

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Tue, Mar 14, 2017 at 04:00:53AM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Mar 13 23:00:52 2017 > New Revision: 297702 > > URL: http://llvm.org/viewvc/llvm-project?rev=297702&view=rev > Log: > [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded >

Re: r303317 - The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop.

On Wed, May 17, 2017 at 11:56:55PM -, Nick Lewycky via cfe-commits wrote: > Author: nicholas > Date: Wed May 17 18:56:54 2017 > New Revision: 303317 > > URL: http://llvm.org/viewvc/llvm-project?rev=303317&view=rev > Log: > The constant expression evaluator should examine function arguments for

Re: [PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

On Mon, Mar 13, 2017 at 10:37:41PM +, Reid Kleckner via Phabricator via cfe-commits wrote: > I don't agree. If we want to be good citizens on Linux, what's supposed > to happen is that we install our shared libraries into > /usr/lib/${distro_target}, which is what GCC does with its shared > co

Re: [PATCH] D30538: Add documentation for -fno-strict-aliasing

On Thu, Mar 02, 2017 at 04:20:47PM +, Simon Byrne via Phabricator via cfe-commits wrote: > simonbyrne created this revision. > > This is probably good to document, as the behaviour of `-fstrict-aliasing` > differs from gcc in a quite important way (see > https://bugs.llvm.org//show_bug.cgi?

[libcxx] r294585 - Use protected name for the prototype arguments.

Author: joerg Date: Thu Feb 9 08:12:29 2017 New Revision: 294585 URL: http://llvm.org/viewvc/llvm-project?rev=294585&view=rev Log: Use protected name for the prototype arguments. Modified: libcxx/trunk/include/__threading_support libcxx/trunk/include/thread Modified: libcxx/trunk/includ

r292119 - Ensure that clang -pthread creates the right macro. -D_POSIX_THREADS

Author: joerg Date: Mon Jan 16 08:07:24 2017 New Revision: 292119 URL: http://llvm.org/viewvc/llvm-project?rev=292119&view=rev Log: Ensure that clang -pthread creates the right macro. -D_POSIX_THREADS seems to have been a C&P error from old GCC specs for OpenBSD. Modified: cfe/trunk/lib/Basic

r291814 - Add entry for -MJ.

Author: joerg Date: Thu Jan 12 15:11:55 2017 New Revision: 291814 URL: http://llvm.org/viewvc/llvm-project?rev=291814&view=rev Log: Add entry for -MJ. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/

r291437 - Use the same ABI logic for AArch64 Big Endian as in other places

Author: joerg Date: Mon Jan 9 05:40:41 2017 New Revision: 291437 URL: http://llvm.org/viewvc/llvm-project?rev=291437&view=rev Log: Use the same ABI logic for AArch64 Big Endian as in other places covering polys. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/Sema

r291436 - Extend NetBSD/AArch64 to cover Big Endian as well.

Author: joerg Date: Mon Jan 9 05:22:14 2017 New Revision: 291436 URL: http://llvm.org/viewvc/llvm-project?rev=291436&view=rev Log: Extend NetBSD/AArch64 to cover Big Endian as well. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/net

r291148 - Typo

Author: joerg Date: Thu Jan 5 11:59:44 2017 New Revision: 291148 URL: http://llvm.org/viewvc/llvm-project?rev=291148&view=rev Log: Typo Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

On Tue, Dec 27, 2016 at 12:41:08PM -0800, Saleem Abdulrasool wrote: > Id really rather not change the behavior. We would generate ELF style PIC, > which obviously doesn't work. That's not what I mean. I simply say that we should ignore -fPIC/-fpic/-fPIE/-fpie on Windows, silently. The relality is

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

On Mon, Dec 26, 2016 at 03:35:25AM -, Saleem Abdulrasool via cfe-commits wrote: > Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows Can we please invert this behavior? Complain if the effective PIC mode is not level 2 and silently ignore it otherwise? I find the MinGW warnings to be highly a

r289744 - Use PIC relocation mode by default for PowerPC64 ELF

Author: joerg Date: Wed Dec 14 18:02:57 2016 New Revision: 289744 URL: http://llvm.org/viewvc/llvm-project?rev=289744&view=rev Log: Use PIC relocation mode by default for PowerPC64 ELF Most of the PowerPC64 code generation already creates PIC access. This changes to a full PIC default, similar to

r288828 - Fix FileCheck pattern.

Author: joerg Date: Tue Dec 6 11:06:33 2016 New Revision: 288828 URL: http://llvm.org/viewvc/llvm-project?rev=288828&view=rev Log: Fix FileCheck pattern. Modified: cfe/trunk/test/Driver/compilation_database.c Modified: cfe/trunk/test/Driver/compilation_database.c URL: http://llvm.org/viewv

r288827 - Allow additional output since e.g. OSX appends flags like

Author: joerg Date: Tue Dec 6 11:02:41 2016 New Revision: 288827 URL: http://llvm.org/viewvc/llvm-project?rev=288827&view=rev Log: Allow additional output since e.g. OSX appends flags like "-mlinker-version=264.3.102" automatically. Wiring down a target on the other hand is problematic as this ac

r288823 - Make test case slightly more robust by explicitly passing --sysroot.

Author: joerg Date: Tue Dec 6 10:47:00 2016 New Revision: 288823 URL: http://llvm.org/viewvc/llvm-project?rev=288823&view=rev Log: Make test case slightly more robust by explicitly passing --sysroot. Otherwise it would change when DEFAULT_SYSROOT is provided. Modified: cfe/trunk/test/Driver/

r288822 - If clang was configured for a DEFAULT_SYSROOT and no --sysroot argument

Author: joerg Date: Tue Dec 6 10:40:57 2016 New Revision: 288822 URL: http://llvm.org/viewvc/llvm-project?rev=288822&view=rev Log: If clang was configured for a DEFAULT_SYSROOT and no --sysroot argument is seen, record one with the implicit default. Modified: cfe/trunk/lib/Driver/Tools.cpp

r288821 - Allow clang to write compilation database records.

Author: joerg Date: Tue Dec 6 10:33:22 2016 New Revision: 288821 URL: http://llvm.org/viewvc/llvm-project?rev=288821&view=rev Log: Allow clang to write compilation database records. When integrating compilation database output into existing build systems, two approaches dominate so far. Ad-hoc i

r288436 - Extend CompilationDatabase by a field for the output filename

Author: joerg Date: Thu Dec 1 17:37:45 2016 New Revision: 288436 URL: http://llvm.org/viewvc/llvm-project?rev=288436&view=rev Log: Extend CompilationDatabase by a field for the output filename In bigger projects like an Operating System, the same source code is often compiled in slightly differe

r287947 - Typo.

Author: joerg Date: Fri Nov 25 14:15:57 2016 New Revision: 287947 URL: http://llvm.org/viewvc/llvm-project?rev=287947&view=rev Log: Typo. Modified: cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp Modified: cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp URL: http://llvm.org/viewvc/llvm-project/cf

r287926 - Document the arguments form of commands.

Author: joerg Date: Fri Nov 25 08:14:43 2016 New Revision: 287926 URL: http://llvm.org/viewvc/llvm-project?rev=287926&view=rev Log: Document the arguments form of commands. Modified: cfe/trunk/docs/JSONCompilationDatabase.rst Modified: cfe/trunk/docs/JSONCompilationDatabase.rst URL: http://

r287847 - Spelling.

Author: joerg Date: Wed Nov 23 19:24:38 2016 New Revision: 287847 URL: http://llvm.org/viewvc/llvm-project?rev=287847&view=rev Log: Spelling. Modified: cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h Modified: cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h URL: http://l

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

joerg added a comment. Besides "it triggers on SPEC", why should the warning be disabled here? I think it is perfectly sensible to have a warning for all six conditional contexts here. https://reviews.llvm.org/D26636 ___ cfe-commits mailing list c

[PATCH] D26564: Use PIC relocation mode by default for PowerPC64 ELF

joerg created this revision. joerg added a reviewer: hfinkel. joerg added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. Most of the PowerPC64 code generation already creates PIC access. This changes to a full PIC default, similar to what GCC is doing. Overall, a monolithic clan

Re: r286376 - [Sparc] LLONG is not lock-free atomic on v8

On Wed, Nov 09, 2016 at 03:43:52PM -, Douglas Katzman via cfe-commits wrote: > Author: dougk > Date: Wed Nov 9 09:43:51 2016 > New Revision: 286376 > > URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev > Log: > [Sparc] LLONG is not lock-free atomic on v8 Technically, even 32bit is

[PATCH] D23657: Remove some false positives when taking the address of packed members

joerg added a comment. It works for me with the mentioned TODO item. But I'm not the right one to give a full OK. https://reviews.llvm.org/D23657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Mon, Oct 31, 2016 at 01:25:19PM -0700, Richard Smith wrote: > We could alternatively control the language features based only on the > selected language mode, and only use version detection to power a warning > for the (currently fairly common, but becoming less so) case where the > selected run

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Mon, Oct 31, 2016 at 10:45:05AM -0700, Richard Smith via cfe-commits wrote: > On Sun, Oct 30, 2016 at 12:32 PM, Joerg Sonnenberger wrote: > > > On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote: > > > Richard requested this change. Take a look at > > > https://reviews.llvm.org/D260

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Sun, Oct 30, 2016 at 01:49:53PM -0600, Eric Fiselier via cfe-commits wrote: > > E.g. presence of libc++ won't tell you if you can use sized deallocation > > as that's a ABI library issue. > > The value of __libcpp_version could easily be updated by vendors to store > the version of the system

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote: > Richard requested this change. Take a look at > https://reviews.llvm.org/D26044 for more rational. I don't see much rational and in fact, I disagree with some of the mentioned items. E.g. presence of libc++ won't tell you if you can

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Fri, Oct 28, 2016 at 06:06:50AM -, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Oct 28 01:06:50 2016 > New Revision: 285382 > > URL: http://llvm.org/viewvc/llvm-project?rev=285382&view=rev > Log: > Add __libcpp_version file and __libcpp_library_version function. I real

[PATCH] D25204: Register Calling Convention, Clang changes

joerg added a comment. The __ namespace is shared between all parts of the implementation, not just the compiler. The convention in the past was that compiler keywords will end in a __ as well, but calling conventions and Objective C broke that convention. I still think it is something that sho

[PATCH] D25204: Register Calling Convention, Clang changes

joerg added a comment. Can we please avoid adding more (pseudo) keywords in the double-underscore name space? Those tend to be used a lot by existing libc implementations and existing attribute cases like __strong and __weak have created enough trouble. https://reviews.llvm.org/D25204 _

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

joerg added a comment. So the historical reason for the libgcc_s dance for glibc was the use of unwinding for thread cancellation. With all the glibc versions I can find, going back to SLES11 SP1, this is no longer the case. To check for yourself, look for _Unwind* symbols in libc.so and libc.a

[PATCH] D25431: [libcxx] Convert Solaris support library to C++ to fix -std=c++11 build

joerg accepted this revision. joerg added a reviewer: joerg. joerg added a comment. This revision is now accepted and ready to land. Commit the prototype fix separately, please. https://reviews.llvm.org/D25431 ___ cfe-commits mailing list cfe-commit

[PATCH] D23657: Remove some false positives when taking the address of packed members

joerg added a comment. I agree that leaving out the really complicated parts is acceptable for now. Can you mark the comment as TODO? https://reviews.llvm.org/D23657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D23657: Remove some false positives when taking the address of packed members

joerg added a comment. It seems like on-stack arrays still don't work? #include struct test { uint32_t x; } __attribute__((__packed__)); int main(void) { struct test __attribute__((__aligned__(4))) a[4]; uint32_t *p32; p32 = &a[0].x; } https://reviews.llvm.org/D

Re: [libunwind] r284125 - [libunwind] Add missing include. NFC.

On Thu, Oct 13, 2016 at 02:32:24PM -, Asiri Rathnayake via cfe-commits wrote: > This missing include seems to cause compilation failures on older MacOS > versions (< 10.9). This is because r270692 has introduced uint64_t into > config.h without including this header. But that would be inttype

  1   2   3   >