On Thu, Dec 20, 2018 at 01:09:30PM -0000, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Thu Dec 20 05:09:30 2018 > New Revision: 349752 > > URL: http://llvm.org/viewvc/llvm-project?rev=349752&view=rev > Log: > Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI] > > Replace multiple comparisons of getOS() value with FreeBSD, NetBSD, > OpenBSD and DragonFly with matching isOS*BSD() methods. This should > improve the consistency of coding style without changing the behavior. > Direct getOS() comparisons were left whenever used in switch or switch- > like context.
Personally, I consider this a step backwards and I hugely dislike the pointless proliferation of isOS* methods. Joerg _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
