[PATCH] D151869: [RISCV] Enable more builtin for zvfhmin without zvfh

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d2536c82fc4: [RISCV] Enable more builtin for zvfhmin without zvfh (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D151869: [RISCV] Enable more builtin for zvfhmin without zvfh

jacquesguan added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151869/new/ https://reviews.llvm.org/D151869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

jacquesguan marked an inline comment as done. jacquesguan added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158259/new/ https://reviews.llvm.org/D158259 ___ cfe-commits mailing list cf

[PATCH] D151869: [RISCV] Support more builtin for zvfhmin.

jacquesguan updated this revision to Diff 553051. jacquesguan added a comment. Herald added subscribers: wangpc, sunshaoce. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151869/new/ https://reviews.llvm.org/D151869 Files: clang/include/cl

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG654fa9a7e898: [RISCV] Add Zvfhmin extension for clang (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan updated this revision to Diff 552622. jacquesguan added a comment. Herald added subscribers: wangpc, sunshaoce. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/cl

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:90 +// +vfloat32m1_t add_f32(vfloat32m1_t a, vfloat32m1_t b) { + return a + b; Jim wrote: > Do we support operation for vflo

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14906 +// specified +if (S.Context.areCompatibleRVVTypes(QualType(OriginalTarget, 0), +QualType(Source, 0))

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157130/new/ https://reviews.llvm.org/D157130 _

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG28741a23c9fc: [clang][SVE] Rename isVLSTBuiltinType, NFC (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://review

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan added a comment. In D158045#4592331 , @paulwalker-arm wrote: > I'd hope there are common code paths where `isVLSTBuiltinType` would still be > useful but I guess this step is required to make that happen anyway. > > If you permit a minor req

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan updated this revision to Diff 550967. jacquesguan added a comment. rename to isSveVLSBuiltinType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://reviews.llvm.org/D158045 Files: clang/include/clang/AST/Type.h clan

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan updated this revision to Diff 550627. jacquesguan added a comment. fix compile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://reviews.llvm.org/D158045 Files: clang/include/clang/AST/Type.h clang/lib/AST/ASTContex

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan created this revision. jacquesguan added reviewers: DavidTruby, efriedma, peterwaller-arm, paulwalker-arm, bsmith, c-rhodes, sdesmalen, rsandifo-arm, ctetreau, cameron.mcinally, aaron.ballman. Herald added a subscriber: psnobl. Herald added a project: All. jacquesguan requested review

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jacquesguan marked an inline comment as done. Closed by commit rG9d0cf88e7086: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available (authored b

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/docs/LanguageExtensions.rst:815 * X86 (if SSE2 is available; natively if AVX512-FP16 is also available) + * RISC-V (natively if Zfh is available) craig.topper

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh is available

jacquesguan updated this revision to Diff 549779. jacquesguan added a comment. Add Zhinx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157693/new/ https://reviews.llvm.org/D157693 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/Lan

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zfhmin is available

jacquesguan updated this revision to Diff 549311. jacquesguan added a comment. remove zfmin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157693/new/ https://reviews.llvm.org/D157693 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/L

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zfhmin is available

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck, luke. Herald added subscribers: s.egerton, simoncook. Herald added a project: All. jacquesguan requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157584/new/ https://reviews.llvm.org/D157584 _

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf808788487ab: [RISCV] Remove experimental for zihintntl (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157586/new/ https://reviews.llvm.org/D157586 _

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

jacquesguan updated this revision to Diff 548903. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 548848. jacquesguan added a comment. rebase and add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is already merged, any more advice about this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4514424 , @asb wrote: > I remain concerned about exposing the intrinsics if they're not yet agreed as > finalised. I see there is now a PR to add them to riscv-c-api doc > https://github.com/riscv-non-isa/riscv-c-

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 542290. jacquesguan marked 2 inline comments as done. jacquesguan added a comment. rebase main and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan marked 2 inline comments as done. jacquesguan added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:151 // RUN: -o - | FileCheck --check-prefix=CHECK-ZIHINTNTL-EXT %s // CHECK-ZIHINTNTL-EXT: __riscv_zihintntl 2000{{$}}

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 541904. jacquesguan added a comment. Address comment and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV.

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. Herald added a subscriber: wangpc. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2219 + def vfwcvt_f_f_v : RVVConvBuiltin<"w", "wv", "f", "vfwcvt_f">; + let RequiredFeatures = ["ZvfhminOrZvfh"] in +def vfwcvt_f_f_v_fp16 : RVVConvBuiltin<"w", "wv", "x", "vfwcvt_f"> {

[PATCH] D151869: [RISCV] Support more builtin for zvfhmin.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck, michaelmaitland. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan updated this revision to Diff 527312. jacquesguan added a comment. Update dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35a0079238ce: [RISCV] Add Zvfhmin extension for clang. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan updated this revision to Diff 526872. jacquesguan added a comment. Address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added a comment. In D150253#4382884 , @craig.topper wrote: > Do we need to enable these intrinsics for Zvfhmin? > > vfloat16mf4_t __riscv_vle16_v_f16mf4 (const float16_t *base, size_t vl); > vfloat16mf2_t __riscv_vle16_v_f16mf2 (const flo

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added a comment. In D150253#4381435 , @craig.topper wrote: > We need to support reinterpret intrinsics so that we can load/store bf16 > values. Sorry, I don't understand your comment well. I think that change you mentioned should not be in

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4375613 , @asb wrote: > Thanks for the patch. > > Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating > the mistake we made with the V extension where we exposed intrinsics that > weren't ye

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, ed

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 5 inline comments as done. jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } craig.topper wrote: > michaelm

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 8 inline comments as done. jacquesguan added a comment. https://reviews.llvm.org/D151414 this is the backend part. Comment at: clang/include/clang/Basic/riscv_vector.td:1856 def vfwcvt_f_x_v : RVVConvBuiltin<"Fw", "Fwv", "csi", "vfwcvt_f">; - def vfwcvt_f

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 525494. jacquesguan added a comment. Split into 2 revisions and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basi

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 523696. jacquesguan added a comment. Fix indention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td clang/inc

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. @michaelmaitland , I update this revision with my local branch. May you have a look and see what missed compared with you version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 523688. jacquesguan added a comment. make f16 vector type legal for Zvfhmin, add predicates to enable 2 convert pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. In D150253#4343699 , @craig.topper wrote: > In D150253#4341545 , @jacquesguan > wrote: > >> To enable specific EEW for specific insturction in instruction selection, I >> will creat

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. To enable specific EEW for specific insturction in instruction selection, I will create some parent revisions. Here is the first one. https://reviews.llvm.org/D150550 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15025

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwa

[PATCH] D150021: [RISCV] Make zve32f imply F and zve64d imply D.

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150021/new/ https://reviews.llvm.org/D150021

[PATCH] D148908: [Driver][NFC] Simplify code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3a5a965a14: [Driver][NFC] Simplify code. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148908/new/ https://reviews.llvm.org/D14

[PATCH] D148908: [Driver][NFC] Simplify code.

jacquesguan created this revision. Herald added a project: All. jacquesguan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148908 Files: clang/lib/Driver/Driver.cp

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145659/new/ https://reviews.llvm.org/D145659 ___ cfe-commits mailing list cf

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

jacquesguan added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:433 +AVRTargetInfo::handleAsmEscapedChar(char EscChar) const { + char C; + switch (EscChar) { redundant variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb4c0c37078: [RISCV] Recover the implication between Zve* extensions and the V extension. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

jacquesguan added a comment. In D119210#3318348 , @eopXD wrote: > Kindly reverse ping. > May you land this change? OK, right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/ https://reviews.

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

jacquesguan created this revision. jacquesguan added reviewers: eopXD, kito-cheng. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehou

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan updated this revision to Diff 403858. jacquesguan added a comment. Update code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/CodeGen/R

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:747 // Could not implement Zve* extension and the V extension at the same time. - if (HasZve32x && HasV) + if (HasZve && HasV) return createStringError( craig.topper wrote:

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan updated this revision to Diff 403503. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Code

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan added a comment. In D118225#3272071 , @eopXD wrote: > Not sure if this simplifies things. Users and the compiler can use the macro > `__riscv_v_elen` and `__riscv_v_elen_fp` to do things to the vector-related > target feature. > > Other tha

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, eopXD, asb, luismarques, frasercrmck, HsiangKai, khchen, benshi001. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, joce

[PATCH] D118015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea3dfa5d015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck, HsiangKai, khchen, benshi001. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, P

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba16e3c31f66: [RISCV] Decouple Zve* extensions and the V extension. (authored by jacquesguan). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402401. jacquesguan added a comment. Rebase main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402385. jacquesguan added a comment. Herald added a subscriber: pcwang-thead. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/inclu

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402188. jacquesguan added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3978 for (StringRef F : ReqFeatures) { -if (TI.hasFeature(F)) - continue; - -// If the feature is 64bit, alter the string so it will print better in -// the diagnostic. -if (F =

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402184. jacquesguan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan added a comment. In D117854#3263206 , @eopXD wrote: > Maybe change the title to address more specifically of what this patch does? Done, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117920: [RISCV] Decouple V and Zve64*

jacquesguan added a comment. I did some similar change in my revision https://reviews.llvm.org/D117854. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117920/new/ https://reviews.llvm.org/D117920 ___ cfe-

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

jacquesguan updated this revision to Diff 402173. jacquesguan added a comment. Herald added a subscriber: jdoerfert. Fix test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/lib/Basi

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

jacquesguan added a comment. In D117854#3261659 , @craig.topper wrote: > In D117854#3261618 , @eopXD wrote: > >> A question that bothers me is that we need to specify a specific feature to >> enable the TARGET_B

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

jacquesguan updated this revision to Diff 402166. jacquesguan added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.or

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5475 + if (IndexVT.getVectorElementType() == MVT::i64 && XLenVT == MVT::i32) { +report_fatal_error("The V extension does not support EEW=64 for index " craig.topper

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

jacquesguan added a comment. Sorry, I should use --author="Luhaocong " in my git command, and I will pay attention next time to land revision that created by other one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115430/new/ https://reviews.llv

[PATCH] D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c11e9528683: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

jacquesguan created this revision. jacquesguan added reviewers: HsiangKai, khchen, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:179 const std::vector &IntrinsicTypes, - StringRef RequiredExtension, unsigned NF); + const std::vector RequiredExtensions, unsigned NF); ~RVVIntri

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:680 foreach type = TypeList in { -foreach eew_list = EEWList in { +foreach eew_list = Xlen32EEWList in { defvar eew = eew_list[0]; HsiangKai

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t craig.topper wrote: > jacquesguan wrote: > > kito-cheng wrote: > >

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t kito-cheng wrote: > I guess you want to verify `vfredsum.vs` and `

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:555 +defvar Xlen32EEWList = [["8", "(Log2EEW:3)"], +["16", "(Log2EEW:4)"], frasercrmck wrote: > jrtc27 wrote: > > Ignoring whether the change is act

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:693 +let Name = op # eew64 # "_v", IRName = op, IRNameMask = op # "_mask", +RequiredExtensions = ["Xlen64"] in { +def: RVVBuiltin<"v", "vPCe" # eew64_type # "U

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. In D106518#2895445 , @craig.topper wrote: > Why do they need to be disabled? Doesn’t the spec define them to truncate? In the 1.0-rc1, 18.2: The V extension supports all vector load and store instructions (Section Vector Lo

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

jacquesguan updated this revision to Diff 357408. jacquesguan added a comment. Add target feature zvlsseg for rvv-intrinsics/vlsegff.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105626/new/ https://reviews.llvm.org/D105626 Files: clang/test/C

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

jacquesguan created this revision. jacquesguan added a reviewer: craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva02