[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Sure! Ishaan Gandhi ishaangandhi AT gmail DOT com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. I remember now, @njames93 : Without the `-fix-errors`, the test fails as follows: Command Output (stdout): -- Running ['clang-tidy', '/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/bra

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441192. ishaangandhi added a comment. Remove `-fix-errors` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Does anybody on this thread have land permissions? If not, would anyone know who to tag? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cf

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. @LegalizeAdulthood Thanks! I don't have commit rights to the repository, can you commit it on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 440071. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439596. ishaangandhi added a comment. Alphabetize some more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote: > > Eugene.Zelenko wrote: > > > ishaangandhi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439501. ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Change doc path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/Bran

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi marked an inline comment as done. ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439488. ishaangandhi added a comment. Alphabetize release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > ishaangandhi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439369. ishaangandhi added a comment. Use `auto` instead of `Expr` and `llvm::cast` instead of `llvm::dyn_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/b

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Documentation path was changed recently.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:28 +const Expr *RHSExpr = llvm::dyn_cast(RHS); +if (LHSExpr->containsErrors() && RHSExpr->containsErrors()) { + return false; njames93 wrote: >

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439239. ishaangandhi added a comment. Include `error: ` in error line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439228. ishaangandhi added a comment. Check for error messages in test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439226. ishaangandhi added a comment. Move test to new file with `-fix-errors` flag CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439221. ishaangandhi added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ishaangandhi requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The clang-tidy check `bugprone-branch-clone` has a

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added a comment. In D124262#3472079 , @sammccall wrote: > Thanks! > I can land this for you if you don't have commit access - can you provide the > name/email to use for the commit? Thank you! Ishaan Gandhi ishaangan...@gmail.com CHANGES

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424914. ishaangandhi added a comment. Made test case reflect that proxies for ".H" files are ".C" files, and not ".c files". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: clang/lib/Tooling

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added inline comments. Comment at: clang/unittests/Tooling/CompilationDatabaseTest.cpp:852 + add("other/random/path.cpp"); + // Proxies for ".H" files are ".C" files, and not ".cpp files" + EXPECT_EQ(getProxy("foo/bar/baz/exact.H"), "foo/bar/baz/exact.C"); ---

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424906. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp clang/unittests/Tooling/CompilationDatabaseTest.cpp Index: clang/unittests/Too

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Test case added, re-diffed with `-U`, and removed redundant constructor. Thanks for the quick feedback, @sammccall! (I didn't wait for the tests to run locally, I am hoping to use your CI systems to do that. It see

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424904. ishaangandhi added a comment. - Added a test case - Removed redundant "StringRef" constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: cl

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi created this revision. ishaangandhi added reviewers: nridge, sammccall. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ishaangandhi requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This