ishaangandhi added a comment.
I remember now, @njames93 :
Without the `-fix-errors`, the test fails as follows:
Command Output (stdout):
--
Running ['clang-tidy',
'/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp',
'-fix', '--checks=-*,bugprone-branch-clone', '-config={}', '--', '-std=c++11',
'-nostdinc++']...
clang-tidy
/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp
-fix --checks=-*,bugprone-branch-clone -config={} -- -std=c++11 -nostdinc++
failed:
3 errors generated.
Error while processing
/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp.
/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp:4:7:
error: use of undeclared identifier 'unknown_expression_1'
[clang-diagnostic-error]
if (unknown_expression_1) { //
^
/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp:5:15:
error: use of undeclared identifier 'unknown_expression_2'
[clang-diagnostic-error]
function1(unknown_expression_2); //
^
/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/branch-clone-unknown-expr.cpp.tmp.cpp:7:15:
error: use of undeclared identifier 'unknown_expression_3'
[clang-diagnostic-error]
function2(unknown_expression_3); //
^
Found compiler errors, but -fix-errors was not specified.
I won't update the diff, since I assume you will want to see the buildkite
failure for yourself.
Once you see it, can you either confirm `-fix-errors` was correct originally,
or instruct me on how to fix this test failure?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128402/new/
https://reviews.llvm.org/D128402
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
