ishaangandhi added inline comments.
================
Comment at: clang/unittests/Tooling/CompilationDatabaseTest.cpp:852
+ add("other/random/path.cpp");
+ // Proxies for ".H" files are ".C" files, and not ".cpp files"
+ EXPECT_EQ(getProxy("foo/bar/baz/exact.H"), "foo/bar/baz/exact.C");
----------------
sammccall wrote:
> Is this really what you intend to test?
>
> I think our goal here is to treat `.H` and `.C` as C++ rather than C, not to
> link them together in some way. If the current file is `foo.H`, then
> `foo.cpp` and `foo.C` should be equally compelling candidates, but both beat
> `foo.c`.
Bleh brain fart. You're right. "exact.C" should win over "exact.c", not
necessarily "exact.cpp".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124262/new/
https://reviews.llvm.org/D124262
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
