[PATCH] D145214: [TSAN] add support for riscv64

haowei added a comment. Hi, I believe you forgot to add `tsan_rtl_riscv64.S` to your patch when you land it. We are seeing build errors on our bots with following messages: -- Configuring done (12.3s) CMake Error at /b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cm

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. In D158948#4642475 , @danix800 wrote: > In D158948#4642422 , @haowei wrote: > >> Looking at >> https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. Hi I am working on updating GoogleTest in LLVM to v1.14.0 and during my local testing, I noticed that this patch added 2 new tests `ImportMatrixType` and `ImportOpenCLPipe` through `TEST_P` calls, however, both tests were not instantiated by `INSTANTIATE_TEST_SUITE_P` so

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. FYI, this patch fails the Windows bots in a different way. (you can see the error triggered in the pre-merge build in https://buildkite.com/llvm-project/premerge-checks/builds/161603#018909c4-fe90-4de6-91a3-d251dc5ada8f) The error message from our builders are: Script

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Thanks for reverting. I wasn't doing any changes to this when you were asking though, but looking at build log, it looks like the assertion error disappeared after f4de606ef271fe362f03d30c53a850f9877ec238

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Hi, we are seeing a test error on `Clang :: ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error message: Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/llvm_build/tools/clang/test/ExtractAPI/Output/constructor_destructor.cpp.tmp : 'R

[PATCH] D155241: [Fuchsia] Skip building debuginfod if httplib_ROOT is not specified

haowei created this revision. haowei added reviewers: phosek, mysterymath. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch skipds building debuginfod if htt

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa872aa221e2: [Fuchsia] Enable libcxx filesystem on Windows build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

haowei updated this revision to Diff 535194. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153931/new/ https://reviews.llvm.org/D153931 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

haowei created this revision. haowei added reviewers: phosek, Prabhuk. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables the libcxx filesystem when bu

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei added a comment. In D152318#4402234 , @mstorsjo wrote: > FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. > While it does match a GNU binutils tool, I'm kinda curious where it is needed. llvm-strings exists in the `output

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb398898dad9: [Fuchsia] Add llvm-strings to Fuchsia clang build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei created this revision. haowei added reviewers: phosek, mcgrathr. Herald added subscribers: abrachet, mstorsjo. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds 'llvm-strings' to Fuch

[PATCH] D150939: [CMake] Remove BOLT from Fuchsia toolchain

haowei added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150939/new/ https://reviews.llvm.org/D150939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe38cdc5933b0: Disable compiler launcher on external projects and multi stage clang (authored by haowei). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D148383: [driver] Enable response file when using lld on baremetal targets

haowei created this revision. haowei added reviewers: mcgrathr, phosek. Herald added a subscriber: abidh. Herald added a project: All. haowei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch enables response file support w

[PATCH] D146987: [Assignment Tracking] Enable by default

haowei added a comment. This patch (which enables assignment tracking) and D147312 breaks llvm runtime build for `runtimes-armv7-unknown-linux-gnueabihf` Error message: FAILED: libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o /b/s/w/ir/cache/goma/clie

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM, but please wait @phosek to approve it. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif()

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() You probably need a `string(REPLACE ";" "|" value "${_FUCHSIA_ENABLE_PROJECTS}")` after append a value.

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

haowei updated this revision to Diff 502841. haowei retitled this revision from "Add option to disable compiler launcher on external projects" to "Disable compiler launcher on external projects and multi stage clang". haowei edited the summary of this revision. Repository: rG LLVM Github Monor

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei updated this revision to Diff 501670. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 Files: clang/CMakeLists.txt clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake llvm

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162223 , @phosek wrote: > I agree, in that case let's remove > `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default > passthrough variables which seems like a reasonable default, and provide > `CLANG_

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162048 , @smeenai wrote: > Hmm, what cache key does ccache use for compilers? Is it the `--version` > output string, the path, or some combination? If the path is involved then I > don't see any value in using ccache

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7bb9a363923: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

haowei created this revision. haowei added reviewers: phosek, abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables LLVM_USE_RELATIVE_PATHS_IN_FILES when building the bootstrap too

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using compiler caching program li

[PATCH] D144595: [WIP] Experimenting building Windows runtimes when cross compiling LLVM toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: kristof.beyls. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a working in progress pat

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac835ecb5fea: [Fuchsia] Set /winsysroot in Windows runtimes linker flags (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141808: [Driver] Add --vfsoverlay flag

haowei added a comment. I am seeing test failures on pre submit Windows builder after this change was landed: See https://buildkite.com/llvm-project/premerge-checks/builds/135752#01864d34-9024-4c13-9137-88b6f41ec695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets '/winsysroot' flag when building Windows

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

haowei added a comment. There are also cases that this clang type-limit check will warn when checking if a enum type is larger than 0. For example, we are seeing warnings on ICU source code (https://github.com/unicode-org/icu/blob/8d5a97ae0f49f6974372736ca67db15c37522f6f/icu4c/source/i18n/displ

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

haowei added a comment. FYI, this patch looks like was pushed into a new "Main" branch instead of the actual "main" branch. It causes git checkout failures on Windows, see error message: warning: encountered old-style '/ssl/certs/ca-bundle.crt' that should be '%(prefix)//ssl/certs/ca-bundle.c

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcdab04c250: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D141738?vs=493766&id=495281#toc Repository: rG

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1c8917afd3: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency

haowei updated this revision to Diff 495221. haowei marked an inline comment as done. haowei retitled this revision from "[Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency" to "[Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency". haowei edited the summary of this revision

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

This revision was automatically updated to reflect the committed changes. Closed by commit rG630266aed342: [Fuchsia] Simplified the stage2 build setup (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D143288?vs=494694&id=495216#toc Repository: rG LLVM Github Monorepo

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:170-171 runtimes + llvm-rc + llvm-mt CACHE STRING "") phosek wrote: > Could we do this in > https://github.com/llvm/llvm-project/blob/98f0

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei updated this revision to Diff 494755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt =

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplified the BOOTSTRAP_ flags, allowing the

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei updated this revision to Diff 494364. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake ===

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 493766. haowei added a comment. Correct dependency issues on llvm-mt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. llvm-mt and llvm-rc tools are capable of building clang

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20bb7658f53b: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit: https://reviews.llv

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added a comment. Thanks for the review. I will land the change once Fuchsia clang builders are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 __

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake Index: llv

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490921. haowei added a comment. Correct an issue llvm-rc and llvm-mt are not part of `TOOLCHAIN_TOOLS` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/c

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:73 + +if(WIN32 OR (LINUX AND WINDOWS_SDK_DIR)) +#if(WINDOWS_SDK_DIR) phosek wrote: > I'd drop this part altogether, let's build these anytim

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490679. haowei retitled this revision from "[WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain" to "Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang tool

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 489177. haowei added a comment. Correct C, CXX flag issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmak

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Work in progress. Initial work on bui

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3edb627201: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/ https://

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change includes llvm-ml tool in Fuchsia toolchain.

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. In D137473#3993584 , @bnbarham wrote: > LGTM. If you could put up a PR after to fix the use of > `sys::fs::make_absolute` that would be appreciated 🙇. Thanks, I will start working on the fix. Repository: rG LLVM Github Monore

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa903ecb4a26d: [vfs] Allow root paths relative to the vfsoverlay YAML file (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482658. haowei added a comment. Rebased the change to solve the merge conflicts on the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/In

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. I changed some comments and add more details. If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1933-

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482644. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c llvm/include/llvm/Su

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1922 + EC = FS->makeAbsolute(FullPath, Name); + Name = canonicalize(Name); +} else { bnbarham wrote: > Why the canonicalization? If the Name here somehow ha

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475884. haowei marked 2 inline comments as done. haowei added a comment. Fixing Windows test failures. overlay-relative flag will always using native path separator, therefore, it needs a separate base FS and OverlayYAML file setup on Windows. This diff adds

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:1010 + std::error_code makeAbsolute(StringRef WorkingDir, + SmallVectorImpl &Path) const; bnbarham wr

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475591. haowei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml cla

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475574. haowei added a comment. I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475347. haowei added a comment. Unit test failures under Windows should be fixed now. Root->name will also use base FS's current directory instead of process current directory now. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', haowei wrote: > haowei wrote: > > bnbarham wrote: > > > bnbarham wrote: > > > > I

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 474391. haowei added a comment. Add additional unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml c

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', bnbarham wrote: > bnbarham wrote: > > I'd prefer a test without `overlay-relative

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 474115. haowei marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/V

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added reviewers: bnbarham, keith. haowei added a comment. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 ___ cfe-commits mailing lis

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei created this revision. haowei added reviewers: phosek, abrachet. Herald added a subscriber: hiraditya. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. VFS overlay file allow using

[PATCH] D134371: [clang-doc] Add typedef/using information.

haowei added a comment. In D134371#3819605 , @nemanjai wrote: > This causes failures with `-Werror` such as: > https://lab.llvm.org/buildbot/#/builders/57/builds/22322 > Please fix or revert. Thanks for reporting this. I reverted this change. Reposito

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM @paulkirth Do you have more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 ___

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId &F) { switch (ID) { case REFERENCE_USR: This block ID came from L582, which read from a bitcode file when `BI_REFEREN

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. @brettw Thanks for the clarification. I was oncall for buildgardener last week and got quite busy due to breakages. Thanks for your clarification, that is really helpful to understand the your intent. While I still don't see the way these constructors are implemented is

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. I am a bit puzzled by the intent of cleaning up the constructors in Info object. I didn't see it as an issue to have multiple constructors, which is a common practice. After this clean up It doesn't make it easier to use these objects, in fact, in `Serialize.cpp`, you ha

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

haowei added subscribers: mcgrathr, phosek, gulfem. haowei added a comment. After looking into the code, I think I should point out that `compiler-rt/include/profile/InstrProfData.inc` is a published header and its API details cannot be changed trivially without coordination with external users

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

haowei added a comment. We are also saw failures on Fuchsia builders when using ToT clang: [31281/267743] CXX host_x64/obj/src/lib/llvm-profdata/llvm-profdata-for-test.llvm-profdata.cc.o FAILED: host_x64/obj/src/lib/llvm-profdata/llvm-profdata-for-test.llvm-profdata.cc.o ../../../recipe_c

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

haowei added subscribers: haowei, phosek, mcgrathr. haowei added a comment. Hi, We are seeing build failures on Fuchsia build bots after this change was landed. and we suspect this patch causes clang to miscompile certain code. I filed bug https://github.com/llvm/llvm-project/issues/57351 and i

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I tested this patch on our windows builder and it passed as well. This patch LGTM. (I cannot click accept as the this review is already closed) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 __

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. In D126192#3583915 , @benshi001 wrote: > It seems the file > `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` > is missing on your machine, which I have newly created in current patch. That

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. Emmm, I applied your latest patch on top of main(6e02e27536b9de25a651cfc9c2966ce471169355 ) but I still get a test failure on `Clang :: Driver/avr-toolchain.c`. `Clang :: Driver/avr-ld.c` no longer fai

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

haowei added a comment. I tested this patch on top of https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 (reverted in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad) and Clang driver tests now pass without issue. Reposit

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I already reverted the change in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad . It is likely the breakage is caused by the fact that Fuchsia's Clang by default use `lld`, see `clang/cmake/caches/Fuchsia-stage2.cmake:set(CLANG_DEFA

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. We are seeing Clang driver test failures after this patch. On Fuchsia's mac clang builder, `Clang :: Driver/avr-ld.c` and `Clang :: Driver/avr-toolchain.c` are failing. Failed build task: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8811424

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. In D119479#3387880 , @zixuw wrote: > @haowei I got a quick fix of completely purging the generator output in the > test case. Could you take a look to have a sanity check before I land the fix > on main? > > diff --git a/clang/

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. We are seeing test failures after this patch is landed: Clang :: SymbolGraph/global_record.c Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp : 'RUN: at line 2'; split-file /b/s/w

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

haowei added a comment. Hi, we are seeing clang Windows build breakages after this change was relanded error message: Assertion failed: isa(Val) && "cast() argument of incompatible type!", file C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include\llvm/Support/Casting.h, line 262 PLEASE submit a

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG07bed3ae52b0: [clang][Fuchsia] Add additional unit test for availability attr (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112271/new/

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

haowei created this revision. haowei added reviewers: phosek, leonardchan, gulfem. Herald added a subscriber: abrachet. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds additional unit tests for availability attribute

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378324. haowei added a comment. Added unit test when "-ffuchsia-api-level" is supplied with a non integer value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files:

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei added a comment. I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4 +// +// It should also be exposed to non-fuchsia plat

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cla

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; -

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377726. haowei marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/D

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

  1   2   >