haowei added inline comments.
================ Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() ---------------- You probably need a `string(REPLACE ";" "|" value "${_FUCHSIA_ENABLE_PROJECTS}")` after append a value. As by default cmake use `|` to separate items. But do you actually need a `_FUCHSIA_ENABLE_PROJECTS` variable, couldn't you just append `lldb` at the end of `LLVM_ENABLE_PROJECTS` here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145449/new/ https://reviews.llvm.org/D145449 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits