haowei added subscribers: mcgrathr, phosek, gulfem. haowei added a comment.
After looking into the code, I think I should point out that `compiler-rt/include/profile/InstrProfData.inc` is a published header and its API details cannot be changed trivially without coordination with external users, so seemingly cosmetic changes should be avoided if they might require changes for users of the header, which includes changing any of the identifiers. In our case, Fuchsia uses the API in this file and due to this change, we are seeing build breakages. At this point. I recommend to revert all related changes to this code review instead of trying to attempt to fix the problem multiple times without success. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131714/new/ https://reviews.llvm.org/D131714 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
