[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae4275557ca: [clang][NFC] Fix needless double-parenthisation (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108359/new/ https://reviews

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo added a reviewer: Anastasia. wingo added a comment. Just a little thing I saw while reading code -- if no response in a couple weeks I will just abandon the rev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108359/new/ https://reviews.llvm.o

[PATCH] D108360: [clang][NFC] Remove dead code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3af1e77341: [clang][NFC] Remove dead code (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a comment. @Anastasia is this good to go for you or does this need closer attention? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360 ___ cfe-commits

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: sbc100. wingo added a comment. Thanks again John & Thomas for your thoughts. In D108464#2961595 , @rjmccall wrote: > In D108464#2960791 , @tlively wrote: > >> I don't think it makes sens

[PATCH] D108459: [clang][CodeGen] Rely on implicitly invalid Address. NFC.

wingo abandoned this revision. wingo added a comment. Closing PR as it turns out that I don't need the Address() change for my work; no need to churn here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108459/new/ https://reviews.llvm.org/D108459

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo abandoned this revision. wingo added a comment. In D108458#2957789 , @rjmccall wrote: > You can still use a type without a default constructor in a `DenseMap`; you > just have to use `insert` instead of `dict[key] = ...`. Aaaah, thanks for this no

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo updated this revision to Diff 368098. wingo added a comment. Rebase to no longer require Address default constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108464/new/ https://reviews.llvm.org/D108464 Files: clang/lib/CodeGen/CGBui

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb0c083429a: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment (authored by wingo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8da70fed704c: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D108445: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3d4d98576f4: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108445/new/ https://reviews

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a subscriber: tlively. wingo added a comment. Thanks for feedback! Following up on general question in D108464 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: tlively. wingo added a comment. In D108464#2957276 , @wingo wrote: > So... besides the refactor, this is getting closer to where I'm going in > https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still >

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:115 - /// Emit a load from an i1 flag variable. - llvm::LoadInst *CreateFlagLoad(llvm::Value *Addr, it's the change to always return an `Address` from `CreateTempAlloca` that makes these

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a comment. So... besides the refactor, this is getting closer to where I'm going in https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still NFC. I think you can see where I would replace `getASTAllocaAddressSpace` with `getAllocaAddressSpace(QualType Ty)`,

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo created this revision. wingo added a reviewer: rjmccall. Herald added subscribers: lxfind, sunfish, dschuff. wingo requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added a project: clang. It used to be tha

[PATCH] D108459: [clang][CodeGen] Rely on implicitly invalid Address. NFC.

wingo created this revision. Herald added a subscriber: lxfind. wingo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Remove explicit uses of Address::invalid in initializers; the default constru

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo added inline comments. Comment at: clang/lib/CodeGen/Address.h:31 : Pointer(pointer), Alignment(alignment) { assert((!alignment.isZero() || pointer == nullptr) && "creating valid address with invalid alignment"); It would be nice to

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

wingo created this revision. wingo added a reviewer: rjmccall. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows a declaration of an Address to be invalid by default, allowing it to be added to e.g. a DenseMap. Will followu

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

wingo added a comment. I tested by building with all targets enabled and there was no change in test results, running clang, llvm, and lld tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108450/new/ https://reviews.llvm.org/D108450 _

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

wingo created this revision. wingo added a reviewer: rjmccall. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This function was defaulting to use the ABI alignment for the LLVM type. Here we change to use the preferred alignment. T

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

wingo added a reviewer: rjmccall. wingo added a comment. Just a drive-by cleanup while poking other address-space-related things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108449/new/ https://reviews.llvm.org/D108449 __

[PATCH] D108449: [clang][NFC] Tighten up code for GetGlobalVarAddressSpace

wingo created this revision. Herald added a subscriber: Anastasia. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LangAS local is only used in the OpenCL case; move its decl inwards. Repository: rG LLVM Github Monorepo https

[PATCH] D108445: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS

wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass a LangAS instead of a target address space to GetOrCreateLLVMGlobal, to remove a place where the frontend assumes that target address space 0 is special

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a reviewer: rjmccall. wingo added a comment. Hi John, I am new to clang, having mostly worked on the WebAssembly target in llvm proper. I have a stack of patches related to address space treatment in codegen -- most of them NFC refactors to later allow the WebAssembly target to all

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo added a reviewer: rsmith. wingo added a comment. Hi Richard, I am new to clang, having mostly worked on the WebAssembly target in llvm proper -- I have a stack of patches, of which a couple later ones touch Sema/. See https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html for bro

[PATCH] D108360: [clang][NFC] Remove dead code

wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove code that has no effect in SemaType.cpp:processTypeAttrs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108360 Files: clang/li

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Strip a layer of parentheses in TreeTransform::RebuildQualifiedType. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108359 Files: clan

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82f92e35c646: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. Quick r? to @tlively -- OK with having the new util function in WebAssemblyFrameLowering? It didn't work to have it in the utils library because the function needs the vtable of WebAssemblyFunctionInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348758. wingo added a comment. Fix shared-library build by moving util function to WebAssemblyFrameLowering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: ll

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo reopened this revision. wingo added a comment. This revision is now accepted and ready to land. Yarrrgh, broke the shared library build. Fix incoming... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D1011

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf35f4af51cd: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786870 , @jrtc27 wrote: > In D101140#2786844 , @wingo wrote: > >> In D101140#2786777 , @jrtc27 wrote: >> >>> Is it just me or does havin

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786777 , @jrtc27 wrote: > Is it just me or does having a backend-specific type in target-independent > code feel wrong? It feels like there should be a space for target-specific > TargetStackIDs... Hoo, good question.

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348493. wingo added a comment. Herald added subscribers: foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simonc

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ecf18979e3: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348467. wingo added a comment. Adapt test to insert compiler barrier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: llvm/include/llvm/CodeGen/MIRYamlMapping.

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/ir-locals.ll:17-20 + ; The DAG combiner infers that %reloaded is the same as %arg and + ; ultimately causes "local.get 0" to be emitted instead of + ; "local.get 1". + ; CHECK-NEXT: local.get 0 ---

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. Gentle ping here to @tlively :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:351 IO.enumCase(ID, "scalable-vector", TargetStackID::ScalableVector); +IO.enumCase(ID, "object", TargetStackID::Object); IO.enumCase(ID, "noalloc", TargetStackID::NoAlloc);

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 346990. wingo marked 4 inline comments as done. wingo added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: llvm/include/llvm/CodeG

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 346986. wingo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: llvm/include/llvm/CodeGen/MIRYamlMapping.h llvm/include/llvm/CodeGen/Ta

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:15 multiclass TABLE { + let mayLoad = 1 in defm TABLE_GET_#rt : I<(outs rt:$res), (ins table32_op:$table), pmatos wrote: > tlively wrote: > > wingo wrote: > > > I t

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7086af2143d: [WebAssembly] Support for WebAssembly globals in LLVM IR (authored by pmatos, committed by wingo). Repository: rG LLVM Github Monore

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 344323. wingo added a comment. Update in response to parent commit changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: clang/lib/Basic/Targets/WebAssembly.

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 344320. wingo added a comment. Rename "managed" address space to "wasm vars" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets/WebAssembl

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: > tlively w

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 343367. wingo added a comment. Rename "object" to "managed", and add test for stack id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: clang/lib/Basic/Targets/

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 343360. wingo added a comment. yarr, shiver me timbers, fix me typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets/WebAssembly.h cl

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 343344. wingo added a comment. Rename "object" address space to "managed"; address feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Ta

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISD.def:48 + +// Reference Types +HANDLE_MEM_NODETYPE(GLOBAL_GET) tlively wrote: > sbc100 wrote: > > Is this just for ref types or also for global that hold integers too (like > > `_

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo marked an inline comment as done. wingo added a comment. Thanks for the review! Regarding the address space name -- the intention with "object" was to rhyme a bit with "object capabilities", somehow, but I see that it is confusing. How about `WASM_ADDRESS_SPACE_MANAGED` ? I.e. this addre

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342970. wingo added a comment. Pull in fixes from D101140 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Ta

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342963. wingo marked 2 inline comments as done. wingo added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo marked 3 inline comments as done. wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1324 +{LN->getChain(), Base}, LN->getMemoryVT(), LN->getMemOperand()); +return DAG.getMergeValues({GlobalGet, LN->getChain()}, DL);

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

wingo added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:150 : WebAssemblyTargetInfo(T, Opts) { -resetDataLayout("e-m:e-p:32:32-i64:64-n32:64-S128"); +resetDataLayout("e-m:e-p:32:32-i64:64-n32:64-S128-ni:1"); } This change

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 342719. wingo added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.llvm.org/D101608 Files: clang/lib/Basic/Targets/WebAssembly.h clang/test/CodeGen/target

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 342698. wingo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang datalayout expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.ll

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 341868. wingo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang datalayout expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.ll