wingo added a comment.

Sooooo... besides the refactor, this is getting closer to where I'm going in 
https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still 
NFC.  I think you can see where I would replace `getASTAllocaAddressSpace` with 
`getAllocaAddressSpace(QualType Ty)`, and possibly (depending on the source 
language) avoid casting the resulting alloca to `LangAS::Default`.  WDYT, is 
this sort of thing OK?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108464/new/

https://reviews.llvm.org/D108464

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to