wingo added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuilder.h:115
- /// Emit a load from an i1 flag variable.
- llvm::LoadInst *CreateFlagLoad(llvm::Value *Addr,
----------------
it's the change to always return an `Address` from `CreateTempAlloca` that
makes these methods unnecessary.
================
Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:116
llvm::Value *Arg = Args[I].getRValue(*this).getScalarVal();
- Builder.CreateAlignedStore(Arg, P, DL.getPrefTypeAlign(Arg->getType()));
+ // FIXME: Changing the following line to Builder.CreateStore(Arg, P)
+ // results in a test failure in OpenMP/nvptx_target_printf_codegen, in
----------------
this is an open question -- there could be a bug here in the existing code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108464/new/
https://reviews.llvm.org/D108464
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
