[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Chuanqi Xu via cfe-commits
@@ -43,17 +46,24 @@ namespace clang { // Macro locations have the top bit set, we rotate by one so it is the low bit. class SourceLocationEncoding { using UIntTy = SourceLocation::UIntTy; - constexpr static unsigned UIntBits = CHAR_BIT * sizeof(UIntTy); static UIntTy en

[clang] [clang] Improve constexpr-unknown diagnostics. (PR #146288)

2025-07-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/19001 Here is the relevant

[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Haojian Wu via cfe-commits
@@ -43,17 +46,24 @@ namespace clang { // Macro locations have the top bit set, we rotate by one so it is the low bit. class SourceLocationEncoding { using UIntTy = SourceLocation::UIntTy; - constexpr static unsigned UIntBits = CHAR_BIT * sizeof(UIntTy); static UIntTy en

[clang] [flang] [flang] Add -fcomplex-arithmetic= option and select complex division algorithm (PR #146641)

2025-07-07 Thread Shunsuke Watanabe via cfe-commits
@@ -3409,3 +3409,30 @@ StringRef tools::parseMRecipOption(clang::DiagnosticsEngine &Diags, return Out; } + +std::string tools::ComplexRangeKindToStr(LangOptions::ComplexRangeKind Range) { s-watanabe314 wrote: Thank you for the review. I have corrected the

[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Haojian Wu via cfe-commits
hokein wrote: > Why is this a new review? What changed from the last one I looked at? Ah, right -- this patch is actually derived from the previous one, and it is simpler. That older patch became a bit outdated since some of its changes were split out and already landed in main. I found it eas

[clang] [clang] Improve constexpr-unknown diagnostics. (PR #146288)

2025-07-07 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/146288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0717657 - [clang] Improve constexpr-unknown diagnostics. (#146288)

2025-07-07 Thread via cfe-commits
Author: Eli Friedman Date: 2025-07-07T23:35:10-07:00 New Revision: 071765749a70b22fb62f2efc07a3f242ff5b4c52 URL: https://github.com/llvm/llvm-project/commit/071765749a70b22fb62f2efc07a3f242ff5b4c52 DIFF: https://github.com/llvm/llvm-project/commit/071765749a70b22fb62f2efc07a3f242ff5b4c52.diff

[clang] [clang] Consistently handle consteval constructors for variables. (PR #144970)

2025-07-07 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/144970 >From b1f7402423af22b0ea8cdf0b3d3734bcce68a636 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 19 Jun 2025 18:29:49 -0700 Subject: [PATCH 1/2] [clang] Consistently handle consteval constructors for

[clang] [Clang] Fix template arguments collection for out-of-line declarations (PR #147463)

2025-07-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes We were using the lexical DC as the starting point of template argument collection when comparing declarations. This caused an issue that template arguments from out-of-line declarations are ignored when sub

[clang] [Clang] Fix template arguments collection for out-of-line declarations (PR #147463)

2025-07-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/147463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Report wider source range for unsafe buffers warnings (PR #147363)

2025-07-07 Thread Corentin Jabot via cfe-commits
cor3ntin wrote: This change needs a release note. Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, and referencing any Github issue this change fixes. Thanks! https://github.com/llvm/llvm-project/pull/147363 ___

[clang] [llvm] [NFC][PowerPC] Add test case for lockdown of vector compare greater than support for Zero vector comparisons (PR #147246)

2025-07-07 Thread via cfe-commits
Himadhith wrote: - The assertions for this file `clang/test/CodeGen/PowerPC/check-zero-vector.c` are auto-generated. - But for the file `llvm/test/CodeGen/PowerPC/check-zero-vectors.ll`, the generated assertions were very long, I have limited them to the important code blocks. Also changed th

[clang] [Clang] Fix template arguments collection for out-of-line declarations (PR #147463)

2025-07-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/147463 We were using the lexical DC as the starting point of template argument collection when comparing declarations. This caused an issue that template arguments from out-of-line declarations are ignored when substi

[clang] [clang][Sema] Two-pass noreturn inference via CFG for always-throwing functions (PR #147447)

2025-07-07 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/147447 >From 21f0d364933cd59acaa1fb323c1018dbce7c3452 Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 7 Jul 2025 19:02:38 -0700 Subject: [PATCH 1/3] Add logic to suppress noreturn falling for some basic co

[clang] [RISCV] Add missing intrinsicis vrgatherei16/vslideup/vslidedown support for Zvfbfmin (PR #146309)

2025-07-07 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/146309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Shilei Tian via cfe-commits
shiltian wrote: For some reason there is a crash in `llvm/test/CodeGen/AMDGPU/llvm.amdgcn.tanh.ll`. ``` LLVM ERROR: Cannot select: t28: ch = store<(store (s16) into %ir.out.load, addrspace 1)> t0, t27, t30, undef:i64 t27: i16 = bitcast t21 t21: bf16 = llvm.amdgcn.tanh TargetConstant:i64<

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Shilei Tian via cfe-commits
@@ -13658,6 +13658,7 @@ bool SITargetLowering::isCanonicalized(Register Reg, const MachineFunction &MF, case Intrinsic::amdgcn_frexp_mant: case Intrinsic::amdgcn_fdot2: case Intrinsic::amdgcn_trig_preop: +case Intrinsic::amdgcn_tanh: shiltian w

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Igor Kudrin via cfe-commits
@@ -453,7 +450,7 @@ void ClassifyRefs::VisitCallExpr(CallExpr *CE) { const auto *UO = dyn_cast(Ex); if (UO && UO->getOpcode() == UO_AddrOf) Ex = UO->getSubExpr(); - classify(Ex, Ignore); + classify(Ex, Use); igorkudrin wrote: Than

[clang] [clang][Sema] Two-pass noreturn inference via CFG for always-throwing functions (PR #147447)

2025-07-07 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/147447 >From 21f0d364933cd59acaa1fb323c1018dbce7c3452 Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 7 Jul 2025 19:02:38 -0700 Subject: [PATCH 1/2] Add logic to suppress noreturn falling for some basic co

[clang] [clang][bytecode] Fix activating nested unions (PR #147338)

2025-07-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/147338 >From 8b42dbd7659ce5e424fb107a0d375f449a8d44a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 7 Jul 2025 18:06:04 +0200 Subject: [PATCH] [clang][bytecode] Fix activating nested unions

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Igor Kudrin via cfe-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/147221 >From f1e26fed6c5023ba59990112ec4a77b024247e4b Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Fri, 4 Jul 2025 23:55:41 -0700 Subject: [PATCH 1/3] [clang] Fix -Wuninitialized for values passed by const poin

[clang] [clang][bytecode] Create a temporary for discarded CXXBindTemporaryExprs (PR #147303)

2025-07-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/147303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4c98da2 - [clang][bytecode] Create a temporary for discarded CXXBindTemporaryExprs (#147303)

2025-07-07 Thread via cfe-commits
Author: Timm Baeder Date: 2025-07-08T06:00:52+02:00 New Revision: 4c98da2cadfb23f6d4070db9136d8dc0a379bcc1 URL: https://github.com/llvm/llvm-project/commit/4c98da2cadfb23f6d4070db9136d8dc0a379bcc1 DIFF: https://github.com/llvm/llvm-project/commit/4c98da2cadfb23f6d4070db9136d8dc0a379bcc1.diff L

[clang] [RISCV] Correct type lowering of struct of fixed-vector array in VLS (PR #147173)

2025-07-07 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 862c2fc - [RISCV] Run mem2reg for riscv-xcvalu-c-api.c and riscv-xcvalu.c. NFC.

2025-07-07 Thread Jim Lin via cfe-commits
Author: Jim Lin Date: 2025-07-08T11:04:10+08:00 New Revision: 862c2fc26eb1611e1c06dccaaa650fc29f2546de URL: https://github.com/llvm/llvm-project/commit/862c2fc26eb1611e1c06dccaaa650fc29f2546de DIFF: https://github.com/llvm/llvm-project/commit/862c2fc26eb1611e1c06dccaaa650fc29f2546de.diff LOG:

[clang] [llvm] [RISCV] Implement Clang Builtins for XAndesPerf Extension (PR #147018)

2025-07-07 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: Should we document this in https://github.com/riscv-non-isa/riscv-c-api-doc/blob/main/src/c-api.adoc? https://github.com/llvm/llvm-project/pull/147018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -13658,6 +13658,7 @@ bool SITargetLowering::isCanonicalized(Register Reg, const MachineFunction &MF, case Intrinsic::amdgcn_frexp_mant: case Intrinsic::amdgcn_fdot2: case Intrinsic::amdgcn_trig_preop: +case Intrinsic::amdgcn_tanh: arsenm wro

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Shilei Tian via cfe-commits
@@ -13658,6 +13658,7 @@ bool SITargetLowering::isCanonicalized(Register Reg, const MachineFunction &MF, case Intrinsic::amdgcn_frexp_mant: case Intrinsic::amdgcn_fdot2: case Intrinsic::amdgcn_trig_preop: +case Intrinsic::amdgcn_tanh: shiltian w

[clang] [clang][Sema] Two-pass noreturn inference via CFG for always-throwing functions (PR #147447)

2025-07-07 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 created https://github.com/llvm/llvm-project/pull/147447 This patch adds a new AnalysisBasedWarnings pass that runs right before IssueWarnings: 1. Pass 1 seeds trivial always-throwing functions. 2. Pass 2 performs a fixed-point CFG-based analysis (CheckFallThrough)

[libclc] [libclc] Declare workitem built-ins in clc, move ptx-nvidiacl workitem built-ins into clc (PR #144333)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [NFC] [C++] [Modules] Mark P2788 as implemented and add test (PR #147138)

2025-07-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/147138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 48ff068 - [NFC] [C++] [Modules] Mark P2788 as implemented and add test (#147138)

2025-07-07 Thread via cfe-commits
Author: Ashwin Kishin Banwari Date: 2025-07-08T10:01:08+08:00 New Revision: 48ff068c525922e8323982795c69bbfbe49fea1e URL: https://github.com/llvm/llvm-project/commit/48ff068c525922e8323982795c69bbfbe49fea1e DIFF: https://github.com/llvm/llvm-project/commit/48ff068c525922e8323982795c69bbfbe49fea

[clang] [NFC] [C++] [Modules] Mark P2615 as implemented and add test (PR #147135)

2025-07-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/147135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e427bd5 - [NFC] [C++] [Modules] Mark P2615 as implemented and add test (#147135)

2025-07-07 Thread via cfe-commits
Author: Ashwin Kishin Banwari Date: 2025-07-08T10:00:55+08:00 New Revision: e427bd55a852eff2b7fed97941642be121557dca URL: https://github.com/llvm/llvm-project/commit/e427bd55a852eff2b7fed97941642be121557dca DIFF: https://github.com/llvm/llvm-project/commit/e427bd55a852eff2b7fed97941642be121557d

[clang] [NFC] [C++] [Modules] Mark P1811 as implemented and add test (PR #146993)

2025-07-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/146993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 84be785 - [NFC] [C++] [Modules] Mark P1811 as implemented and add test (#146993)

2025-07-07 Thread via cfe-commits
Author: Ashwin Kishin Banwari Date: 2025-07-08T09:54:33+08:00 New Revision: 84be78524de7d06943570854cbf31537c8f45199 URL: https://github.com/llvm/llvm-project/commit/84be78524de7d06943570854cbf31537c8f45199 DIFF: https://github.com/llvm/llvm-project/commit/84be78524de7d06943570854cbf31537c8f451

[clang] [Clang][Sema] Avoid duplicate diagnostics for incomplete types in nested name specifier (C++20+) (PR #147036)

2025-07-07 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > Why doesn't C++20 below suffer from the issue? > > I think it's a waste to add a Sema scope object just for diagnostic issues. > It's more like that there's an underlying issue that would be otherwise > hidden by the patch. Can you explore? Thank you for this PR but I agree th

[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Have you tested this with google's internal modules test? If yes, then LG. https://github.com/llvm/llvm-project/pull/147292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/147292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-07 Thread Chuanqi Xu via cfe-commits
@@ -43,17 +46,24 @@ namespace clang { // Macro locations have the top bit set, we rotate by one so it is the low bit. class SourceLocationEncoding { using UIntTy = SourceLocation::UIntTy; - constexpr static unsigned UIntBits = CHAR_BIT * sizeof(UIntTy); static UIntTy en

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -700,7 +700,8 @@ GCNTTIImpl::instCombineIntrinsic(InstCombiner &IC, IntrinsicInst &II) const { break; } case Intrinsic::amdgcn_sqrt: - case Intrinsic::amdgcn_rsq: { + case Intrinsic::amdgcn_rsq: + case Intrinsic::amdgcn_tanh: { arsenm wrote: Thi

[clang] [llvm] [AMDGPU] Add support for `v_tanh_bf16` on gfx1250 (PR #147425)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -13658,6 +13658,7 @@ bool SITargetLowering::isCanonicalized(Register Reg, const MachineFunction &MF, case Intrinsic::amdgcn_frexp_mant: case Intrinsic::amdgcn_fdot2: case Intrinsic::amdgcn_trig_preop: +case Intrinsic::amdgcn_tanh: arsenm wro

[libclc] [libclc] Declare workitem built-ins in clc, move ptx-nvidiacl workitem built-ins into clc (PR #144333)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[libclc] [libclc] Declare workitem built-ins in clc, move ptx-nvidiacl workitem built-ins into clc (PR #144333)

2025-07-07 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [RISCV] Correct type lowering of struct of fixed-vector array in VLS (PR #147173)

2025-07-07 Thread Brandon Wu via cfe-commits
@@ -441,98 +441,74 @@ bool RISCVABIInfo::detectVLSCCEligibleStruct(QualType Ty, unsigned ABIVLen, // __attribute__((vector_size(64))) int d; // } // - // Struct of 1 fixed-length vector is passed as a scalable vector. - // Struct of >1 fixed-length vectors are pa

[clang] [RISCV] Correct type lowering of struct of fixed-vector array in VLS (PR #147173)

2025-07-07 Thread Brandon Wu via cfe-commits
@@ -441,98 +441,74 @@ bool RISCVABIInfo::detectVLSCCEligibleStruct(QualType Ty, unsigned ABIVLen, // __attribute__((vector_size(64))) int d; // } // - // Struct of 1 fixed-length vector is passed as a scalable vector. - // Struct of >1 fixed-length vectors are pa

[clang] [RISCV] Correct type lowering of struct of fixed-vector array in VLS (PR #147173)

2025-07-07 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/147173 >From 1934543b7ec215312eebefd152f7c9151c2d0e54 Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Sat, 5 Jul 2025 21:32:28 -0700 Subject: [PATCH 1/2] [RISCV] Correct type lowering of struct of fixed-vector array i

[libclc] [libclc] Declare workitem built-ins in clc, move ptx-nvidiacl workitem built-ins into clc (PR #144333)

2025-07-07 Thread Wenju He via cfe-commits
wenju-he wrote: > > > Perhaps we need a stripped down OpenCL header, like > > > `clc/opencl/opencl-base.h` which includes just the types and macro defs? > > > > > > See #146840 for an example of this approach. > > thanks @frasercrmck I'll update OpenCL headers of this PR after #146840 is > l

[clang] [Clang][NFC] Avoid copies by using std::move (PR #146960)

2025-07-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/146960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6efa366 - [Clang][NFC] Avoid copies by using std::move (#146960)

2025-07-07 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-07-07T17:53:45-07:00 New Revision: 6efa366b43686bd8b1ec509e589752535507866e URL: https://github.com/llvm/llvm-project/commit/6efa366b43686bd8b1ec509e589752535507866e DIFF: https://github.com/llvm/llvm-project/commit/6efa366b43686bd8b1ec509e589752535507866e.dif

[clang] [llvm] [AMDGPU] Add alignment attr & propagate alignment through make.buffer.rsrc inst (PR #145278)

2025-07-07 Thread via cfe-commits
https://github.com/Shoreshen updated https://github.com/llvm/llvm-project/pull/145278 >From 888df5412b37bd3f232bdb38c9f89786d042fe75 Mon Sep 17 00:00:00 2001 From: shore <372660...@qq.com> Date: Mon, 23 Jun 2025 14:12:15 +0800 Subject: [PATCH 1/6] Add alignment attr & propagate alignment through

[clang] 02f60fd - [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (#146891)

2025-07-07 Thread via cfe-commits
Author: Abhinav Gaba Date: 2025-07-07T23:47:02Z New Revision: 02f60fda3cb28f14681f8a4252bc832392c91fef URL: https://github.com/llvm/llvm-project/commit/02f60fda3cb28f14681f8a4252bc832392c91fef DIFF: https://github.com/llvm/llvm-project/commit/02f60fda3cb28f14681f8a4252bc832392c91fef.diff LOG:

[clang] Sema: suppress deprecated field warnings in implicit special-member functions Fixes: https://github.com/llvm/llvm-project/issues/147293 (PR #147400)

2025-07-07 Thread Shashi Shankar via cfe-commits
https://github.com/shashi1687 edited https://github.com/llvm/llvm-project/pull/147400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (PR #146891)

2025-07-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/146891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (PR #146891)

2025-07-07 Thread Nick Sarnie via cfe-commits
sarnex wrote: 🚀 https://github.com/llvm/llvm-project/pull/146891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Sema: suppress deprecated field warnings in implicit special-member functions Fixes: https://github.com/llvm/llvm-project/issues/147293 (PR #147400)

2025-07-07 Thread Shashi Shankar via cfe-commits
https://github.com/shashi1687 ready_for_review https://github.com/llvm/llvm-project/pull/147400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Sema: suppress deprecated field warnings in implicit special-member functions Fixes: https://github.com/llvm/llvm-project/issues/147293 (PR #147400)

2025-07-07 Thread Shashi Shankar via cfe-commits
https://github.com/shashi1687 edited https://github.com/llvm/llvm-project/pull/147400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] __declspec(noshrinkwrap) support (PR #147397)

2025-07-07 Thread Adam Glass via cfe-commits
AdamGlass wrote: Change isn't Windows specific -- seems generally useful. You're right that it enshrines the functionality responsible rather than desire 'don't get cute with the prologue'. I'm open to a better name. re: __declspec() -- there is no compatibility requirement for this choice.

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Igor Kudrin via cfe-commits
@@ -453,7 +450,7 @@ void ClassifyRefs::VisitCallExpr(CallExpr *CE) { const auto *UO = dyn_cast(Ex); if (UO && UO->getOpcode() == UO_AddrOf) Ex = UO->getSubExpr(); - classify(Ex, Ignore); + classify(Ex, Use); igorkudrin wrote: > Co

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Richard Smith via cfe-commits
@@ -453,7 +450,7 @@ void ClassifyRefs::VisitCallExpr(CallExpr *CE) { const auto *UO = dyn_cast(Ex); if (UO && UO->getOpcode() == UO_AddrOf) Ex = UO->getSubExpr(); - classify(Ex, Ignore); + classify(Ex, Use); zygoloid wrote: > Your

[clang] [llvm] __declspec(noshrinkwrap) support (PR #147397)

2025-07-07 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: As a practical matter, I don't think LLVM supports shrink-wrapping on Windows at the moment. I mean, I guess it's something someone could theoretically look into at some point, but the interaction with unwind info is complicated. Can we define what it means to "shrink-wra

[clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-07 Thread Aviral Goel via cfe-commits
https://github.com/aviralg created https://github.com/llvm/llvm-project/pull/147410 Tuple structured bindings can introduce new variable declarations under `BindingDecl` nodes which are currently ignored by the infinite loop checker. This PR implements support for extracting variables from the

[clang-tools-extra] [clang-tidy] Add new check: `readability-use-concise-preprocessor-directives` (PR #146830)

2025-07-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Add support for capturing all possible versioned APINotes without applying them (PR #147405)

2025-07-07 Thread Artem Chikin via cfe-commits
https://github.com/artemcm updated https://github.com/llvm/llvm-project/pull/147405 >From 1e1b8ed2a995f4969782c257dc03713b52839573 Mon Sep 17 00:00:00 2001 From: Artem Chikin Date: Mon, 7 Jul 2025 13:56:41 -0700 Subject: [PATCH] [APINotes] Add support for capturing all possible versioned APINo

[clang-tools-extra] [clang-tidy][NFC] Do more work at compile time (PR #147406)

2025-07-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) Changes ```cpp for (std::string OptionName : { #define GET_CHECKER_OPTIONS #define CHECKER_OPTION(TYPE, CHECKER, OPTION_NAME, DESCRIPTION, DEFAULT, \ RELEASE, HIDDEN)

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Richard Smith via cfe-commits
@@ -453,7 +450,7 @@ void ClassifyRefs::VisitCallExpr(CallExpr *CE) { const auto *UO = dyn_cast(Ex); if (UO && UO->getOpcode() == UO_AddrOf) Ex = UO->getSubExpr(); - classify(Ex, Ignore); + classify(Ex, Use); zygoloid wrote: That s

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Richard Smith via cfe-commits
https://github.com/zygoloid requested changes to this pull request. https://github.com/llvm/llvm-project/pull/147221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Fix -Wuninitialized for values passed by const pointers (PR #147221)

2025-07-07 Thread Richard Smith via cfe-commits
@@ -453,7 +450,7 @@ void ClassifyRefs::VisitCallExpr(CallExpr *CE) { const auto *UO = dyn_cast(Ex); if (UO && UO->getOpcode() == UO_AddrOf) Ex = UO->getSubExpr(); - classify(Ex, Ignore); + classify(Ex, Use); zygoloid wrote: I beli

[clang] [llvm] [WebAssembly,llvm] Add llvm.wasm.ref.test.func intrinsic (PR #147076)

2025-07-07 Thread Hood Chatham via cfe-commits
https://github.com/hoodmane edited https://github.com/llvm/llvm-project/pull/147076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly,clang] Add __builtin_wasm_test_function_pointer_signature (PR #147076)

2025-07-07 Thread Hood Chatham via cfe-commits
https://github.com/hoodmane updated https://github.com/llvm/llvm-project/pull/147076 >From 2009bb945f57c67daa522448eddb2cc01aac4369 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Wed, 2 Jul 2025 20:53:56 +0200 Subject: [PATCH 1/8] Add __builtin_wasm_test_function_pointer_signature This uses

[clang] Add warning for blocks capturing {'this', raw pointers, references} (PR #144388)

2025-07-07 Thread John McCall via cfe-commits
@@ -1641,6 +1641,17 @@ def warn_implicitly_retains_self : Warning < "block implicitly retains 'self'; explicitly mention 'self' to indicate " "this is intended behavior">, InGroup>, DefaultIgnore; +def warn_blocks_capturing_this : Warning<"block implicitly captures 'this'

[clang] [CIR] Implement CXXScalarValueInitExpr for ComplexType (PR #147143)

2025-07-07 Thread Henrich Lauko via cfe-commits
@@ -165,12 +165,8 @@ mlir::Value ComplexExprEmitter::VisitChooseExpr(ChooseExpr *e) { mlir::Value ComplexExprEmitter::VisitCXXScalarValueInitExpr(CXXScalarValueInitExpr *e) { mlir::Location loc = cgf.getLoc(e->getExprLoc()); - QualType complexElemTy = - e->getType()->c

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-07 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: We shouldn't have invalid decls unless we've emitted an error. If we're making some decision like "this function is an error if it's used as a host function", we should probably be marking the FunctionDecl explicitly with that decision, and CodeGen shouldn't try to emit su

[clang] [CIR] Implement CXXScalarValueInitExpr for ComplexType (PR #147143)

2025-07-07 Thread Amr Hesham via cfe-commits
@@ -165,12 +165,8 @@ mlir::Value ComplexExprEmitter::VisitChooseExpr(ChooseExpr *e) { mlir::Value ComplexExprEmitter::VisitCXXScalarValueInitExpr(CXXScalarValueInitExpr *e) { mlir::Location loc = cgf.getLoc(e->getExprLoc()); - QualType complexElemTy = - e->getType()->c

[clang] Propose new ClangIR Maintainer (PR #147365)

2025-07-07 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. I strongly approve! https://github.com/llvm/llvm-project/pull/147365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Implement P1857R3 Modules Dependency Discovery (PR #107168)

2025-07-07 Thread Michael Spencer via cfe-commits
Bigcheese wrote: I'll try to review it this week. https://github.com/llvm/llvm-project/pull/107168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147382)

2025-07-07 Thread Lei Huang via cfe-commits
https://github.com/lei137 created https://github.com/llvm/llvm-project/pull/147382 Initial clean up in prep for adding more accumulate builtins to clang. >From 36d2b8fc61ab67b8d8010e8b33e3e871f8e1c4f2 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 4 Jul 2025 14:53:15 -0500 Subject: [PATCH

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/147122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 122afae - [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (#147122)

2025-07-07 Thread via cfe-commits
Author: Tomohiro Kashiwada Date: 2025-07-07T22:55:53+03:00 New Revision: 122afae10ed28564b64530de571ce8e4ce584b2c URL: https://github.com/llvm/llvm-project/commit/122afae10ed28564b64530de571ce8e4ce584b2c DIFF: https://github.com/llvm/llvm-project/commit/122afae10ed28564b64530de571ce8e4ce584b2c.

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-07 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/3] [Clang] disallow operator in attribute argument list

[clang] [CIR] Implement CXXScalarValueInitExpr for ComplexType (PR #147143)

2025-07-07 Thread Amr Hesham via cfe-commits
@@ -161,6 +162,17 @@ mlir::Value ComplexExprEmitter::VisitChooseExpr(ChooseExpr *e) { return Visit(e->getChosenSubExpr()); } +mlir::Value +ComplexExprEmitter::VisitCXXScalarValueInitExpr(CXXScalarValueInitExpr *e) { + mlir::Location loc = cgf.getLoc(e->getExprLoc()); + Qu

[clang] [CIR] Implement CXXScalarValueInitExpr for ComplexType (PR #147143)

2025-07-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/147143 >From d8c01a7c98bea2440ab8b704501f7e3efb33549d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 5 Jul 2025 14:27:21 +0200 Subject: [PATCH 1/2] [CIR] Implement CXXScalarValueInitExpr for ComplexType -

[clang] [libclang][Cygwin] Use LLVM_EXPORTED_SYMBOL_FILE (*.def file) for Cygwin (PR #147278)

2025-07-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Add missing dllexport annotation (PR #147108)

2025-07-07 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/147108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147382)

2025-07-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Lei Huang (lei137) Changes Initial clean up in prep for adding more accumulate builtins to clang. --- Full diff: https://github.com/llvm/llvm-project/pull/147382.diff 1 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsPPC.

[clang] 968410f - [libclang] Add missing dllexport annotation (#147108)

2025-07-07 Thread via cfe-commits
Author: Tomohiro Kashiwada Date: 2025-07-07T22:49:50+03:00 New Revision: 968410ffd1bacbf540595e0b6d2628ed559098e9 URL: https://github.com/llvm/llvm-project/commit/968410ffd1bacbf540595e0b6d2628ed559098e9 DIFF: https://github.com/llvm/llvm-project/commit/968410ffd1bacbf540595e0b6d2628ed559098e9.

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147106)

2025-07-07 Thread Lei Huang via cfe-commits
https://github.com/lei137 closed https://github.com/llvm/llvm-project/pull/147106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix crash in codegen caused by deferred asm diagnostics under -fopenmp (PR #147163)

2025-07-07 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I haven't really thought about what the right strategy is for diagnostics here, specifically, but it looks like the OpenMP diagnostic suppression isn't working correctly. If there's an error in a function, that should stop CodeGen from seeing the function at all. If it's

[clang] [clang-tools-extra] [clang]: Propagate `*noreturn` attributes in `CFG` (PR #146355)

2025-07-07 Thread Julian Schmidt via cfe-commits
@@ -141,6 +141,42 @@ void nullable_value_after_swap(BloombergLP::bdlb::NullableValue &opt1, Bloo } } +void assertion_handler_imp() __attribute__((analyzer_noreturn)); + +void assertion_handler() { +do { + assertion_handler_imp(); +} while(0); +} + +void functi

[clang] [CIR] Upstream ComplexRealPtrOp for ComplexType (PR #144235)

2025-07-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/144235 >From acab11ee6a8e8041dab689c5518229e358d4f5a1 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 7 Jul 2025 20:52:33 +0200 Subject: [PATCH] [CIR] Upstream ComplexRealPtrOp for ComplexType --- clang/i

[clang] Report wider source range for unsafe buffers warnings (PR #147363)

2025-07-07 Thread Thomas Sepez via cfe-commits
https://github.com/tsepez updated https://github.com/llvm/llvm-project/pull/147363 >From c389b056250871b802d34de6ba2cb0cf365b751a Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 7 Jul 2025 17:59:53 + Subject: [PATCH 1/2] Report wider source range for unsafe buffers warnings --- clang/

[clang] [cir-translate] Fix crash issue where the data layout string is missing (PR #147209)

2025-07-07 Thread Andy Kaylor via cfe-commits
@@ -82,12 +85,17 @@ llvm::LogicalResult prepareCIRModuleDataLayout(mlir::ModuleOp mod, // Data layout is fully determined by the target triple. Here we only pass the // triple to get the data layout. + llvm::IntrusiveRefCntPtr diagID( + new clang::DiagnosticIDs); +

[clang] [OpenACC][CIR] 'cache' construct lowering (PR #146915)

2025-07-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/10490 Here is the relev

[clang] [cir-translate] Fix crash issue where the data layout string is missing (PR #147209)

2025-07-07 Thread Andy Kaylor via cfe-commits
@@ -82,12 +85,17 @@ llvm::LogicalResult prepareCIRModuleDataLayout(mlir::ModuleOp mod, // Data layout is fully determined by the target triple. Here we only pass the // triple to get the data layout. + llvm::IntrusiveRefCntPtr diagID( + new clang::DiagnosticIDs); +

[clang] [Clang] Fixed double finally block execution (PR #146796)

2025-07-07 Thread via cfe-commits
https://github.com/yasster updated https://github.com/llvm/llvm-project/pull/146796 >From 2ccf38469c28392597199e98515dd5a21cfc7c84 Mon Sep 17 00:00:00 2001 From: Yassine Missoum Date: Tue, 1 Jul 2025 15:25:21 -0700 Subject: [PATCH 1/2] Fixed double finally block execution --- clang/lib/CodeGe

[clang] [Clang] Do not mark ambiguous specialization invalid. (PR #147275)

2025-07-07 Thread Matheus Izvekov via cfe-commits
@@ -4111,7 +4111,10 @@ static ActionResult getPatternForClassTemplateSpecialization( if (Ambiguous) { // Partial ordering did not produce a clear winner. Complain. Inst.Clear(); - ClassTemplateSpec->setInvalidDecl(); + + if (!S.isS

[clang] [clang][deps] Stop lexing if hit a failure while loading a PCH/module in a submodule. (PR #146976)

2025-07-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/146976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add __builtin_wasm_test_function_pointer_signature (PR #147076)

2025-07-07 Thread Hood Chatham via cfe-commits
https://github.com/hoodmane updated https://github.com/llvm/llvm-project/pull/147076 >From ba4e21486455fcee36e5521050562cd9be35e9b4 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Sat, 10 May 2025 22:01:09 -0400 Subject: [PATCH 1/9] [WebAssembly] Add ref.test_func handling to AsmParser ---

[clang] [Clang] include attribute scope in diagnostics (PR #144619)

2025-07-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/144619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >