================ @@ -82,12 +85,17 @@ llvm::LogicalResult prepareCIRModuleDataLayout(mlir::ModuleOp mod, // Data layout is fully determined by the target triple. Here we only pass the // triple to get the data layout. + llvm::IntrusiveRefCntPtr<clang::DiagnosticIDs> diagID( + new clang::DiagnosticIDs); + clang::DiagnosticOptions diagOpts; + clang::DiagnosticsEngine diagnostics(diagID, diagOpts, + new clang::IgnoringDiagConsumer()); llvm::Triple triple(rawTriple); clang::TargetOptions targetOptions; targetOptions.Triple = rawTriple; // FIXME: AllocateTarget is a big deal. Better make it a global state. ---------------- andykaylor wrote:
Can you update this comment to just refer to TargetOptions? It seems that we're only using the data layout string here, but there are many other things in TargetOptions that might be relevant at some point. https://github.com/llvm/llvm-project/pull/147209 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
