[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread via cfe-commits
@@ -62,6 +62,16 @@ AST_MATCHER(CXXMethodDecl, usesThis) { return false; // Stop traversal. } +bool VisitDeclRefExpr(const DeclRefExpr *E) { + if (const auto *PVD = dyn_cast_if_present(E->getDecl()); + PVD && PVD->isExplicitObjectParameter()) { +

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/141391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor requested changes to this pull request. https://github.com/llvm/llvm-project/pull/141391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: %check_clang_tidy -std=c++23 %s readability-convert-member-functions-to-static %t + +namespace std{ + class string {}; + void println(const char *format, const std::string &str) {} +} + +namespace PR141381 { +struct Hello { + std::string str_; + + vo

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Baranov Victor via cfe-commits
@@ -164,6 +165,24 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + const aut

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Baranov Victor via cfe-commits
@@ -148,6 +148,9 @@ New check aliases Changes in existing checks ^^ +- Improved :doc:`boost-use-ranges + ` check to more precisely remove comma. vbvictor wrote: In discussion, I saw that we don't need release notes for this change. Ho

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Baranov Victor via cfe-commits
@@ -164,6 +165,24 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + const aut

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor requested changes to this pull request. https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (PR #124651)

2025-05-24 Thread via cfe-commits
https://github.com/Un1q32 updated https://github.com/llvm/llvm-project/pull/124651 >From 3cf20444591e70a8a6d8782048ca4f6c0e22 Mon Sep 17 00:00:00 2001 From: Un1q32 Date: Mon, 27 Jan 2025 18:00:34 -0500 Subject: [PATCH] [Clang] Link libgcc_s.1.dylib when building for macOS 10.5 and older (i

[clang] [clang] Fix a typo in documentation (PR #141382)

2025-05-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/141382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread via cfe-commits
@@ -216,6 +219,9 @@ Changes in existing checks ` check by updating suppress warnings logic for ``nullptr`` in ``std::find``. +- Improved :doc:`modernize-use-ranges EugeneZelenko wrote: Please merge with existing entry. https://github.com/llvm/llvm-projec

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-05-24 Thread David Rivera via cfe-commits
RiverDave wrote: Ping :) https://github.com/llvm/llvm-project/pull/134188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118568 >From b43a2602025bdacea06ced5171904fb5d765de9f Mon Sep 17 00:00:00 2001 From: chomosuke Date: Tue, 3 Dec 2024 07:10:33 + Subject: [PATCH 1/5] fixed removeFunctionArgs don't remove comma --- .../clang-tid

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (flovent) Changes Fixes #141381. Add check for `DeclRefExpr` which points to an explicit object parameter. --- Full diff: https://github.com/llvm/llvm-project/pull/141391.diff 3 Files Affected: - (modified) clang-tool

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (flovent) Changes Fixes #141381. Add check for `DeclRefExpr` which points to an explicit object parameter. --- Full diff: https://github.com/llvm/llvm-project/pull/141391.diff 3 Files Affected: - (modified) clang-tools-extra

[clang-tools-extra] [clang-tidy] Fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread via cfe-commits
https://github.com/flovent edited https://github.com/llvm/llvm-project/pull/141391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix false positives with deducing this in `readability-convert-member-functions-to-static` check (PR #141391)

2025-05-24 Thread via cfe-commits
https://github.com/flovent created https://github.com/llvm/llvm-project/pull/141391 Fixes #141381. Add check for `DeclRefExpr` which points to an explicit object parameter. >From 3a7260050f8e8dc271c7fe2a5ec937026136fb6b Mon Sep 17 00:00:00 2001 From: fubowen Date: Sun, 25 May 2025 09:37:47 +0

[clang] [clang] Fix a typo in documentation (PR #141382)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141382.diff 1 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1-1) ``diff diff --git a/clang/docs/ReleaseNotes.rst b/cl

[clang] [clang] Fix a typo in documentation (PR #141382)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141382 None >From e7b60cdd28b94d358959ef9551dc90735eceabc3 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 15:03:46 -0700 Subject: [PATCH] [clang] Fix a typo in documentation --- clang/docs/

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread Cameron McInally via cfe-commits
https://github.com/mcinally created https://github.com/llvm/llvm-project/pull/141380 This patch adds support for the -mprefer-vector-width= command line option. The parsing of this options is equivalent to Clang's and it is implemented by setting the "prefer-vector-width" function attribute.

[clang] [clang-format] Handle Java text blocks (PR #141334)

2025-05-24 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/141334 >From 470eca4b4d963bf5c1ba87fb2f22620eb717c848 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 23 May 2025 23:21:12 -0700 Subject: [PATCH 1/2] [clang-format] Handle Java text blocks Fix #61954 --- clang/lib/

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-05-24 Thread Oliver Hunt via cfe-commits
@@ -2164,15 +2164,29 @@ ExprResult Sema::BuildLambdaExpr(SourceLocation StartLoc, SourceLocation EndLoc, bool IsLast = (I + 1) == LSI->NumExplicitCaptures; SourceRange FixItRange; if (CaptureRange.isValid()) { +auto GetTrailingEndLocat

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-05-24 Thread Oliver Hunt via cfe-commits
@@ -84,6 +84,21 @@ SourceLocation Sema::getLocForEndOfToken(SourceLocation Loc, unsigned Offset) { return Lexer::getLocForEndOfToken(Loc, Offset, SourceMgr, LangOpts); } +SourceRange Sema::getRangeForNextToken(SourceLocation Loc, + bool

[clang] [clang] Correct FixIt ranges for unused capture warnings (PR #141148)

2025-05-24 Thread Oliver Hunt via cfe-commits
@@ -84,6 +84,21 @@ SourceLocation Sema::getLocForEndOfToken(SourceLocation Loc, unsigned Offset) { return Lexer::getLocForEndOfToken(Loc, Offset, SourceMgr, LangOpts); } +SourceRange Sema::getRangeForNextToken(SourceLocation Loc, + bool

[clang] fb14c83 - [StaticAnalyzer] Use llvm::is_contained (NFC) (#141371)

2025-05-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-24T14:46:01-07:00 New Revision: fb14c8338a4187f87b525a58bd653c85b9b123fd URL: https://github.com/llvm/llvm-project/commit/fb14c8338a4187f87b525a58bd653c85b9b123fd DIFF: https://github.com/llvm/llvm-project/commit/fb14c8338a4187f87b525a58bd653c85b9b123fd.diff L

[clang-tools-extra] [clang] Default-construct values with DenseMap::try_emplace (NFC) (PR #141373)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4eb91b9 - [clang] Default-construct values with DenseMap::try_emplace (NFC) (#141373)

2025-05-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-24T14:47:18-07:00 New Revision: 4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6 URL: https://github.com/llvm/llvm-project/commit/4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6 DIFF: https://github.com/llvm/llvm-project/commit/4eb91b9a6a31554ac6cb9bf211527bbcbb71ccb6.diff L

[clang] [StaticAnalyzer] Use llvm::count (NFC) (PR #141370)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1cc9e6e - [StaticAnalyzer] Use llvm::count (NFC) (#141370)

2025-05-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-24T14:45:46-07:00 New Revision: 1cc9e6e5aa1f8a0e065f567a63516254afba6d81 URL: https://github.com/llvm/llvm-project/commit/1cc9e6e5aa1f8a0e065f567a63516254afba6d81 DIFF: https://github.com/llvm/llvm-project/commit/1cc9e6e5aa1f8a0e065f567a63516254afba6d81.diff L

[clang] [StaticAnalyzer] Use llvm::count (NFC) (PR #141370)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141370.diff 1 Files Affected: - (modified) clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp (+1-5) ``diff diff --git a/clang

[clang] [StaticAnalyzer] Use llvm::count (NFC) (PR #141370)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141370 None >From 0d1f3e67da90cd8aaf153736d30db05bea224b0c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 08:54:32 -0700 Subject: [PATCH] [StaticAnalyzer] Use llvm::count (NFC) --- clang/un

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/141380 >From 9f8619cb54a3a11e4c90af7f5156141ddc59e4d4 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Sat, 24 May 2025 13:35:13 -0700 Subject: [PATCH] [flang] Add support for -mprefer-vector-width= This patch a

[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141371 None >From 4b31c73fb378e6f3d3ea8b272574397c1ac8418e Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 11:48:54 -0700 Subject: [PATCH] [StaticAnalyzer] Use llvm::is_contained (NFC) --- .

[clang-tools-extra] [clang] Default-construct values with DenseMap::try_emplace (NFC) (PR #141373)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141373 try_emplace can default-construct values, so we do not need to do so on our own. >From c4590156c4dab5a70edca1056bc533a073f615e3 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 24 May 2025 11:24:36

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread Peter Klausler via cfe-commits
https://github.com/klausler commented: I'm not really qualified to review driver patches, but it looks okay as far as I can tell. https://github.com/llvm/llvm-project/pull/141380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [StaticAnalyzer] Use llvm::count (NFC) (PR #141370)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- flang/include/flang/Frontend/CodeGenOptions.h flan

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread Cameron McInally via cfe-commits
mcinally wrote: This is my first patch to Flang, so please be suspicious and gentle. In particular, I am not sure if `FlangOption, FC1Option` were the correct phases to pass this option to or not. https://github.com/llvm/llvm-project/pull/141380 ___

[clang-tools-extra] [clang] Default-construct values with DenseMap::try_emplace (NFC) (PR #141373)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Cameron McInally (mcinally) Changes This patch adds support for the -mprefer-vector-width= command line option. The parsing of this options is equivalent to Clang's and it is implemented by setting the "prefer-vector-width"

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir @llvm/pr-subscribers-clang Author: Cameron McInally (mcinally) Changes This patch adds support for the -mprefer-vector-width= command line option. The parsing of this options is equivalent to Clang's and it is implemented by setting the "pr

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Cameron McInally (mcinally) Changes This patch adds support for the -mprefer-vector-width= command line option. The parsing of this options is equivalent to Clang's and it is implemented by setting the "prefer-vector-width" fun

[clang] [flang] [mlir] [flang] Add support for -mprefer-vector-width= (PR #141380)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Cameron McInally (mcinally) Changes This patch adds support for the -mprefer-vector-width= command line option. The parsing of this options is equivalent to Clang's and it is implemented by setting the "prefer-vector-widt

[clang] [StaticAnalyzer] Use llvm::count (NFC) (PR #141370)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] Default-construct values with DenseMap::try_emplace (NFC) (PR #141373)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes try_emplace can default-construct values, so we do not need to do so on our own. --- Full diff: https://github.com/llvm/llvm-project/pull/141373.diff 1 Files Affected: - (modified) clang

[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141371.diff 1 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp

[clang] [StaticAnalyzer] Use llvm::is_contained (NFC) (PR #141371)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141371.diff 1 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp (+2-4) ``

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/141369 This change adds support for zero and global init for ComplexType #141365 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 S

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds support for zero and global init for ComplexType #141365 --- Full diff: https://github.com/llvm/llvm-project/pull/141369.diff 11 Files Affected: - (modified) clang/include/clang/CIR/

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: - This PR has implementation for the global init Complex value. I will backport it to the incubator once it is merged. - Not totally sure if it's good idea or not to rename it to `ConstComplexAttr` similar to Const Array, Vector and Record, We can discuss it 👍🏻 https://gi

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for zero and global init for ComplexType #141365 --- Full diff: https://github.com/llvm/llvm-project/pull/141369.diff 11 Files Affected: - (modified) clang/include/clang/CIR/Di

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-24 Thread Baranov Victor via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/140086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Richard Li via cfe-commits
chomosuke wrote: Ping https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-05-24 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118568 >From b43a2602025bdacea06ced5171904fb5d765de9f Mon Sep 17 00:00:00 2001 From: chomosuke Date: Tue, 3 Dec 2024 07:10:33 + Subject: [PATCH 1/5] fixed removeFunctionArgs don't remove comma --- .../clang-tid

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-24 Thread Nikita Popov via cfe-commits
@@ -0,0 +1,287 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-format] Handle Java text blocks (PR #141334)

2025-05-24 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/141334 >From 470eca4b4d963bf5c1ba87fb2f22620eb717c848 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 23 May 2025 23:21:12 -0700 Subject: [PATCH 1/2] [clang-format] Handle Java text blocks Fix #61954 --- clang/lib/

[clang-tools-extra] [clang-tidy] readability-redundant-smartptr-get: disable for smart pointers to arrays (PR #141092)

2025-05-24 Thread Baranov Victor via cfe-commits
@@ -44,7 +44,10 @@ internal::Matcher callToGet(const internal::Matcher &OnClass) { } internal::Matcher knownSmartptr() { - return recordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr")); + return recordDecl( + hasAnyName("::std::unique_ptr", "::std::shared_ptr

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-05-24 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: This is an improvement, but should we also strip the bitcode? Otherwise people will still get errors if they try to use the archives if their host clang version is older. https://github.com/llvm/llvm-project/pull/140381 __

[clang-tools-extra] [clang-tidy] Added check 'bugprone-function-visibility-change' (PR #140086)

2025-05-24 Thread Baranov Victor via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/140086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] 4675f22 - [clang-tidy] detect arithmetic operations within member list initialization in modernize-use-default-member-init check (#129370)

2025-05-24 Thread via cfe-commits
Author: David Rivera Date: 2025-05-24T20:15:36+03:00 New Revision: 4675f2287cc6a530102759ba548558f525ed0423 URL: https://github.com/llvm/llvm-project/commit/4675f2287cc6a530102759ba548558f525ed0423 DIFF: https://github.com/llvm/llvm-project/commit/4675f2287cc6a530102759ba548558f525ed0423.diff

[clang-tools-extra] [clang-tidy] detect arithmetic operations within member list initialization in modernize-use-default-member-init check (PR #129370)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/129370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fb99a85 - [clang-tidy][NFC] Refactor `modernize-use-trailing-return-type-check` check code and tests (#140759)

2025-05-24 Thread via cfe-commits
Author: Baranov Victor Date: 2025-05-24T19:55:51+03:00 New Revision: fb99a850b6cee22b1406fa7408435be38d47ea11 URL: https://github.com/llvm/llvm-project/commit/fb99a850b6cee22b1406fa7408435be38d47ea11 DIFF: https://github.com/llvm/llvm-project/commit/fb99a850b6cee22b1406fa7408435be38d47ea11.diff

[clang-tools-extra] [clang-tidy] Fix false positives in `bugprone-crtp-constructor-accessibility` check (PR #132543)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/132543 >From a23fa792a3929882cd7b496e9027cbed6a3e7dc2 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 22 Mar 2025 14:39:43 +0300 Subject: [PATCH 1/2] [clang-tidy] Fix false positives in crtp-constructor-acce

[clang-tools-extra] [clang-tidy][NFC] Refactor `modernize-use-trailing-return-type-check` check code and tests (PR #140759)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/140759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 24c782e - [clang] Use llvm::partition_point (NFC) (#141351)

2025-05-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-24T09:37:26-07:00 New Revision: 24c782e0030c145bc0deebc56b72a1729b9cdd64 URL: https://github.com/llvm/llvm-project/commit/24c782e0030c145bc0deebc56b72a1729b9cdd64 DIFF: https://github.com/llvm/llvm-project/commit/24c782e0030c145bc0deebc56b72a1729b9cdd64.diff L

[clang] [clang][ASTMatchers][NFC] fix typos in AST-matchers docs. (PR #141307)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/141307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle Java text blocks (PR #141334)

2025-05-24 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/141334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ac2b5c - [Serialization] Remove an unused local variable (NFC) (#141358)

2025-05-24 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-24T09:37:46-07:00 New Revision: 3ac2b5c55bdf3dcecf5dca731f5cdd6996c3b63d URL: https://github.com/llvm/llvm-project/commit/3ac2b5c55bdf3dcecf5dca731f5cdd6996c3b63d DIFF: https://github.com/llvm/llvm-project/commit/3ac2b5c55bdf3dcecf5dca731f5cdd6996c3b63d.diff L

[clang] [Serialization] Remove an unused local variable (NFC) (PR #141358)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::partition_point (NFC) (PR #141351)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-24 Thread via cfe-commits
https://github.com/flovent updated https://github.com/llvm/llvm-project/pull/141345 >From 5842c573aa94063ea842230f19d5807a77b130e6 Mon Sep 17 00:00:00 2001 From: fubowen Date: Sat, 24 May 2025 21:29:53 +0800 Subject: [PATCH 1/2] [clang-tidy] Add check for assignment or comparision operators' o

[clang] [clang][Sema] Diagnose exceptions only in non-dependent context in discarded `try/catch/throw` blocks (PR #139859)

2025-05-24 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/139859 >From 136f1c030db440054a2052a69c5c4dd27f50823e Mon Sep 17 00:00:00 2001 From: Rajveer Date: Wed, 14 May 2025 13:44:31 +0530 Subject: [PATCH] [clang][Sema] Diagnose exceptions only in non-dependent context in

[clang] [clang-format] Add ApplyAlwaysOnePerLineToTemplateArguments option (PR #137544)

2025-05-24 Thread Lorenzo Mauro via cfe-commits
LorenzoMauro wrote: @rmarker as of now the option```ApplyAlwaysOnePerLineToTemplateArguments``` makes any changes in the formatting only when ```BinPackParameters: AlwaysOnePerLine``` and it makes it behave as if ```BinPackParameters``` was set to ```OnePerLine``` for templates, so it puts eac

[clang] [clang-format] Add ApplyAlwaysOnePerLineToTemplateArguments option (PR #137544)

2025-05-24 Thread Lorenzo Mauro via cfe-commits
@@ -1521,6 +1523,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { LLVMStyle.BinPackArguments = true; LLVMStyle.BinPackLongBracedList = true; LLVMStyle.BinPackParameters = FormatStyle::BPPS_BinPack; + LLVMStyle.ApplyAlwaysOnePerLineToTemplateArguments

[clang] [Serialization] Remove an unused local variable (NFC) (PR #141358)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::partition_point (NFC) (PR #141351)

2025-05-24 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/141351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __builtin_common_reference (PR #121199)

2025-05-24 Thread via cfe-commits
@@ -3231,6 +3241,230 @@ static QualType builtinCommonTypeImpl(Sema &S, TemplateName BaseTemplate, } } +static QualType CopyCV(QualType From, QualType To) { + if (From.isConstQualified()) +To.addConst(); + if (From.isVolatileQualified()) +To.addVolatile(); + retur

[clang] [Serialization] Remove an unused local variable (NFC) (PR #141358)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes Note that getTimestampFilename just constructs a file name, so it's mostly a "pure" function except possible heap allocation. --- Full diff: https://github.com/llvm/llvm-project/pull/141358.dif

[clang] [Serialization] Remove an unused local variable (NFC) (PR #141358)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that getTimestampFilename just constructs a file name, so it's mostly a "pure" function except possible heap allocation. --- Full diff: https://github.com/llvm/llvm-project/pull/141358.diff 1 Fi

[clang] [Serialization] Remove an unused local variable (NFC) (PR #141358)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141358 Note that getTimestampFilename just constructs a file name, so it's mostly a "pure" function except possible heap allocation. >From c30f6c7c2ebe80ad84f36fd9e4172f5323779a97 Mon Sep 17 00:00:00 2001 From:

[clang] [clang] Use llvm::partition_point (NFC) (PR #141351)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141351.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaType.cpp (+2-2) - (modified) clang/lib/StaticAnalyzer/Core/P

[clang] [clang] Use llvm::partition_point (NFC) (PR #141351)

2025-05-24 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/141351 None >From 1d24b61eff5dc9fb25a4769166374657041808a5 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 23 May 2025 22:53:30 -0700 Subject: [PATCH] [clang] Use llvm::partition_point (NFC) --- clang/l

[clang] [clang][AST][NFC] fix spelling typos in clang AST files (PR #141346)

2025-05-24 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/141346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers][NFC] fix typos in AST-matchers docs. (PR #141307)

2025-05-24 Thread Baranov Victor via cfe-commits
vbvictor wrote: P.S. Found these typos using [CSpell](https://cspell.org/) utility. https://github.com/llvm/llvm-project/pull/141307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-24 Thread via cfe-commits
@@ -176,6 +176,11 @@ Changes in existing checks ` check by fixing a false positive where ``strerror`` was flagged as MT-unsafe. +- Improved :doc:`readability-math-missing-parentheses EugeneZelenko wrote: Please keep alphabetical order (by check name) in t

[clang] [clang][AST][NFC] fix spelling typos in clang AST files (PR #141346)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Baranov Victor (vbvictor) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141346.diff 7 Files Affected: - (modified) clang/include/clang/AST/ASTContext.h (+5-5) - (modified) clang/include/clang/AST/ASTImporter

[clang] 3f3b19d - [clang][NFC] Clean up SemaChecking.cpp (#141041)

2025-05-24 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-24T16:17:37+02:00 New Revision: 3f3b19d2b788e976281be1d8441d167540d1e197 URL: https://github.com/llvm/llvm-project/commit/3f3b19d2b788e976281be1d8441d167540d1e197 DIFF: https://github.com/llvm/llvm-project/commit/3f3b19d2b788e976281be1d8441d167540d1e197.diff L

[clang] [clang][NFC] Clean up SemaChecking.cpp (PR #141041)

2025-05-24 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/141041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers][NFC] fix typos in AST-matchers docs. (PR #141307)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/141307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST][NFC] fix spelling typos in clang AST files (PR #141346)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Baranov Victor (vbvictor) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141346.diff 7 Files Affected: - (modified) clang/include/clang/AST/ASTContext.h (+5-5) - (modified) clang/include/clang/AST/ASTImporterLookupTa

[clang] [clang][AST][NFC] fix spelling typos in clang AST files (PR #141346)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/141346 None >From d10598db7d58f0c06673c81b675924bb497792be Mon Sep 17 00:00:00 2001 From: Baranov Victor Date: Sat, 24 May 2025 17:12:21 +0300 Subject: [PATCH] [clang][AST][NFC] fix spelling typos in clang AST files

[clang] [ASTMatchers][NFC] fix typos in AST-matchers docs. (PR #141307)

2025-05-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/141307 >From 4ee68d62a21f75110b9406c86c9c059b1c2a840d Mon Sep 17 00:00:00 2001 From: Baranov Victor Date: Sat, 24 May 2025 03:17:57 +0300 Subject: [PATCH 1/2] [ASTMatchers][NFC] fix typos in AST-matchers docs. --- c

[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)

2025-05-24 Thread via cfe-commits
@@ -297,7 +301,8 @@ TEST(IncludeCleaner, GenerateMissingHeaderDiags) { Findings.UnusedIncludes.clear(); std::vector Diags = issueIncludeCleanerDiagnostics( AST, TU.Code, Findings, MockFS(), - {[](llvm::StringRef Header) { return Header.ends_with("buzz.h"); }}); +

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (flovent) Changes Fixes false negative in #141249. Add check for math binary operators which are operands of assignment or comparision operators. --- Full diff: https://github.com/llvm/llvm-project/pull/141345.diff 3

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (flovent) Changes Fixes false negative in #141249. Add check for math binary operators which are operands of assignment or comparision operators. --- Full diff: https://github.com/llvm/llvm-project/pull/141345.diff 3 Files

[clang-tools-extra] [clang-tidy] Add check for assignment or comparision operators' operand in `readability-math-missing-parentheses` (PR #141345)

2025-05-24 Thread via cfe-commits
https://github.com/flovent created https://github.com/llvm/llvm-project/pull/141345 Fixes false negative in #141249. Add check for math binary operators which are operands of assignment or comparision operators. >From 5842c573aa94063ea842230f19d5807a77b130e6 Mon Sep 17 00:00:00 2001 From: f

[clang] Include [[clang::require_explicit_initialization]] warnings in system headers (PR #141133)

2025-05-24 Thread via cfe-commits
higher-performance wrote: @cor3ntin feel free to chat, but in this case we do actually want to warn (and error, under -Werror) if _anybody_ (mis)uses `std::construct_at` (i.e. neglects to explicitly initialize a field that declares itself as such). It's the exact analog of using std::invoke to

  1   2   >