llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> try_emplace can default-construct values, so we do not need to do so on our own. --- Full diff: https://github.com/llvm/llvm-project/pull/141373.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/index/SymbolCollector.cpp (+2-2) ``````````diff diff --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp b/clang-tools-extra/clangd/index/SymbolCollector.cpp index 3f5633357073d..6bdb1080fb294 100644 --- a/clang-tools-extra/clangd/index/SymbolCollector.cpp +++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp @@ -1201,7 +1201,7 @@ void SymbolCollector::addRef(SymbolID ID, const SymbolRef &SR) { } SymbolID SymbolCollector::getSymbolIDCached(const Decl *D) { - auto It = DeclToIDCache.try_emplace(D, SymbolID{}); + auto It = DeclToIDCache.try_emplace(D); if (It.second) It.first->second = getSymbolID(D); return It.first->second; @@ -1210,7 +1210,7 @@ SymbolID SymbolCollector::getSymbolIDCached(const Decl *D) { SymbolID SymbolCollector::getSymbolIDCached(const llvm::StringRef MacroName, const MacroInfo *MI, const SourceManager &SM) { - auto It = MacroToIDCache.try_emplace(MI, SymbolID{}); + auto It = MacroToIDCache.try_emplace(MI); if (It.second) It.first->second = getSymbolID(MacroName, MI, SM); return It.first->second; `````````` </details> https://github.com/llvm/llvm-project/pull/141373 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
