https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/141373
try_emplace can default-construct values, so we do not need to do so
on our own.
>From c4590156c4dab5a70edca1056bc533a073f615e3 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Sat, 24 May 2025 11:24:36 -0700
Subject: [PATCH] [clang] Default-construct values with DenseMap::try_emplace
(NFC)
try_emplace can default-construct values, so we do not need to do so
on our own.
---
clang-tools-extra/clangd/index/SymbolCollector.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp
b/clang-tools-extra/clangd/index/SymbolCollector.cpp
index 3f5633357073d..6bdb1080fb294 100644
--- a/clang-tools-extra/clangd/index/SymbolCollector.cpp
+++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp
@@ -1201,7 +1201,7 @@ void SymbolCollector::addRef(SymbolID ID, const SymbolRef
&SR) {
}
SymbolID SymbolCollector::getSymbolIDCached(const Decl *D) {
- auto It = DeclToIDCache.try_emplace(D, SymbolID{});
+ auto It = DeclToIDCache.try_emplace(D);
if (It.second)
It.first->second = getSymbolID(D);
return It.first->second;
@@ -1210,7 +1210,7 @@ SymbolID SymbolCollector::getSymbolIDCached(const Decl
*D) {
SymbolID SymbolCollector::getSymbolIDCached(const llvm::StringRef MacroName,
const MacroInfo *MI,
const SourceManager &SM) {
- auto It = MacroToIDCache.try_emplace(MI, SymbolID{});
+ auto It = MacroToIDCache.try_emplace(MI);
if (It.second)
It.first->second = getSymbolID(MacroName, MI, SM);
return It.first->second;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
