[clang] [clang][TableGen] Change MVE Emitter to use const RecordKeeper (PR #108500)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108500 >From d27e44464aed725ae22d918644d6c3eaa5559876 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 19:50:11 -0700 Subject: [PATCH] [clang][TableGen] Change MVE Emitter to use const RecordKeeper -

[clang] [clang][TableGen] Change MVE Emitter to use const RecordKeeper (PR #108500)

2024-09-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3c9db3a627811f656cc569fe3b8bdb54ba8192bc 9cfc9872bc14c2a887128f83f3f9b38e70ea3258 --e

[clang] [clang][TableGen] Change SVE Emitter to use const RecordKeeper (PR #108503)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108503 [clang][TableGen] Change SVE Emitter to use const RecordKeeper. >From 11449fe4a67f1c60d47b9ed8bcae5520fdc8b565 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 19:55:10 -0700 Subject: [PATCH] [

[clang] [clang][TableGen] Change RISCVVEmitter to use const RecordKeeper (PR #108502)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108502 [clang][TableGen] Change RISCVVEmitter to use const RecordKeeper. >From e2974b932d37a2e992cefbeb658268eddd92af0a Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 19:58:44 -0700 Subject: [PATCH]

[clang] [clang][TableGen] Change NeonEmitter to use const RecordKeeper (PR #108501)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108501 [clang][TableGen] Change NeonEmitter to use const RecordKeeper. >From 0ef4d6b31bfe72904706362635d328ba8629ed8b Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 19:46:23 -0700 Subject: [PATCH] [

[clang] [clang][TableGen] Change MVE Emitter to use const RecordKeeper (PR #108500)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108500 [clang][TableGen] Change MVE Emitter to use const RecordKeeper >From 9cfc9872bc14c2a887128f83f3f9b38e70ea3258 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 19:50:11 -0700 Subject: [PATCH] [c

[clang] [clang][bytecode] Implement HLSLVectorTruncation casts (PR #108499)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108499.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+25) - (modified) clang/test/AST/ByteCode/hlsl.hlsl (+14-2) ```

[clang] [clang][bytecode] Implement HLSLVectorTruncation casts (PR #108499)

2024-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/108499 None >From 058053a85bb2fe41b2bb98c2e460df1f74058f63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 13 Sep 2024 06:21:25 +0200 Subject: [PATCH] [clang][bytecode] Implement HLSLVectorTru

[clang] [Clang][TableGen] Support specifying address space in clang builtin prototypes (PR #108497)

2024-09-12 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH created https://github.com/llvm/llvm-project/pull/108497 this is a follow up from the discussion in https://github.com/llvm/llvm-project/pull/86801 (apologies for the long delay...). This PR proposes a way to specify address spaces in builtin prototypes. The idea

[clang] [C++20] [Modules] Warn for importing implementation partition unit in interface units (PR #108493)

2024-09-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/108493 >From b109ea29ee6d1c290766e141ce75317fbf450767 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 13 Sep 2024 13:18:43 +0800 Subject: [PATCH] [C++20] [Modules] Warn for importing implementation partition u

[clang] [C++20] [Modules] Warn for importing implementation partition unit in interface units (PR #108493)

2024-09-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dee058f9e3ae95b8f4b95034b65c3d7408060c8e 2ce2ed721f1ee985aa6163331bcb1f2f666a3b62 --e

[clang] [C++20] [Modules] Warn for importing implementation partition unit in interface units (PR #108493)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Recently, there are multiple false positive issue reports about the reachability of implementation partition units: - https://github.com/llvm/llvm-project/issues/105882 - https://github.com/llvm/llvm

[clang] [C++20] [Modules] Warn for importing implementation partition unit in interface units (PR #108493)

2024-09-12 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/108493 Recently, there are multiple false positive issue reports about the reachability of implementation partition units: - https://github.com/llvm/llvm-project/issues/105882 - https://github.com/llvm/llvm-project/

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #94981)

2024-09-12 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @alexfh Thanks, fixed in https://github.com/llvm/llvm-project/pull/108491 https://github.com/llvm/llvm-project/pull/94981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang] Implement transforms for DeducedTemplateName (PR #108491)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes Fixes regression introduced in #94981, reported on the pull-request. Since this fixes a commit which was never released, there are no release notes. --- Full diff: https://github.com/llvm/llvm-project/pu

[clang] [clang] Implement transforms for DeducedTemplateName (PR #108491)

2024-09-12 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/108491 Fixes regression introduced in #94981, reported on the pull-request. Since this fixes a commit which was never released, there are no release notes. >From 2d79745e93cdda66cec9781efa7e10bce5544e8f Mon Sep 17 00

[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)

2024-09-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks for putting together this patch! Two high-level pieces of feedback: 1. The current patch implements the options as additional values of the `--function-arg-placeholders` command-line flag. However, the proposal in

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-12 Thread Luke Lau via cfe-commits
lukel97 wrote: > > I tried out #94981 and -fno-relaxed-template-template-args and can confirm > > both fix it. I'm now running into a separate LoopVectorizer crash, but I > > made it out of the frontend :) > > Using -fno-relaxed-template-template-args should be fine, in > > llvm-test-suite we

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-12 Thread Mikael Holmén via cfe-commits
@@ -0,0 +1,52 @@ +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=i386-unknown-unknown -target-feature +avx10.2-512 -emit-llvm -Wall -Werror -verify mikaelholmen wrote: Can we remove "-emit-llvm" from this test (and others in this pat

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread via cfe-commits
github-actions[bot] wrote: @MainakSil Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Worked. Thanks! https://github.com/llvm/llvm-project/pull/108324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/108324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] d04c2ed - [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (#108324)

2024-09-12 Thread via cfe-commits
Author: Mainak Sil Date: 2024-09-13T00:35:24-04:00 New Revision: d04c2ed60c6a1acef75b0cfff6f1bf9a5a7bea89 URL: https://github.com/llvm/llvm-project/commit/d04c2ed60c6a1acef75b0cfff6f1bf9a5a7bea89 DIFF: https://github.com/llvm/llvm-project/commit/d04c2ed60c6a1acef75b0cfff6f1bf9a5a7bea89.diff LO

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
MainakSil wrote: Unchecked the private email box. https://github.com/llvm/llvm-project/pull/108324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: ![image](https://github.com/user-attachments/assets/a40849e3-435c-4812-8aa0-3fa9ba5b6c5d) Looks like you have the "private email" setting enabled on GitHub, [I believe LLVM policy is to discourage it](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-a

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread via cfe-commits
@@ -5,122 +5,428 @@ #include #include -// CHECK-LABEL: @test_alu_slet -// CHECK: @llvm.riscv.cv.alu.slet +// CHECK-LABEL: @test_alu_slet( +// CHECK-NEXT: entry: +// CHECK-NEXT:[[A_ADDR_I:%.*]] = alloca i32, align 4 +// CHECK-NEXT:[[B_ADDR_I:%.*]] = alloca i32, align

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes The generate-profraw-external target needs to be built after clang, but this was not modeled correctly in the CMake dependencies. The new dependency ordering ensures that clang is built before generate-pro

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/108488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/108488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/108488 The generate-profraw-external target needs to be built after clang, but this was not modeled correctly in the CMake dependencies. The new dependency ordering ensures that clang is built before generate-prof

[clang] [HLSL] Add `[[hlsl::contained_type()]]` attribute (PR #108456)

2024-09-12 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/108456 >From 9906af110af550643d816b1ed729c19e16027288 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 10 Sep 2024 14:38:19 -0700 Subject: [PATCH 1/5] [HLSL] Add `[[hlsl::contained_type()]]` resource type attribu

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
MainakSil wrote: If it looks good to you, please do merge it. https://github.com/llvm/llvm-project/pull/108324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change SyntaxEmitter to use const RecordKeeper (PR #108478)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change SyntaxEmitter to use const RecordKeeper. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefin

[clang] [clang][TableGen] Change SyntaxEmitter to use const RecordKeeper (PR #108478)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change SACheckersEmitter to use const RecordKeeper (PR #108477)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change SACheckersEmitter to use const RecordKeeper. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderivedde

[clang] [clang][TableGen] Change TypeNodesEmitter to use const RecordKeeper (PR #108476)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change TypeNodesEmitter to use const RecordKeeper. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddef

[clang] [clang][TableGen] Change SACheckersEmitter to use const RecordKeeper (PR #108477)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change TypeNodesEmitter to use const RecordKeeper (PR #108476)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/108324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
@@ -19,20 +19,23 @@ Example: .. code-block:: c++ struct Base { -virtual void ~Base(); +virtual ~Base(); +int i; }; - nicovank wrote: LGTM! Sorry for confusion. Do you need me to click the merge button? https://github.com/llvm/llvm-project/pu

[clang] [HLSL] Add `[[hlsl::contained_type()]]` attribute (PR #108456)

2024-09-12 Thread Helena Kotas via cfe-commits
@@ -563,18 +566,23 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } -bool clang::CreateHLSLAttributedResourceType(Sema &S, QualType Wrapped, - ArrayRef AttrList, -

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread Jessica Clarke via cfe-commits
@@ -0,0 +1,41 @@ +//==- BuiltinsRISCVXCV.td - RISC-V CORE-V Builtin database*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread via cfe-commits
@@ -0,0 +1,41 @@ +//==- BuiltinsRISCVXCV.td - RISC-V CORE-V Builtin database*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-09-12 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 1b598a5f3b158ec231b96281e4e0edc6fa819389 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
@@ -19,20 +19,23 @@ Example: .. code-block:: c++ struct Base { -virtual void ~Base(); +virtual ~Base(); +int i; }; - MainakSil wrote: Check it please. https://github.com/llvm/llvm-project/pull/108324 _

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH 1/4] Improve documentation for bugprone-pointer-arithmetic-on-pol

[clang] [HLSL] Add `[[hlsl::contained_type()]]` attribute (PR #108456)

2024-09-12 Thread Helena Kotas via cfe-commits
@@ -114,19 +115,30 @@ struct BuiltinTypeDeclBuilder { AccessSpecifier Access = AccessSpecifier::AS_private) { if (Record->isCompleteDefinition()) return *this; + +TypeSourceInfo *ElementTypeTSI = nullptr; + QualType Ty = Record->getASTContex

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-09-12 Thread Brian Cain via cfe-commits
androm3da wrote: @ldionne I think you'll be satisfied with the changes I've made. Previously I didn't think your feedback made sense, but I've come around 😉 https://github.com/llvm/llvm-project/pull/98712 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Nicolas van Kempen via cfe-commits
@@ -19,20 +19,23 @@ Example: .. code-block:: c++ struct Base { -virtual void ~Base(); +virtual ~Base(); +int i; }; - nicovank wrote: Yes, I like the blank lines between functions/structs like in your screenshot above. Current PR version has

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread Craig Topper via cfe-commits
@@ -0,0 +1,41 @@ +//==- BuiltinsRISCVXCV.td - RISC-V CORE-V Builtin database*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-12 Thread Fangrui Song via cfe-commits
@@ -64,14 +64,16 @@ static lto::Config createConfig() { c.Options.BBAddrMap = config->ltoBBAddrMap; // Check if basic block sections must be used. - // Allowed values for --lto-basic-block-sections are "all", "labels", + // Allowed values for --lto-basic-block-sections a

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-12 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/107494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-12 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. (Thanks for the patch. I am on vacation and may be slow/inconvenient to respond.) https://github.com/llvm/llvm-project/pull/107494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-12 Thread Fangrui Song via cfe-commits
@@ -2369,14 +2369,16 @@ are listed below. $ cd $P/bar && clang -c -funique-internal-linkage-names name_conflict.c $ cd $P && clang foo/name_conflict.o && bar/name_conflict.o -.. option:: -fbasic-block-sections=[labels, all, list=, none] +.. option:: -f[no]-basic-bloc

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
@@ -19,20 +19,23 @@ Example: .. code-block:: c++ struct Base { -virtual void ~Base(); +virtual ~Base(); +int i; }; - MainakSil wrote: So should I make any changes? https://github.com/llvm/llvm-project/pull/108324

[clang] [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (PR #108131)

2024-09-12 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/108131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dee058f - [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (#108131)

2024-09-12 Thread via cfe-commits
Author: Jim Lin Date: 2024-09-13T10:37:48+08:00 New Revision: dee058f9e3ae95b8f4b95034b65c3d7408060c8e URL: https://github.com/llvm/llvm-project/commit/dee058f9e3ae95b8f4b95034b65c3d7408060c8e DIFF: https://github.com/llvm/llvm-project/commit/dee058f9e3ae95b8f4b95034b65c3d7408060c8e.diff LOG:

[clang] Add code completion for C++20 keywords. (PR #107982)

2024-09-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: What about `module`, `import` and `export`? https://github.com/llvm/llvm-project/pull/107982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix assertion in `tryDiagnoseOverloadedCast` (PR #108021)

2024-09-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the fix. Is this from a bug report, if so it should be mentioned in the summary. The summary itself could be a big clearer, maybe a small code example could help. I think this also needs a release note. https://github.com/llvm/llvm-project/p

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Kyungwoo Lee via cfe-commits
@@ -2753,6 +2753,33 @@ void tools::addMachineOutlinerArgs(const Driver &D, addArg(Twine("-enable-machine-outliner=never")); } } + + auto *CodeGenDataGenArg = + Args.getLastArg(options::OPT_fcodegen_data_generate, kyulee-com wrote: Thanks for

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Kyungwoo Lee via cfe-commits
@@ -1894,6 +1894,18 @@ def fprofile_selected_function_group : Visibility<[ClangOption, CC1Option]>, MetaVarName<"">, HelpText<"Partition functions into N groups using -fprofile-function-groups and select only functions in group i to be instrumented. The valid range is 0 to

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Kyungwoo Lee via cfe-commits
kyulee-com wrote: > Can we add some documentation to > https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst? > This could also be a separate PR. > > LGTM, but I want to give others a chance to review. Added some documentation, and simplify the flag use by removing the dir

[clang] [clang][Sema] Fix assertion in `tryDiagnoseOverloadedCast` (PR #108021)

2024-09-12 Thread Shafik Yaghmour via cfe-commits
@@ -446,7 +446,12 @@ static bool tryDiagnoseOverloadedCast(Sema &S, CastType CT, : InitializationKind::CreateCast(/*type range?*/ range); InitializationSequence sequence(S, entity, initKind, src); - assert(sequence.Failed() && "initialization succeeded on second try?");

[clang] [clang][Sema] Fix assertion in `tryDiagnoseOverloadedCast` (PR #108021)

2024-09-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/108021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change SyntaxEmitter to use const RecordKeeper (PR #108478)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change SyntaxEmitter to use const RecordKeeper (PR #108478)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108478 Change SyntaxEmitter to use const RecordKeeper. >From d6c867550f90d27db4324e555b303715ee118319 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 18:51:44 -0700 Subject: [PATCH] [clang][TableGe

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread Craig Topper via cfe-commits
@@ -22150,18 +22150,13 @@ Value *CodeGenFunction::EmitRISCVBuiltinExpr(unsigned BuiltinID, case RISCV::BI__builtin_riscv_cv_alu_extbz: ID = Intrinsic::riscv_cv_alu_extbz; break; - case RISCV::BI__builtin_riscv_cv_alu_exths: -ID = Intrinsic::riscv_cv_alu_exths; -

[clang] [clang][TableGen] Change SACheckersEmitter to use const RecordKeeper (PR #108477)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change SACheckersEmitter to use const RecordKeeper (PR #108477)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108477 Change SACheckersEmitter to use const RecordKeeper. >From fd8c24e54a55144d0b8c64a203648e427e0504f9 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 18:46:56 -0700 Subject: [PATCH] [clang][Tabl

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread Craig Topper via cfe-commits
@@ -5,122 +5,428 @@ #include #include -// CHECK-LABEL: @test_alu_slet -// CHECK: @llvm.riscv.cv.alu.slet +// CHECK-LABEL: @test_alu_slet( +// CHECK-NEXT: entry: +// CHECK-NEXT:[[A_ADDR_I:%.*]] = alloca i32, align 4 +// CHECK-NEXT:[[B_ADDR_I:%.*]] = alloca i32, align

[clang] [clang][TableGen] Change TypeNodesEmitter to use const RecordKeeper (PR #108476)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change TypeNodesEmitter to use const RecordKeeper (PR #108476)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/108476 Change TypeNodesEmitter to use const RecordKeeper. >From 8ac46e76011d91b23bfe2b7fe6aa4f14391ff8e6 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 12 Sep 2024 18:42:31 -0700 Subject: [PATCH] [clang][TableG

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-12 Thread via cfe-commits
https://github.com/realqhc updated https://github.com/llvm/llvm-project/pull/100684 >From d2169cacc2851db4d57865e26781b93d814ebe80 Mon Sep 17 00:00:00 2001 From: Qihan Cai Date: Fri, 26 Jul 2024 12:26:16 +1000 Subject: [PATCH 1/5] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E4

[clang] 3c9db3a - [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (#108274)

2024-09-12 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-12T18:37:41-07:00 New Revision: 3c9db3a627811f656cc569fe3b8bdb54ba8192bc URL: https://github.com/llvm/llvm-project/commit/3c9db3a627811f656cc569fe3b8bdb54ba8192bc DIFF: https://github.com/llvm/llvm-project/commit/3c9db3a627811f656cc569fe3b8bdb54ba8192bc.diff L

[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-12 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Meanwhile, I thought of a fix for https://github.com/llvm/llvm-project/issues/108145 and submitted it as https://github.com/llvm/llvm-project/pull/108475. If that's accepted, you should be able to drop the `ASTContext.cpp` changes from this patch. https://github.com/llv

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes The intent of the `CommentlessRedeclChains` cache is that if new redecls have been parsed since the last time getRawCommentsForAnyRedecl() was called, only the new redecls are checked for comments. H

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/108475 The intent of the `CommentlessRedeclChains` cache is that if new redecls have been parsed since the last time getRawCommentsForAnyRedecl() was called, only the new redecls are checked for comments. Howe

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-12 Thread Nathan Ridge via cfe-commits
@@ -635,17 +635,20 @@ bool SymbolCollector::handleDeclOccurrence( return true; const Symbol *BasicSymbol = Symbols.find(ID); - if (isPreferredDeclaration(*OriginalDecl, Roles)) + bool SkipDocCheckInDef = false; + if (isPreferredDeclaration(*OriginalDecl, Roles)) {

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks, the test cases look good. https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-12 Thread Damyan Pepper via cfe-commits
@@ -1,5 +1,24 @@ // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify +// valid +cbuffer cbuf { +RWBuffer r : register(u0, space0); +} + +cbuffer cbuf2 { +struct x { +// expected-error@+1 {{'register' attribute only ap

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-12 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. LGTM - I think one of the test cases may be redundant (or in the wrong file). https://github.com/llvm/llvm-project/pull/106782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-12 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/106782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Syntacore SCR7 processor definition (PR #108406)

2024-09-12 Thread Yingwei Zheng via cfe-commits
@@ -502,3 +502,28 @@ // RUN: %clang --target=riscv64 -### -c %s 2>&1 -mtune=syntacore-scr5-rv64 | FileCheck -check-prefix=MTUNE-SYNTACORE-SCR5-RV64 %s // MTUNE-SYNTACORE-SCR5-RV64: "-tune-cpu" "syntacore-scr5-rv64" + +// RUN: %clang --target=riscv64 -### -c %s 2>&1 -mcpu=synt

[clang] [Clang] Propagate elide safe context through [[clang::coro_must_await]] (PR #108474)

2024-09-12 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 created https://github.com/llvm/llvm-project/pull/108474 None >From a4736c1effa479692157dbe735fa873b233f98bd Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Thu, 12 Sep 2024 17:13:57 -0700 Subject: [PATCH] [Clang] Propagate elide safe context through [[clang

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
igelbox wrote: Whew, managed to add both tests. https://github.com/llvm/llvm-project/pull/108187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -fallow-pch-with-compiler-errors -std=c++20 -x c++-header -emit-pch %s -o %t -verify +// RUN: %clang_cc1 -fallow-pch-with-compiler-errors -std=c++20 -include-pch %t %s -verify igelbox wrote: In the `main` branch it didn't fa

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
https://github.com/igelbox edited https://github.com/llvm/llvm-project/pull/108187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
https://github.com/igelbox edited https://github.com/llvm/llvm-project/pull/108187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
https://github.com/igelbox updated https://github.com/llvm/llvm-project/pull/108187 >From aee4cf70dedaa3c8b7b6508238e01f92d60c631c Mon Sep 17 00:00:00 2001 From: Sergei Date: Tue, 10 Sep 2024 16:19:05 + Subject: [PATCH 1/3] fix quick OOM in FormatDiagnostic --- .../ClangTidyDiagnosticCons

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-09-12 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,276 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #94981)

2024-09-12 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Thanks for the repro! I am taking a look. https://github.com/llvm/llvm-project/pull/94981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] Correct the line attribution for IF branches (PR #108300)

2024-09-12 Thread Paul T Robinson via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -debug-info-kind=limited -gno-column-info -triple=x86_64-pc-linux -emit-llvm %s -o - | FileCheck %s + +// The important thing is that the compare and the conditional branch have +// locs with the same scope (the lexical block for the 'if'). B

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-12 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106782 >From 99408f31a8946df7ef9efa223d0dba2ab876fcd0 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 30 Aug 2024 12:08:37 -0700 Subject: [PATCH 1/4] add diag and testing for space and global constants ---

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/90304 >From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 12:58:54 -0700 Subject: [PATCH 1/6] [CGData] Clang Optinos --- clang/include/clang/Driver/Opt

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/90304 >From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 12:58:54 -0700 Subject: [PATCH 1/6] [CGData] Clang Optinos --- clang/include/clang/Driver/Opt

[clang] [DebugInfo] Correct the line attribution for IF branches (PR #108300)

2024-09-12 Thread David Blaikie via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -debug-info-kind=limited -gno-column-info -triple=x86_64-pc-linux -emit-llvm %s -o - | FileCheck %s + +// The important thing is that the compare and the conditional branch have +// locs with the same scope (the lexical block for the 'if'). B

[clang] [DebugInfo] Correct the line attribution for IF branches (PR #108300)

2024-09-12 Thread David Blaikie via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -debug-info-kind=limited -gno-column-info -triple=x86_64-pc-linux -emit-llvm %s -o - | FileCheck %s + +// The important thing is that the compare and the conditional branch have +// locs with the same scope (the lexical block for the 'if'). B

[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

2024-09-12 Thread Joshua Batista via cfe-commits
@@ -817,8 +821,12 @@ static void DiagnoseHLSLRegisterAttribute(Sema &S, SourceLocation &ArgLoc, S.Diag(TheDecl->getLocation(), diag::warn_hlsl_user_defined_type_missing_member) << regTypeNum; - -return; +// Space argument cannot be specifie

  1   2   3   4   5   6   >