[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > For the Mips backend itself, I would ask the Mips backend code maintainer... > but we don't have a maintainer for Mips. And we don't have any buildbots. I'm > really not sure about adding complexity to a backend which is already > suffering from a lack of anyone that has any

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-09 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,400 @@ +//===--- InterpreterValuePrinter.cpp - Value printing utils -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/104856 >From 44e814b925a1ad8ac40fe6904542cbade516c065 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 19 Aug 2024 13:34:13 -0700 Subject: [PATCH 1/7] [DirectX] Add DirectXTargetCodeGenInfo Adds TargetCodeGenInfo

[clang] [clang-tools-extra] [llvm] [clang] WIP: Improved Context Declaration tracking (PR #107942)

2024-09-09 Thread Younan Zhang via cfe-commits
@@ -14873,41 +14854,6 @@ TreeTransform::TransformLambdaExpr(LambdaExpr *E) { /*IsInstantiation*/ true); SavedContext.pop(); - // Recompute the dependency of the lambda so that we can defer the lambda call - // construction until after

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Helena Kotas (hekota) Changes This PR introduces new HLSL resource type attribute `[[hlsl::row_access]]`. Presence of this attribute on a resource handle means that the resource must be accessed in 16-byte blocks at-a-time, or fou

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) Changes This PR introduces new HLSL resource type attribute `[[hlsl::row_access]]`. Presence of this attribute on a resource handle means that the resource must be accessed in 16-byte blocks at-a-time, or four 32-bit

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota ready_for_review https://github.com/llvm/llvm-project/pull/107954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/107954 >From 1c66d2767ca20f42b6edaae834cc186be7d23712 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 9 Sep 2024 19:39:02 -0700 Subject: [PATCH 1/3] [HLSL] Add `[[hlsl::row_access]]` attribute This PR introduces

[clang-tools-extra] [llvm] Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (PR #107974)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (HighW4y2H3ll) Changes Encountered several testcase failures when running `ninja check-all`. It was due to the full path name were shown in the error message instead of the binary name, and therefore causing the check str

[clang-tools-extra] [llvm] Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (PR #107974)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (HighW4y2H3ll) Changes Encountered several testcase failures when running `ninja check-all`. It was due to the full path name were shown in the error message instead of the binary name, and therefore causing the check string mis

[clang-tools-extra] [llvm] Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (PR #107974)

2024-09-09 Thread via cfe-commits
https://github.com/HighW4y2H3ll created https://github.com/llvm/llvm-project/pull/107974 Encountered several testcase failures when running `ninja check-all`. It was due to the full path name were shown in the error message instead of the binary name, and therefore causing the check string mis

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM with one nit. https://github.com/llvm/llvm-project/pull/102592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-09 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,297 @@ +/*===- avx10_2_512satcvtdsintrin.h - AVX10_2_512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Apac

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/102592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
ganeshgit wrote: > This patch enables the basic skeleton enablement of AMD next gen zen5 CPUs. @RKSimon Pl post your comments. I have few subsequent patches for scheduler enablement, and some tuning patches lined up as well. https://github.com/llvm/llvm-project/pull/107964

[clang] [HLSL] Warn on duplicate is_rov attribute; remove unnecessary parentheses (PR #107973)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Helena Kotas (hekota) Changes We should issue a warning whenever a duplicate resource type attribute is found. Currently we do that only for `resource_class`. This PR fixes that by checking for duplicate `is_rov`

[clang] [HLSL] Warn on duplicate is_rov attribute; remove unnecessary parentheses (PR #107973)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/107973 We should issue a warning whenever a duplicate resource type attribute is found. Currently we do that only for `resource_class`. This PR fixes that by checking for duplicate `is_rov` attributes as well. Also re

[clang] [clang] correct argument offset for function template partial ordering (PR #107972)

2024-09-09 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/107972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-09 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @alexfh That's a bug in the patch, thanks for reporting. This patch fixes it: https://github.com/llvm/llvm-project/pull/107972 https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang] correct argument offset for function template partial ordering (PR #107972)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes This fixes a bug in #18291, that was reported in the PR. Since this is a bug fix for a patch that was never released, no entries are added to the changelog. --- Full diff: https://github.com/llvm/llvm-p

[clang] [clang] correct argument offset for function template partial ordering (PR #107972)

2024-09-09 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/107972 This fixes a bug in #18291, that was reported in the PR. Since this is a bug fix for a patch that was never released, no entries are added to the changelog. >From 395ddd73b4dd366155a8718c13410b03bf8c6d32 Mon

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-aarch64-ubuntu-clang` running on `bolt-worker-aarch64` while building `clang,compiler-rt` at step 5 "build-clang-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/128/builds/609 Here is the

[clang] [clang][bytecode] Fix local destructor order (PR #107951)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/5257 Here is the relevant piece of the build log for

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/107954 >From 1c66d2767ca20f42b6edaae834cc186be7d23712 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 9 Sep 2024 19:39:02 -0700 Subject: [PATCH 1/2] [HLSL] Add `[[hlsl::row_access]]` attribute This PR introduces

[clang] 3928ede - [clang][bytecode] Fix local destructor order (#107951)

2024-09-09 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-10T06:26:46+02:00 New Revision: 3928edecfbd116d56bbe7411365d50bb567380a1 URL: https://github.com/llvm/llvm-project/commit/3928edecfbd116d56bbe7411365d50bb567380a1 DIFF: https://github.com/llvm/llvm-project/commit/3928edecfbd116d56bbe7411365d50bb567380a1.diff L

[clang] [clang][bytecode] Fix local destructor order (PR #107951)

2024-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/107951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-09 Thread via cfe-commits
MichelleCDjunaidi wrote: PR opened. https://github.com/llvm/llvm-project/pull/106672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: Oh, looks like I missed it. Sorry about that! There's https://github.com/llvm/

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: ganeshgit wrote: > I posted some patches a while ago to start unifying things so that there's a > si

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: I posted some patches a while ago to start unifying things so that there's a s

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: ganeshgit wrote: Will do! https://github.com/llvm/llvm-project/pull/107964 _

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: Can you bump the equivalent code in `compiler-rt` too? https://github.com/llvm

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 88bd507dc2dd9c235b54d718cf84e4ef80d94bc9 b68bcc1415151bd84b5868aa2c98663069f45469 --e

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
https://github.com/ganeshgit created https://github.com/llvm/llvm-project/pull/107964 This patch enables the basic skeleton enablement of AMD next gen zen5 CPUs. >From b68bcc1415151bd84b5868aa2c98663069f45469 Mon Sep 17 00:00:00 2001 From: Ganesh Gopalasubramanian Date: Thu, 29 Aug 2024 08:54:

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-clang-driver Author: Ganesh (ganeshgit) Changes This patch enables the basic skeleton enablement of AMD next gen zen5 CPUs. --- Patch is 31.47 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-projec

[clang] [Lex] Avoid repeated hash lookups (NFC) (PR #107963)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes MacroAnnotations has three std::optional fields. Functions makeDeprecation, makeRestrictExpansion, and makeFinal construct an instance of MacroAnnotations with one field initialized with a non-default v

[clang] [Lex] Avoid repeated hash lookups (NFC) (PR #107963)

2024-09-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/107963 MacroAnnotations has three std::optional fields. Functions makeDeprecation, makeRestrictExpansion, and makeFinal construct an instance of MacroAnnotations with one field initialized with a non-default val

[clang] [Format] Avoid repeated hash lookups (NFC) (PR #107962)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107962.diff 1 Files Affected: - (modified) clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp (+1-3) ``diff diff --git a/

[clang] [Format] Avoid repeated hash lookups (NFC) (PR #107962)

2024-09-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/107962 None >From cc3832ba4c7c00de00346bde146420afeefc0b33 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 9 Sep 2024 07:33:21 -0700 Subject: [PATCH] [Format] Avoid repeated hash lookups (NFC) --- clang

[clang] [Tablegen] Avoid repeated hash lookps (NFC) (PR #107961)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107961.diff 1 Files Affected: - (modified) clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp (+3-15) ``diff diff --git a/clang/ut

[clang] [Tablegen] Avoid repeated hash lookps (NFC) (PR #107961)

2024-09-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/107961 None >From c995b27c81f0342ebbb44ce3dbf98d8415e507e4 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 9 Sep 2024 07:34:57 -0700 Subject: [PATCH] [Tablegen] Avoid repeated hash lookps (NFC) --- .../

[clang] [APINotes] Avoid repeated hash lookups (NFC) (PR #107959)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107959.diff 1 Files Affected: - (modified) clang/lib/APINotes/APINotesWriter.cpp (+3-7) ``diff diff --git a/clang/lib/APINotes/API

[clang] [APINotes] Avoid repeated hash lookups (NFC) (PR #107959)

2024-09-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/107959 None >From 5e0e37ae0db76a18a235d2368a65a806f70320ea Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 9 Sep 2024 07:31:42 -0700 Subject: [PATCH] [APINotes] Avoid repeated hash lookups (NFC) --- cla

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-09-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dce5039 - [clang][HLSL] Add sign intrinsic part 3 (#101989)

2024-09-09 Thread via cfe-commits
Author: Tim Gymnich Date: 2024-09-09T23:35:45-04:00 New Revision: dce50397b52e33e927ffb1d1c40765109abf40f0 URL: https://github.com/llvm/llvm-project/commit/dce50397b52e33e927ffb1d1c40765109abf40f0 DIFF: https://github.com/llvm/llvm-project/commit/dce50397b52e33e927ffb1d1c40765109abf40f0.diff L

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-09 Thread via cfe-commits
MichelleCDjunaidi wrote: @5chmidti @njames93 @PiotrZSL Any updated feedback on this? https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][clang-tidy] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang-tools-extra] [Docs][clang-tidy] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-09 Thread via cfe-commits
https://github.com/MichelleCDjunaidi edited https://github.com/llvm/llvm-project/pull/107956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (MichelleCDjunaidi) Changes As per https://github.com/llvm/llvm-project/pull/106672/#issuecomment-2325577815 and https://github.com/llvm/llvm-project/issues/107377, the documentation should be updated to note that the cu

[clang-tools-extra] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-09 Thread via cfe-commits
https://github.com/MichelleCDjunaidi created https://github.com/llvm/llvm-project/pull/107956 As per https://github.com/llvm/llvm-project/pull/106672/#issuecomment-2325577815 and https://github.com/llvm/llvm-project/issues/107377, the documentation should be updated to note that the current b

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-09 Thread via cfe-commits
https://github.com/MichelleCDjunaidi updated https://github.com/llvm/llvm-project/pull/106675 >From 08324e3586acb16cbf010fd6013c21f2b5faa64e Mon Sep 17 00:00:00 2001 From: MichelleCDjunaidi <87893361+michellecdjuna...@users.noreply.github.com> Date: Fri, 30 Aug 2024 14:55:16 +0800 Subject: [PATC

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/5253 Here is the relevant piece of the build log for

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-09 Thread via cfe-commits
MichelleCDjunaidi wrote: @EugeneZelenko @5chmidti Thoughts on the fixed formatting? I followed index.rst convention. https://github.com/llvm/llvm-project/pull/106675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread Timothy Akintilo via cfe-commits
tilobyte wrote: > I also wonder if we would better off having `CXXRecordDecl` save its > 'variable' for lambdas (and look it up from there) rather than this. saving the `VarDecl` in the lambda's `CXXRecordDecl` indeed sounds like a cleaner solution--i will try implementing that before making a

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: @JinjinLi868 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-09-09 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/89051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 56905da - [clang] fix half && bfloat16 convert node expr codegen (#89051)

2024-09-09 Thread via cfe-commits
Author: JinjinLi868 Date: 2024-09-10T10:47:33+08:00 New Revision: 56905dab7da50bccfcceaeb496b206ff476127e1 URL: https://github.com/llvm/llvm-project/commit/56905dab7da50bccfcceaeb496b206ff476127e1 DIFF: https://github.com/llvm/llvm-project/commit/56905dab7da50bccfcceaeb496b206ff476127e1.diff L

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-09 Thread via cfe-commits
https://github.com/MichelleCDjunaidi updated https://github.com/llvm/llvm-project/pull/106675 >From 08324e3586acb16cbf010fd6013c21f2b5faa64e Mon Sep 17 00:00:00 2001 From: MichelleCDjunaidi <87893361+michellecdjuna...@users.noreply.github.com> Date: Fri, 30 Aug 2024 14:55:16 +0800 Subject: [PATC

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/107954 This PR introduces new HLSL resource type attribute `[[hlsl::row_access]]`. Presence of this attribute on a resource handle means that the resource must be accessed in 16-byte blocks at-a-time, or four 32-bit co

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread Timothy Akintilo via cfe-commits
@@ -876,6 +876,11 @@ class Sema; /// function pointer or reference (C++ [over.call.object]). FunctionDecl *Function; +/// LambdaName - When the OverloadCandidate is for a +/// lambda's operator(), points to the declaration of +/// the lambda variable. +

[clang] [clang][bytecode] Fix local destructor order (PR #107951)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Add appropriate scopes and use reverse-order iteration in LocalScope::emitDestructors(). --- Full diff: https://github.com/llvm/llvm-project/pull/107951.diff 3 Files Affected: - (modified) clang/lib/AST/B

[clang] [clang][bytecode] Fix local destructor order (PR #107951)

2024-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/107951 Add appropriate scopes and use reverse-order iteration in LocalScope::emitDestructors(). >From 71688d27b5fc5a9af0218e42ed38847a2d07a7ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue,

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-09 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. The LoongArch bits LGTM. Thanks. https://github.com/llvm/llvm-project/pull/107664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-09 Thread Jun Zhang via cfe-commits
@@ -0,0 +1,400 @@ +//===--- InterpreterValuePrinter.cpp - Value printing utils -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Chuanqi Xu via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: https://github.com/ChuanqiXu9 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/104512 ___ cfe-commits

[clang] [Clang] [Driver] Ensure `-fms-volatile` is set for x86 for `*-windows-msvc` triple on non cl driver modes (PR #107509)

2024-09-09 Thread Nico Weber via cfe-commits
nico wrote: (To be clear, I'm fine with landing this.) > non conforming two phase lookup by default would also be a concern. It is! There were quite a few discussions around this. Aha, see #42377. We usually say the goal is to have a very standards compliant impl, while also being able to par

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
https://github.com/eddyz87 commented: I agree with these changes, could you please also add tests? https://github.com/llvm/llvm-project/pull/107343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
@@ -864,26 +864,119 @@ class XFALU32; -def XFANDW32 : XFALU32; -def XFORW32 : XFALU32; -def XFXORW32 : XFALU32; +def XFADDW32 : XFALU32; +def XFANDW32 : XFALU32; +def XFORW32 : XFALU32; +def XFXORW32 : XFALU32; } let Predicates = [BPFHasALU32]

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
https://github.com/eddyz87 edited https://github.com/llvm/llvm-project/pull/107343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
@@ -152,22 +152,91 @@ static bool hasLiveDefs(const MachineInstr &MI, const TargetRegisterInfo *TRI) { return false; } -void BPFMIPreEmitChecking::processAtomicInsts() { +bool BPFMIPreEmitChecking::processAtomicInsts() { + if (!MF->getSubtarget().getHasJmp32()) { +// O

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
@@ -864,26 +864,119 @@ class XFALU32; -def XFANDW32 : XFALU32; -def XFORW32 : XFALU32; -def XFXORW32 : XFALU32; +def XFADDW32 : XFALU32; +def XFANDW32 : XFALU32; +def XFORW32 : XFALU32; +def XFXORW32 : XFALU32; } let Predicates = [BPFHasALU32]

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
@@ -91,6 +91,12 @@ void BTFTypeDerived::completeType(BTFDebug &BDebug) { // The base type for PTR/CONST/VOLATILE could be void. const DIType *ResolvedType = DTy->getBaseType(); + if (ResolvedType) { +const auto *DerivedTy = dyn_cast(ResolvedType); +if (DerivedTy &

[clang] [llvm] [RFC][BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-09 Thread via cfe-commits
@@ -1444,8 +1454,15 @@ void BTFDebug::processGlobals(bool ProcessingMapDef) { DIGlobal = GVE->getVariable(); if (SecName.starts_with(".maps")) visitMapDefType(DIGlobal->getType(), GVTypeId); - else -visitTypeEntry(DIGlobal->getType(), GVTypeId,

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Tex Riddell via cfe-commits
tex3d wrote: @farzonl > since this is a new builtin it would make sense to add it to > `clang/docs/ReleaseNotes.rst`. There should be some examples from Josh's PRs. I can't find the examples you're referring to. Do you think you could point one out? Also, what about the other builtins that

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-09 Thread Eli Friedman via cfe-commits
@@ -6784,6 +6784,10 @@ def warn_arc_lifetime_result_type : Warning< "ARC %select{unused|__unsafe_unretained|__strong|__weak|__autoreleasing}0 " "lifetime qualifier on return type is ignored">, InGroup; +def warn_next_larger_fp_type_same_size_than_fp : Warning< + "higher

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Tex Riddell via cfe-commits
https://github.com/tex3d updated https://github.com/llvm/llvm-project/pull/107923 >From 44b355687a3e148bfe3d5e4f95efd39363b58b07 Mon Sep 17 00:00:00 2001 From: Tex Riddell Date: Mon, 9 Sep 2024 14:39:18 -0700 Subject: [PATCH 1/2] [clang][hlsl] Add atan2 intrinsic part 1 Issue: #70096 Changes:

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-09 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,34 @@ +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -marm -S -o - %s \ +// RUN: | FileCheck %s --check-prefix=CHECK-R +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -mthum

[clang] [llvm] [NVPTX] Remove nvvm.bitcast.* intrinsics (PR #107936)

2024-09-09 Thread Alex MacLean via cfe-commits
AlexMaclean wrote: > It may be worth adding a note about this in the release notes. I'm not familiar with these, can you point me to an analogous change I could use as an example? https://github.com/llvm/llvm-project/pull/107936 ___ cfe-commits maili

[clang-tools-extra] [clangd] Use `SymbolName` to represent Objective-C selectors (PR #82061)

2024-09-09 Thread Alex Hoppen via cfe-commits
ahoppen wrote: @DavidGoldman Would you mind reviewing my changes? https://github.com/llvm/llvm-project/pull/82061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/107923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-09-09 Thread Alexander Kornienko via cfe-commits
alexfh wrote: What about this case: https://godbolt.org/z/1TsK96ao8 ? It's a reduction of one of a large number of broken builds we see after this patch. https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. LGTM, but would be good to get a review from someone more knowledgeable in the area than I am. https://github.com/llvm/llvm-project/pull/106588 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Eli Friedman via cfe-commits
=?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Po

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/107923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Farzon Lotfi via cfe-commits
@@ -1244,6 +1244,12 @@ def ElementwiseATan : Builtin { let Prototype = "void(...)"; } +def ElementwiseATan2 : Builtin { + let Spellings = ["__builtin_elementwise_atan2"]; + let Attributes = [NoThrow, Const, CustomTypeChecking]; farzonl wrote: This is more

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-09 Thread Yeoul Na via cfe-commits
@@ -14,12 +16,26 @@ void Func() { auto NODEREF auto_i2 = i; // expected-warning{{'noderef' can only be used on an array or pointer type}} } +// The diagnostic message is hard-coded as 'noderef' so using a system macro doesn't change the behavior +void Func_system_macro() {

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-09 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna updated https://github.com/llvm/llvm-project/pull/107619 >From 1d00f0fca700c058320a39cd3f40cdd58c37cf8f Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Thu, 5 Sep 2024 09:52:41 -0700 Subject: [PATCH 1/2] [Parser][BoundsSafety] Print attribute as macro if it's system d

[clang] [llvm] [clang][hlsl] Add atan2 intrinsic part 1 (PR #107923)

2024-09-09 Thread Farzon Lotfi via cfe-commits
farzonl wrote: since this is a new builtin it would make sense to add it to `clang/docs/ReleaseNotes.rst`. There should be some examples from Josh's PRs. https://github.com/llvm/llvm-project/pull/107923 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106588 >From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Wed, 24 Jul 2024 16:49:19 -0600 Subject: [PATCH 1/8] [HLSL] set alwaysinline on HLSL functions HLSL inlines all its

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Greg Roth via cfe-commits
@@ -2471,11 +2471,14 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::StackProtectReq); if (!D) { +// HLSL functions must always be inlined +if (getLangOpts().HLSL && !F->hasFnAttribute("hlsl.shader"))

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread via cfe-commits
=?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Poussineau , =?utf-8?q?Hervé?= Po

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-09-09 Thread Galen Elias via cfe-commits
https://github.com/galenelias deleted https://github.com/llvm/llvm-project/pull/105597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-09-09 Thread Galen Elias via cfe-commits
@@ -27981,6 +27981,118 @@ TEST_F(FormatTest, BreakBinaryOperations) { Style); } +TEST_F(FormatTest, ShortNamespacesOption) { + FormatStyle Style = getLLVMStyle(); + Style.AllowShortNamespacesOnASingleLine = true; + Style.FixNamespaceComments = false; + + //

[clang] [llvm] [NVPTX] Remove nvvm.bitcast.* intrinsics (PR #107936)

2024-09-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: It may be worth adding a note about this in the release notes. https://github.com/llvm/llvm-project/pull/107936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Chris B via cfe-commits
@@ -2502,9 +2505,12 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, ShouldAddOptNone &= !D->hasAttr(); ShouldAddOptNone &= !D->hasAttr(); - // Add optnone, but do so only if the function isn't always_inline. - if ((ShouldAddOptNone || D->has

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/106588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Chris B via cfe-commits
@@ -2471,11 +2471,14 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::StackProtectReq); if (!D) { +// HLSL functions must always be inlined llvm-beanz wrote: nit: we do try have comments b

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-09 Thread Chris B via cfe-commits
@@ -2471,11 +2471,14 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::StackProtectReq); if (!D) { +// HLSL functions must always be inlined +if (getLangOpts().HLSL && !F->hasFnAttribute("hlsl.shader"))

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-09-09 Thread Tim Gymnich via cfe-commits
tgymnich wrote: Rebased. All ready to go. https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Allow truncation to scalar (PR #104844)

2024-09-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: ExprConstant.cpp currently assumes that an CK_HLSLVectorTruncation can't return a scalar type. https://github.com/llvm/llvm-project/pull/104844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

  1   2   3   4   5   >