[clang] [Clang][HIP] Target-dependent overload resolution in declarators and specifiers (PR #103031)

2024-08-19 Thread Fabian Ritter via cfe-commits
@@ -0,0 +1,703 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -verify=expected,onhost %s +// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsyntax-only -fcuda-is-device -verify=expected,ondevice %s + + +// Tests to ensure that functions with host and device

[clang] [Clang][HIP] Target-dependent overload resolution in declarators and specifiers (PR #103031)

2024-08-19 Thread Fabian Ritter via cfe-commits
@@ -115,20 +143,65 @@ static bool hasAttr(const Decl *D, bool IgnoreImplicitAttr) { }); } +SemaCUDA::CUDATargetContext::CUDATargetContext(SemaCUDA *S, ritter-x2a wrote: Addressed in e273a996854cb3256cfeed832c3f16ff6fd0f534. https://github.com/llvm/

[clang] [Clang][HIP] Target-dependent overload resolution in declarators and specifiers (PR #103031)

2024-08-19 Thread Fabian Ritter via cfe-commits
@@ -9017,6 +9017,10 @@ def err_global_call_not_config : Error< def err_ref_bad_target : Error< "reference to %select{__device__|__global__|__host__|__host__ __device__}0 " "%select{function|variable}1 %2 in %select{__device__|__global__|__host__|__host__ __device__}3 funct

[clang] [Clang][HIP] Target-dependent overload resolution in declarators and specifiers (PR #103031)

2024-08-19 Thread Fabian Ritter via cfe-commits
https://github.com/ritter-x2a updated https://github.com/llvm/llvm-project/pull/103031 >From 274aaef1847bbdd837213064113adb1182e5bb59 Mon Sep 17 00:00:00 2001 From: Fabian Ritter Date: Tue, 13 Aug 2024 05:27:45 -0400 Subject: [PATCH 1/4] [Clang][HIP] Target-dependent overload resolution in dec

[libcxx] [libcxxabi] [libunwind] [libc++/libc++abi/libunwind] Add new test configs for Clang runtime library. NFC. (PR #82734)

2024-08-19 Thread Vladimir Vereschaka via cfe-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/82734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [libc++/libc++abi/libunwind] Add new test configs for Clang runtime library. NFC. (PR #82734)

2024-08-19 Thread Vladimir Vereschaka via cfe-commits
@@ -0,0 +1,32 @@ +# This testing configuration handles running the test suite against LLVM's libc++ +# using a static library. +# +# This configuration uses a 'just-built' Clang runtime builtins library to link with +# the tests instead of the target system library. +# +# Provid

[clang] [clang][bytecode] Support ObjC blocks (PR #104551)

2024-08-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/104551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca148b2 - [clang][bytecode] Support ObjC blocks (#104551)

2024-08-19 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-20T06:08:53+02:00 New Revision: ca148b21505e97f07787c13ec00ffc086d4658d0 URL: https://github.com/llvm/llvm-project/commit/ca148b21505e97f07787c13ec00ffc086d4658d0 DIFF: https://github.com/llvm/llvm-project/commit/ca148b21505e97f07787c13ec00ffc086d4658d0.diff L

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-08-19 Thread via cfe-commits
trcrsired wrote: @zmodem ok. let me explain to me why using the same file structure of msvc does not work. MSVC's built-in headers conflict with Clang's built-in headers so clang cannot use its headers any more. The headers and libraries are not case-sensitive, which causes issues on operatin

[clang] [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (PR #104872)

2024-08-19 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/104872 >From 2203d4437fd2a535cc559bcfbf0a41b5d6acf1cc Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Mon, 19 Aug 2024 15:01:33 -0700 Subject: [PATCH] [clang][modules] Built-in modules are not correctly ena

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-08-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Here is another example that merging lambdas are problematic: https://github.com/llvm/llvm-project/issues/102721. Although I think we need to solve the problems separately. They are different problems. > > I feel the change is somewhat odd to me. Since the description is abo

[clang] [llvm] [Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline (PR #100205)

2024-08-19 Thread Craig Topper via cfe-commits
topperc wrote: I wonder if this caused https://github.com/llvm/llvm-project/issues/104525 https://github.com/llvm/llvm-project/pull/100205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -9,17 +9,14 @@ #ifndef LLVM_SUPPORT_CHRONO_H #define LLVM_SUPPORT_CHRONO_H -#include "llvm/Support/Compiler.h" -#include "llvm/Support/FormatProviders.h" +#include "llvm/Support/FormatVariadicDetails.h" #include s-barannikov wrote: (nit) extra newline

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -12,10 +12,8 @@ #include "Unix.h" #include "llvm/ADT/Hashing.h" -#include "llvm/ADT/StringRef.h" +#include "llvm/ADT/StringSwitch.h" #include "llvm/Config/config.h" -#include -#include s-barannikov wrote: `` is used in this file https://github.com/llv

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -19,6 +19,7 @@ #include "llvm/IR/InstVisitor.h" #include "llvm/IR/ValueHandle.h" #include "llvm/Pass.h" +#include "llvm/Support/Debug.h" using namespace llvm; s-barannikov wrote: ```suggestion using namespace llvm; ``` https://github.com/llvm/llvm-projec

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -10,6 +10,7 @@ #include "InputFiles.h" #include "InputSection.h" #include "OutputSegment.h" +#include "llvm/ADT/StringSwitch.h" #include s-barannikov wrote: (nit) ```suggestion #include "llvm/ADT/StringSwitch.h" #include ``` https://github.com/llvm/ll

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -1,4 +1,4 @@ -//===- MachineCFGPrinter.cpp - DOT Printer for Machine Functions --===// +//===- - DOT Printer for Machine Functions --===// s-barannikov wrote: Looks unintended. https://github.com/llvm/llvm-project/pull/104825 _

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -39,7 +39,6 @@ #ifndef LLVM_SUPPORT_BALANCED_PARTITIONING_H #define LLVM_SUPPORT_BALANCED_PARTITIONING_H -#include "raw_ostream.h" #include "llvm/ADT/ArrayRef.h" #include s-barannikov wrote: (nit) ```suggestion #include "llvm/ADT/ArrayRef.h" #include

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Sergei Barannikov via cfe-commits
@@ -13,10 +13,12 @@ #ifndef LLVM_SUPPORT_COMPRESSION_H #define LLVM_SUPPORT_COMPRESSION_H -#include "llvm/ADT/ArrayRef.h" -#include "llvm/Support/DataTypes.h" +#include "llvm/Support/ErrorHandling.h" +#include +#include s-barannikov wrote: Here and elsewher

[clang] [Clang][Sema] Expose static inline functions from GMF (PR #104701)

2024-08-19 Thread Chuanqi Xu via cfe-commits
Jan =?utf-8?q?Kokemüller?= Message-ID: In-Reply-To: @@ -6926,11 +6926,26 @@ void Sema::AddOverloadCandidate( /// have linkage. So that all entities of the same should share one /// linkage. But in clang, different entities of the same could have /// different lin

[clang] [Clang][Sema] Expose static inline functions from GMF (PR #104701)

2024-08-19 Thread Chuanqi Xu via cfe-commits
Jan =?utf-8?q?Kokemüller?= Message-ID: In-Reply-To: @@ -6926,11 +6926,26 @@ void Sema::AddOverloadCandidate( /// have linkage. So that all entities of the same should share one /// linkage. But in clang, different entities of the same could have /// different lin

[clang] [Clang][Sema] Expose static inline functions from GMF (PR #104701)

2024-08-19 Thread Chuanqi Xu via cfe-commits
Jan =?utf-8?q?Kokemüller?= Message-ID: In-Reply-To: @@ -6926,11 +6926,26 @@ void Sema::AddOverloadCandidate( /// have linkage. So that all entities of the same should share one /// linkage. But in clang, different entities of the same could have /// different lin

[clang] [Clang][Sema] Expose static inline functions from GMF (PR #104701)

2024-08-19 Thread Chuanqi Xu via cfe-commits
Jan =?utf-8?q?Kokem=C3=BCller?= Message-ID: In-Reply-To: https://github.com/ChuanqiXu9 approved this pull request. LGTM except comments. https://github.com/llvm/llvm-project/pull/104701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang][Sema] Expose static inline functions from GMF (PR #104701)

2024-08-19 Thread Chuanqi Xu via cfe-commits
Jan =?utf-8?q?Kokemüller?= Message-ID: In-Reply-To: https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/104701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -459,7 +468,413 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,131 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// TODO: Implement "Buffer", we use a substitute UDT +// to test the 't' binding type for this test. damyanp wrote: I don't think that this TODO

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -459,7 +468,413 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -492,14 +999,21 @@ void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { // Validate. if (!Slot.empty()) { switch (Slot[0]) { damyanp wrote: This still seems to be essentially a duplicate of `getRegisterTypeIndex`. You may nee

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -459,7 +468,413 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,103 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// TODO: Implement "Buffer" +struct Eg1 { + float f; + // Buffer Buf; + RWBuffer RWBuf; + }; +Eg1 e1 : /* register(t0) :*/ register(u0); +// Valid: f is skip

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,76 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// This test validates the diagnostics that are emitted when a variable with a "resource" type +// is bound to a register using the register annotation + +// expe

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -459,7 +468,413 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,76 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// This test validates the diagnostics that are emitted when a variable with a "resource" type +// is bound to a register using the register annotation + +// expe

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp requested changes to this pull request. https://github.com/llvm/llvm-project/pull/97103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-19 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,131 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// TODO: Implement "Buffer", we use a substitute UDT +// to test the 't' binding type for this test. + +template +struct [[hlsl::resource_class(SRV)]] MyTemplated

[clang] [HLSL] Implement '__builtin_hlsl_is_intangible' type trait (PR #104544)

2024-08-19 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/104544 >From 6d5f8991a4ef9e79bc1bed30addf7b29b7ed0d2e Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 15 Aug 2024 19:03:29 -0700 Subject: [PATCH 1/8] Implement `__builtin_is_intangible` --- clang/include/clang/

[clang] [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (PR #104872)

2024-08-19 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/104872 >From e6f0a912575d234998b67faf6ce165033dc81d66 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Mon, 19 Aug 2024 15:01:33 -0700 Subject: [PATCH] [clang][modules] Built-in modules are not correctly ena

[clang] [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (PR #104872)

2024-08-19 Thread Ian Anderson via cfe-commits
@@ -2953,7 +2953,15 @@ static bool sdkSupportsBuiltinModules( case Darwin::MacOS: return SDKVersion >= VersionTuple(15U); ian-twilightcoder wrote: Ok sure https://github.com/llvm/llvm-project/pull/104872 ___ cf

[clang] [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (PR #104872)

2024-08-19 Thread Cyndy Ishida via cfe-commits
@@ -2953,7 +2953,15 @@ static bool sdkSupportsBuiltinModules( case Darwin::MacOS: return SDKVersion >= VersionTuple(15U); cyndyishida wrote: The extra test coverage is more for future-proofing. There is a decent amount of `TargetVariantTriple` logic happ

[clang-tools-extra] [clang-tidy] Update TODO comment check (PR #104868)

2024-08-19 Thread Alan Rosenthal via cfe-commits
https://github.com/AlanRosenthal updated https://github.com/llvm/llvm-project/pull/104868 >From 9415bc98324a6715a77704acab58b53922297402 Mon Sep 17 00:00:00 2001 From: Alan Rosenthal Date: Mon, 19 Aug 2024 22:56:29 + Subject: [PATCH] [clang-tidy] Update TODO comment check The doc for googl

[clang-tools-extra] [clang-tidy] Update TODO comment check (PR #104868)

2024-08-19 Thread Alan Rosenthal via cfe-commits
https://github.com/AlanRosenthal updated https://github.com/llvm/llvm-project/pull/104868 >From 891fe7098179188bea3bd825f615762022cb0828 Mon Sep 17 00:00:00 2001 From: Alan Rosenthal Date: Mon, 19 Aug 2024 22:44:30 + Subject: [PATCH] [clang-tidy] Update TODO comment check The doc for googl

[clang] [HLSL] Implement output parameter (PR #101083)

2024-08-19 Thread John McCall via cfe-commits
@@ -4148,6 +4152,30 @@ static void emitWriteback(CodeGenFunction &CGF, assert(!isProvablyNull(srcAddr.getBasePointer()) && "shouldn't have writeback for provably null argument"); + if (CGF.getLangOpts().HLSL) { +if (!isa(writeback.CastExpr)) { + RValue Tmp

[clang] [HLSL] Implement output parameter (PR #101083)

2024-08-19 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/101083 >From e8ec3e24e0061714b5dc440b1b92086965809483 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 29 Jul 2024 16:05:11 -0500 Subject: [PATCH 01/10] [HLSL] Implement output parameter HLSL output paramet

[clang] [clang][NFC] order C++ standards in reverse in release notes (PR #104866)

2024-08-19 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/104866 >From 2e482fb68ba798a5b41b0524a6ea43f0e6e4a5a4 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Tue, 20 Aug 2024 08:35:29 +1100 Subject: [PATCH 1/2] [clang][NFC] order C++ standards in reverse in release p

[clang-tools-extra] [clang-tidy] Update TODO comment check (PR #104868)

2024-08-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-clang-tools-extra Author: Alan Rosenthal (AlanRosenthal) Changes The doc for google-readability-todo reference lists two styles of TODO comments: https://google.github.io/styleguide/cppguide.html#TODO_Comments Previously,

[clang] [clang][NFC] order C++ standards in reverse in release notes (PR #104866)

2024-08-19 Thread via cfe-commits
h-vetinari wrote: Arguably the sections for C++17 and C++14 could even be deleted, since support has been declared complete as of clang 19 https://github.com/llvm/llvm-project/blob/6e3026883d77124e32a2a7be72c3361fba3e7457/clang/docs/ReleaseNotes.rst?plain=1#L194-L196 https://github.com/llvm/llv

[clang-tools-extra] [clang-tidy] Update TODO comment check (PR #104868)

2024-08-19 Thread Alan Rosenthal via cfe-commits
https://github.com/AlanRosenthal created https://github.com/llvm/llvm-project/pull/104868 The doc for google-readability-todo reference lists two styles of TODO comments: https://google.github.io/styleguide/cppguide.html#TODO_Comments Previously, only `TODO(info): comment` were supported. After

[clang] [clang][NFC] order C++ standards in reverse in release notes (PR #104866)

2024-08-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (h-vetinari) Changes Noticed that the release notes currently have a weird order: C++17, C++14(!), C++20, C++23, C++2c. Reorder them in reverse chronological order, which also matches the [status page](https://clang.llvm.org/cxx_stat

[clang] [clang][NFC] order C++ standards in reverse in release notes (PR #104866)

2024-08-19 Thread via cfe-commits
https://github.com/h-vetinari edited https://github.com/llvm/llvm-project/pull/104866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] order C++ standards in reverse in release pages (PR #104866)

2024-08-19 Thread via cfe-commits
https://github.com/h-vetinari created https://github.com/llvm/llvm-project/pull/104866 Noticed that the release notes currently have a weird order: C++17, C++14(!), C++20, C++23, C++2c. Reorder them in reverse chronological order, which also matches the [status page](https://clang.llvm.org/cxx

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-08-19 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can you please add more details in your summary about the problem and how the PR will fix the problem. Having detailed summaries for got log is important. Also for the code reviewer as well, I should get a good snapshot of the problem and fix from the summary. https://github.com

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-19 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/104656 >From 9aff63478b76f042c05b7ae3dd1a2c099dc615de Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Fri, 2 Aug 2024 20:10:04 -0600 Subject: [PATCH 1/7] Add SPIRV generation for HLSL dot This adds the SPIRV fdot, sdot

[clang] [Sparc] Add flags to enable errata workaround pass for GR712RC and UT700 (PR #104742)

2024-08-19 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang -target sparc -mfix-gr712rc -### %s 2> %t +// RUN: FileCheck --check-prefix=CHECK-FIX-GR712RC < %t %s +// CHECK-FIX-GR712RC: "-target-feature" "+fix-tn0009" +// CHECK-FIX-GR712RC: "-target-feature" "+fix-tn0011" MaskRay wrote: If

[clang] [Sparc] Add flags to enable errata workaround pass for GR712RC and UT700 (PR #104742)

2024-08-19 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang -target sparc -mfix-gr712rc -### %s 2> %t MaskRay wrote: `--target=` for new tests. `-target ` has been deprecated since around Clang 3.4 https://github.com/llvm/llvm-project/pull/104742 __

[clang] [Driver] Make ffp-model=fast honor non-finite-values, introduce ffp-model=aggressive (PR #100453)

2024-08-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/100453 >From 9ee59aa30aa3eb4aba986d8cdfb65fbfc7591f0b Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 19 Apr 2024 15:34:03 -0700 Subject: [PATCH 1/4] [Driver] Introduce ffp-model=aggressive This change modifi

[clang] [Driver] Make ffp-model=fast honor non-finite-values, introduce ffp-model=aggressive (PR #100453)

2024-08-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/100453 >From 59ac754b9a88037e2348f16e5dc7efbd437d65cb Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 19 Aug 2024 13:41:40 -0700 Subject: [PATCH 1/5] Fix bug with -ffp-contract=fast-honor-pragmas This fixes a

[clang] [Clang] Fix ICE in SemaOpenMP with structured binding (PR #104822)

2024-08-19 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 closed https://github.com/llvm/llvm-project/pull/104822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e732d1c - [Clang] Fix ICE in SemaOpenMP with structured binding (#104822)

2024-08-19 Thread via cfe-commits
Author: Yuxuan Chen Date: 2024-08-19T14:06:10-07:00 New Revision: e732d1ce86783b1d7fe30645fcb30434109505b9 URL: https://github.com/llvm/llvm-project/commit/e732d1ce86783b1d7fe30645fcb30434109505b9 DIFF: https://github.com/llvm/llvm-project/commit/e732d1ce86783b1d7fe30645fcb30434109505b9.diff L

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Xiang Li via cfe-commits
@@ -0,0 +1,60 @@ +//===- DirectX.cpp +//---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-19 Thread via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-19 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,60 @@ +//===- DirectX.cpp +//---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,60 @@ +//===- DirectX.cpp +//---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/104856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Justin Bogner via cfe-commits
https://github.com/bogner commented: We should be able to test this by defining a global or calling a function with the `__hlsl_resource_t` type. https://github.com/llvm/llvm-project/pull/104856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104854)

2024-08-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread Vlad Serebrennikov via cfe-commits
@@ -9311,6 +9311,9 @@ def note_constinit_missing_here : Note< def err_dimension_expr_not_constant_integer : Error< "dimension expression does not evaluate to a constant unsigned int">; +def err_function_parameter_limit_exceeded : Error< + "too many function parameters; subs

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#104858 https://github.com/llvm/llvm-project/pull/104829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104857)

2024-08-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This fixes a problem which caused clang to assert in the Sema pragma handling if it encountered "#pragma STDC FP_CONTRACT DEFAULT" when compiling with the -ffp-contract=fast-honor-pragmas option. This fixes

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104857)

2024-08-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/104857 This fixes a problem which caused clang to assert in the Sema pragma handling if it encountered "#pragma STDC FP_CONTRACT DEFAULT" when compiling with the -ffp-contract=fast-honor-pragmas option. This fixes h

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/104833 >From 424818620766cedb2770e076ee359afeb0cc14ec Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 19 Aug 2024 19:26:46 +0300 Subject: [PATCH 1/6] Add in-loop check --- clang/include/clang/AST/Type.h

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-19 Thread via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-19 Thread Adam Magier via cfe-commits
@@ -3324,6 +3359,20 @@ llvm::Constant *CodeGenFunction::EmitCheckTypeDescriptor(QualType T) { DiagnosticsEngine::ak_qualtype, (intptr_t)T.getAsOpaquePtr(), StringRef(), StringRef(), std::nullopt, Buffer, std::nullopt); + if (IsBitInt) { +// The Structure is:

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: /cherry-pick 435cb0dc5eca08cdd8d9ed0d887fa1693cc2bf33 https://github.com/llvm/llvm-project/pull/104829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman milestoned https://github.com/llvm/llvm-project/pull/104829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add __builtin_hlsl_is_scalarized_layout_compatible (PR #102227)

2024-08-19 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/102227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/104829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 435cb0d - [C++23] Fix infinite recursion (Clang 19.x regression) (#104829)

2024-08-19 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-08-19T16:54:12-04:00 New Revision: 435cb0dc5eca08cdd8d9ed0d887fa1693cc2bf33 URL: https://github.com/llvm/llvm-project/commit/435cb0dc5eca08cdd8d9ed0d887fa1693cc2bf33 DIFF: https://github.com/llvm/llvm-project/commit/435cb0dc5eca08cdd8d9ed0d887fa1693cc2bf33.diff

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/104829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Aaron Ballman via cfe-commits
@@ -20,3 +19,29 @@ struct S : HasVT { HasD<> v; }; +// Ensure we don't get infinite recursion from the check, however. See GH104802 +namespace GH104802 { +class foo { // expected-note {{definition of 'GH104802::foo' is not complete until the closing '}'}} + foo a;

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) Changes Adds target codegen info class for DirectX. For now it always translates `__hlsl_resource_t` handle to `target("dx.TypedBuffer", i32, 1, 0, 1)` (`RWBuffer`). More work is needed to determine the actual t

[clang] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-08-19 Thread Helena Kotas via cfe-commits
https://github.com/hekota created https://github.com/llvm/llvm-project/pull/104856 Adds target codegen info class for DirectX. For now it always translates `__hlsl_resource_t` handle to `target("dx.TypedBuffer", i32, 1, 0, 1)` (`RWBuffer`). More work is needed to determine the actual target ex

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104854)

2024-08-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This fixes a problem which caused clang to assert in the Sema pragma handling if it encountered "#pragma STDC FP_CONTRACT DEFAULT" when compiling with the -ffp-contract=fast-honor-pragmas option. This fixes

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104854)

2024-08-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/104854 This fixes a problem which caused clang to assert in the Sema pragma handling if it encountered "#pragma STDC FP_CONTRACT DEFAULT" when compiling with the -ffp-contract=fast-honor-pragmas option. This fixes h

[clang] Fix bug (PR #104811)

2024-08-19 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/104811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV]Add SPIRV generation for HLSL dot (PR #104656)

2024-08-19 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/104656 >From 9aff63478b76f042c05b7ae3dd1a2c099dc615de Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Fri, 2 Aug 2024 20:10:04 -0600 Subject: [PATCH 1/6] Add SPIRV generation for HLSL dot This adds the SPIRV fdot, sdot

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-19 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-19 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @eddyz87 , just create a new PR with the changes and make the cross references between this PR and the new one to let people easy find the original PR when necessary. https://github.com/llvm/llvm-project/pull/101228 ___ cfe-commits

[clang] [llvm] [Driver] Default -msmall-data-limit= to 0 and clean up code (PR #83093)

2024-08-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/83093 >From dbc9ddd9a9b1b73d56f8aab5265db36a44e6fcaf Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 26 Feb 2024 17:58:55 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[clang-tools-extra] Emit `BeginSourceFile` failure with `elog`. (PR #104845)

2024-08-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/104845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Split invalid-cpu-note tests (PR #104601)

2024-08-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-19 Thread via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-19 Thread via cfe-commits
eddyz87 wrote: Hi @vvereschaka , Yes, I receive email notifications, the commit was reverted an hour ago. While at it, could you please help me understand current process, should I open a new pull request once I figure out the fix? https://github.com/llvm/llvm-project/pull/101228 _

[clang] [Clang] Fix ICE in SemaOpenMP with structured binding (PR #104822)

2024-08-19 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM. We will complain when someone tries to capture a structure binding anyway. https://github.com/llvm/llvm-project/pull/104822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/104833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread via cfe-commits
@@ -9311,6 +9311,9 @@ def note_constinit_missing_here : Note< def err_dimension_expr_not_constant_integer : Error< "dimension expression does not evaluate to a constant unsigned int">; +def err_function_parameter_limit_exceeded : Error< + "too many function parameters; subs

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread via cfe-commits
@@ -8025,6 +8025,17 @@ void Parser::ParseParameterDeclarationClause( // Consume the keyword. ConsumeToken(); } + + // FunctionTypeBitfields::NumParams can only hold so much. cor3ntin wrote: ```suggestion // We can only store so

[clang] [clang] Diagnose functions with too many parameters (PR #104833)

2024-08-19 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/104833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-08-19 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/94368 >From b6d45ded3d0d1ad6a50a1292d4f8275081089150 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Tue, 4 Jun 2024 08:33:51 -0700 Subject: [PATCH 1/9] [Clang] Fix potential null pointer dereferences in Sema::Ad

[clang] [C++23] Fix infinite recursion (Clang 19.x regression) (PR #104829)

2024-08-19 Thread Shafik Yaghmour via cfe-commits
@@ -20,3 +19,29 @@ struct S : HasVT { HasD<> v; }; +// Ensure we don't get infinite recursion from the check, however. See GH104802 +namespace GH104802 { +class foo { // expected-note {{definition of 'GH104802::foo' is not complete until the closing '}'}} + foo a;

  1   2   3   4   5   >