[PATCH] D158920: Delete CloudABI support

brad added a comment. Also.. # RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-cloudabi %s -o %t.o ./lld/test/ELF/aarch64-got-relocations.s // RUN: llvm-mc -filetype=obj -triple=i686-unknown-cloudabi %s -o %t.o ./lld/test/ELF/static-with-export-dynamic.s # RUN: llvm-mc -filetype=obj

[PATCH] D158920: Delete CloudABI support

brad updated this revision to Diff 553705. brad added a comment. Missed BUILD.gn, a unit test and one or two other files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158920/new/ https://reviews.llvm.org/D158920 Files: clang/docs/tools/clang-fo

[PATCH] D158858: [analyzer] MPIChecker: add defensive checking (check against nullptr)

steakhal added a comment. Thanks. Feel free to merge this (before any of the others). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158858/new/ https://reviews.llvm.org/D158858 ___ cfe-commits mailing li

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c9c9dd9a24f: [clang][Sema] Add truncation warning on fortified snprintf (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D158562?vs=553246&id=553702#toc Repository: rG LLVM

[clang] 0c9c9dd - [clang][Sema] Add truncation warning on fortified snprintf

Author: Takuya Shimizu Date: 2023-08-26T14:41:05+09:00 New Revision: 0c9c9dd9a24f9d715d950fef0ac7aae01437af96 URL: https://github.com/llvm/llvm-project/commit/0c9c9dd9a24f9d715d950fef0ac7aae01437af96 DIFF: https://github.com/llvm/llvm-project/commit/0c9c9dd9a24f9d715d950fef0ac7aae01437af96.diff

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In D157

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

MaskRay added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:718 ; -FeaturesMask |= (1ULL << Feature); +FeatureMask[Feature / 32] |= 1U << (Feature % 32); } pengfei wrote: > Should we use vector for future expansion, or

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27da15381cbe: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4} (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 27da153 - [X86] __builtin_cpu_supports: support x86-64{, -v2, -v3, -v4}

Author: Fangrui Song Date: 2023-08-25T20:56:25-07:00 New Revision: 27da15381cbe2ac6fd1319f6409dbbab9a857b7b URL: https://github.com/llvm/llvm-project/commit/27da15381cbe2ac6fd1319f6409dbbab9a857b7b DIFF: https://github.com/llvm/llvm-project/commit/27da15381cbe2ac6fd1319f6409dbbab9a857b7b.diff

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

MaskRay updated this revision to Diff 553698. MaskRay edited the summary of this revision. MaskRay added a comment. rebase after precommitting `target("x86-64") and cpu_specific(x86_64) attributes` tests add `__builtin_cpu_supports x86-64-v5` test Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 updated this revision to Diff 553697. danix800 added a comment. Update docs for `bitIntType` & `dependentBitIntType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158872/new/ https://reviews.llvm.org/D158872 Files: clang/docs/LibASTMat

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4618252 , @PiotrZSL wrote: > LGTM. > Nothing fancy, looks straight forward. > You may want to wait for an Aaron Ballman opinion. Thanks for the reviewing. Ping @aaron.ballman, could you please take a look at this rev

[clang] 9de3b35 - [X86][test] Test that target("x86-64") and cpu_specific(x86_64) attributes are invalid

Author: Fangrui Song Date: 2023-08-25T20:45:45-07:00 New Revision: 9de3b35ac9159d5bae6e6796cb91e4f877a07189 URL: https://github.com/llvm/llvm-project/commit/9de3b35ac9159d5bae6e6796cb91e4f877a07189 DIFF: https://github.com/llvm/llvm-project/commit/9de3b35ac9159d5bae6e6796cb91e4f877a07189.diff

[PATCH] D158920: Delete CloudABI support

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158920/new/ https://reviews.llvm.org/D158920 __

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

shafik added a comment. It might have been nice to add a test where `nullptr_t` comparison succeeds as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158601/new/ https://reviews.llvm.org/D158601 __

[PATCH] D158920: Delete CloudABI support

brad created this revision. brad added reviewers: MaskRay, ed, dim. brad added projects: LLVM, clang. Herald added subscribers: steakhal, martong, hiraditya, krytarowski, arichardson, emaste. Herald added a reviewer: NoQ. Herald added a project: All. brad requested review of this revision. After

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158811/new/ https://reviews.llvm.org/D158811

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

shafik updated this revision to Diff 553692. shafik added a comment. - Move test to C++20 file - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 Files: clang/lib/Parse/ParseExprCXX.cpp clang/test/Parser/cxx2a-template-la

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 553682. void added a comment. Modify sanitize scope to avoid the instruction creation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/A

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana updated this revision to Diff 553677. iana added a comment. Modules don't support the #include #undef #include pattern to redefine macros, the second include has no effect. Move the #undef of NULL into __stddef_null.h so that the textual behavior is preserved, but the module behavior doesn'

[clang] 1376dfa - [OpenMP][Fix] Update test after changing flag value

Author: Joseph Huber Date: 2023-08-25T18:59:43-05:00 New Revision: 1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f URL: https://github.com/llvm/llvm-project/commit/1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f DIFF: https://github.com/llvm/llvm-project/commit/1376dfa32c5b94b33d396ecfd5a6e27cd9179b2f.diff

[clang] 8456c8f - [CMake] Allow enabling Python in Fuchsia LLDB

Author: Daniel Thornburgh Date: 2023-08-25T16:45:05-07:00 New Revision: 8456c8fe4e82e667e90beebb793c472bc0654a4c URL: https://github.com/llvm/llvm-project/commit/8456c8fe4e82e667e90beebb793c472bc0654a4c DIFF: https://github.com/llvm/llvm-project/commit/8456c8fe4e82e667e90beebb793c472bc0654a4c.d

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad closed this revision. brad added a comment. Oops. I missed pasting the URL when commiting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158715/new/ https://reviews.llvm.org/D158715 ___ cfe-com

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1247 if (Previous && Previous->isNot(TT_LineComment)) { - Changes[Next->Index].Spaces = 0; + Changes[Next->Index].Spaces = BracePadding; Changes[Next->Index].Ne

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; - assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + asser

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10112 + Specialization->addAttr(PrevDecl->getAttr()); + Consumer.AssignInheritanceModel(Specialization); +} erichkeane wrote: > tahonermann wrote: > > I am concerned that

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 553639. ZijunZhao added a comment. Add integer type test and update c2x tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

dblaikie added a comment. (probably worth linking to the RFC/etc (https://discourse.llvm.org/t/rfc-modules-build-daemon-build-system-agnostic-support-for-explicitly-built-modules/71524/47) from the patch description/commit message) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

dblaikie added a comment. > Maybe we should consider adding a flag to set diagnostic verbosity level? > e.g., -fdiagnostic-verbosity=terse|default|verbose where terse never prints > notes or include stacks, default is what we do today, and verbose always > prints include stacks? My guess would

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo updated this revision to Diff 553624. mstorsjo edited the summary of this revision. mstorsjo added a comment. Updated to use the form -fno-auto-import and similar split it into two separate words everywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

dblaikie added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 32 - 8

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added a comment. In D61670#4611790 , @aeubanks wrote: > In D61670#4607313 , @mstorsjo wrote: > >>> I expected the answer would be "yes", so I said "lgtm" and then phrased my >>> question very awkwardly. >>

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33b6b674620d: [clang] Fix crash in __builtin_strncmp and other related builtin functions (authored by shafik). Herald added a project: clang. Reposi

[clang] 33b6b67 - [clang] Fix crash in __builtin_strncmp and other related builtin functions

Author: Shafik Yaghmour Date: 2023-08-25T13:54:50-07:00 New Revision: 33b6b674620d77e615d569f504b306aac528bab7 URL: https://github.com/llvm/llvm-project/commit/33b6b674620d77e615d569f504b306aac528bab7 DIFF: https://github.com/llvm/llvm-project/commit/33b6b674620d77e615d569f504b306aac528bab7.dif

[PATCH] D158873: [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0f53cb4bfb2: [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr (authored by nridge). Repository: rG LLVM Github Mo

[clang-tools-extra] f0f53cb - [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

Author: Nathan Ridge Date: 2023-08-25T16:54:29-04:00 New Revision: f0f53cb4bfb2b6c5ec6661b565a764c704484fa2 URL: https://github.com/llvm/llvm-project/commit/f0f53cb4bfb2b6c5ec6661b565a764c704484fa2 DIFF: https://github.com/llvm/llvm-project/commit/f0f53cb4bfb2b6c5ec6661b565a764c704484fa2.diff

[PATCH] D158873: [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

nridge updated this revision to Diff 553607. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158873/new/ https://reviews.llvm.org/D158873 Files: clang-tools-extra/clangd/HeuristicResolver.cpp clang-

[PATCH] D156894: [NFC] Update OpenMP Support page for Clang/LLVM 17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59fdd4c0715f: [NFC] Update OpenMP Support page for Clang/LLVM 17 (authored by cchen). Herald added a project: clang. Herald added a subscriber: cfe-c

[clang] 59fdd4c - [NFC] Update OpenMP Support page for Clang/LLVM 17

Author: Chi Chun Chen Date: 2023-08-25T15:50:39-05:00 New Revision: 59fdd4c0715fe16accf61aa3ce76b9bb1350d0e9 URL: https://github.com/llvm/llvm-project/commit/59fdd4c0715fe16accf61aa3ce76b9bb1350d0e9 DIFF: https://github.com/llvm/llvm-project/commit/59fdd4c0715fe16accf61aa3ce76b9bb1350d0e9.diff

[PATCH] D158805: [clang-format][NFC] Remove extraneous newlines at end of test cases

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:24187 // Newlines are important here. + verifyFormat("FOO(1+2 )", Style); HazardyKnusperkeks wrote: > This. Good catch! Though `verify

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane accepted this revision. erichkeane added a comment. Still LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 553601. shafik added a comment. - Extended constexpr-string.cpp test - Added release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.c

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall added a comment. I think we're not *that* far away from landing the AST change, and changing RecursiveASTVisitor now is probably confusing and not worth the churn. So I'd prefer to wait for now... Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:240 + +

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. In D158572#4615234 , @phosek wrote: > In D158572#4615231 , @jansvoboda11 > wrote: > >> @phosek BTW can you confirm whether these started failing with this patch or >> with D158573

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added a comment. In D153152#4617391 , @robot wrote: >> so you could replace the logic that prints the return type + arg list with >> `printType(functype, class, methodname)` (from AST.h). That should pick up >> noexcept etc. > > I've tried it

[clang] 8cfe9d8 - [Driver] Remove remnant myriad pieces after Myriad.cpp removal

Author: Fangrui Song Date: 2023-08-25T13:29:10-07:00 New Revision: 8cfe9d8f2ad3a52ba7fd5841d3939aa810536e16 URL: https://github.com/llvm/llvm-project/commit/8cfe9d8f2ad3a52ba7fd5841d3939aa810536e16 DIFF: https://github.com/llvm/llvm-project/commit/8cfe9d8f2ad3a52ba7fd5841d3939aa810536e16.diff

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM. Nothing fancy, looks straight forward. You may want to wait for an Aaron Ballman opinion. Comment at: clang/docs/LibASTMatchersReference.html:2454 +Matcher

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB updated this revision to Diff 553593. MasterCopy8GB added a comment. Combine readability-identifier-naming improvements in release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readab

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

owenpan added a comment. > I'm not exactly sure why this function needs to override the Spaces as it > seems to generally already be set to either 0 or 1 according to the other > formatting settings If so, can we address the issue without the "explicit fix"? Comment at: clan

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43a9b92d79ab: [Sema][HLSL] Fix naming of anyhit/closesthit shaders (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 43a9b92 - [Sema][HLSL] Fix naming of anyhit/closesthit shaders

Author: Justin Bogner Date: 2023-08-25T13:08:36-07:00 New Revision: 43a9b92d79ab6a59c3cfaa926bb32f161ef2facc URL: https://github.com/llvm/llvm-project/commit/43a9b92d79ab6a59c3cfaa926bb32f161ef2facc DIFF: https://github.com/llvm/llvm-project/commit/43a9b92d79ab6a59c3cfaa926bb32f161ef2facc.diff

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. After you update release notes entry, it could land... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:240-245 ` check to emit proper warnings when a type forward declaration precedes its definition. +- Improved :doc:`readability-identifier-naming + ` allow for + ``Leading_upper_snake_cas

[PATCH] D158873: [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oh, this is surprising! Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:142 +// Do not proceed to try resolving the member in the expression's base type

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner updated this revision to Diff 553588. bogner added a comment. Address feedback and simplify valid shader stage test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158820/new/ https://reviews.llvm.org/D158820 Files: clang/include/clang/Basi

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG847186eb94bd: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 847186e - [NFC][Clang] Fix static analyzer concern

Author: Elizabeth Andrews Date: 2023-08-25T13:03:06-07:00 New Revision: 847186eb94bd8c3535f0384456eeffe85f1d9696 URL: https://github.com/llvm/llvm-project/commit/847186eb94bd8c3535f0384456eeffe85f1d9696 DIFF: https://github.com/llvm/llvm-project/commit/847186eb94bd8c3535f0384456eeffe85f1d9696.d

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10112 + Specialization->addAttr(PrevDecl->getAttr()); + Consumer.AssignInheritanceModel(Specialization); +} tahonermann wrote: > I am concerned that moving the call to `Co

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner added inline comments. Comment at: clang/test/SemaHLSL/entry_shader.hlsl:1 -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-entry foo -o - %s -DSHADER='"anyHit"' -verify +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-entr

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:169 all arguments being able to fit on the same line. +- Avoid unnecessarily aggressive line-breaking when using + ``LambdaBodyIndentation: OuterScope`` with argument bin-packing.

[PATCH] D158873: [clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. https://g

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a few type-related Matchers - bitIntType - constantMatrixType - dependentAddres

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rG53ee31c9871d: [Fuchsia] Make __start_* / __stop_* symbols hidden (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158822/new/ https://rev

[clang] 53ee31c - [Fuchsia] Make __start_* / __stop_* symbols hidden

Author: Petr Hosek Date: 2023-08-25T18:50:46Z New Revision: 53ee31c9871deceaff625dc772d52c0cec520ff9 URL: https://github.com/llvm/llvm-project/commit/53ee31c9871deceaff625dc772d52c0cec520ff9 DIFF: https://github.com/llvm/llvm-project/commit/53ee31c9871deceaff625dc772d52c0cec520ff9.diff LOG: [F

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

beanz added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] bob80905 wrote: > bogner wrote: > > bob80905 wrote: > > > I d

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bob80905 added inline comments. Comment at: clang/test/SemaHLSL/entry_shader.hlsl:1 -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-entry foo -o - %s -DSHADER='"anyHit"' -verify +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-en

[PATCH] D158805: [clang-format][NFC] Remove extraneous newlines at end of test cases

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:24187 // Newlines are important here. + verifyFormat("FOO(1+2 )", Style); This. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] bbcc7c5 - [NFC] Initialize member pointer and avoid potential null dereference

Author: Sindhu Chittireddy Date: 2023-08-25T11:35:44-07:00 New Revision: bbcc7c5614cd642c8e71b89a6655b097454d57ea URL: https://github.com/llvm/llvm-project/commit/bbcc7c5614cd642c8e71b89a6655b097454d57ea DIFF: https://github.com/llvm/llvm-project/commit/bbcc7c5614cd642c8e71b89a6655b097454d57ea.

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcc7c5614cd: [NFC] Initialize member pointer and avoid potential null dereference (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1587

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

schittir added a comment. Thank you for the reviews, Aaron and Aaron! All tests pass. Landing the patch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158775/new/ https://reviews.llvm.org/D158775 __

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158822/new/ https://reviews.llvm.org/D158822 ___

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann added reviewers: rnk, zequanwu. tahonermann added a comment. Adding Erich as attributes owner, and Reid and Zequan for MS ABI. This patch slightly modifies the changes made via D94646 and committed as rG4fffbc150cca1638051b8ad2a20f4b8240df0869

[clang] 54c99a9 - [Clang] Update the core issues list

Author: Corentin Jabot Date: 2023-08-25T20:23:17+02:00 New Revision: 54c99a906740a6dee2e0827d38b351d5966c2e2d URL: https://github.com/llvm/llvm-project/commit/54c99a906740a6dee2e0827d38b351d5966c2e2d DIFF: https://github.com/llvm/llvm-project/commit/54c99a906740a6dee2e0827d38b351d5966c2e2d.diff

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change addresses two issues: 1. A failure to propagate

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

srhines added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower MaskRay wrote: > enh wrote: > > ilinpv wrote: > > > MaskRay wrote

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana added a comment. In D158709#4617295 , @aaron.ballman wrote: > I'm a bit concerned about the impact on (non-modules) build time performance. > This splits stddef.h and stdarg.h into needing to open 14 different files > instead of 2. Hopefully that'

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB updated this revision to Diff 553550. MasterCopy8GB added a comment. Fix documentation comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-t

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] bob80905 wrote: > I don't think we should expect this error,

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

eandrews updated this revision to Diff 553534. eandrews added a comment. Thanks for the reviews! Requested changes have been made in latest patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158671/new/ https://reviews.llvm.org/D158671 Files: clang/include/clang/ExtractAPI/ExtractAP

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bob80905 added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] I don't think we should expect this error, given that ther

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:326 def err_unsupported_abi_for_opt : Error<"'%0' can only be used with the '%1' ABI">; +def err_unsupported_opt_for_execute_only_target +: Error<"unsupported option '%0' for the e

[PATCH] D158858: [analyzer] MPIChecker: add defensive checking (check against nullptr)

danix800 added a comment. In D158858#4617510 , @steakhal wrote: > Makes sense. > Would thus test crash without the early returns? And now they wouldn't? Yes, the original crash shown in https://godbolt.org/z/39P7W6KPa Repository: rG LLVM Github Monor

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier added a comment. Commit is https://github.com/llvm/llvm-project/commit/04e6178ae932c9a1d939dcfe3ef1189f4bbb21aa. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158318/new/ https://reviews.llvm.org/D158318 ___ cfe-commits mailing lis

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier closed this revision. fcloutier added a comment. Apologies, I landed the change but forgot to update the commit message to include the "Differential Revision:" link. -_- I'm closing this change and I'll update the GitHub issue, which is linked. CHANGES SINCE LAST ACTION https://rev

[clang] 04e6178 - [Sema] tolerate more promotion matches in format string checking

Author: Félix Cloutier Date: 2023-08-25T10:14:01-07:00 New Revision: 04e6178ae932c9a1d939dcfe3ef1189f4bbb21aa URL: https://github.com/llvm/llvm-project/commit/04e6178ae932c9a1d939dcfe3ef1189f4bbb21aa DIFF: https://github.com/llvm/llvm-project/commit/04e6178ae932c9a1d939dcfe3ef1189f4bbb21aa.diff

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

This revision was automatically updated to reflect the committed changes. Closed by commit rG41818ce150fd: [clang-tidy] Access checks not done classes derived of std::array (authored by sousajo, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] 41818ce - [clang-tidy] Access checks not done classes derived of std::array

Author: Jorge Pinto Sousa Date: 2023-08-25T17:09:04Z New Revision: 41818ce150fd7534480a28d6c0d603f1a503db79 URL: https://github.com/llvm/llvm-project/commit/41818ce150fd7534480a28d6c0d603f1a503db79 DIFF: https://github.com/llvm/llvm-project/commit/41818ce150fd7534480a28d6c0d603f1a503db79.diff

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

MaskRay updated this revision to Diff 553524. MaskRay marked 2 inline comments as done. MaskRay added a comment. add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158811/new/ https://reviews.llvm.org/D158811 Files: clang/lib/Basic/Targets

[PATCH] D158858: [analyzer] MPIChecker: add defensive checking (check against nullptr)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Makes sense. Would thus test crash without the early returns? And now they wouldn't? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158858/new

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a subscriber: Mordante. aaron.ballman added a comment. In D157572#4614561 , @cjdb wrote: > In D157572#4613622 , @aaron.ballman > wrote: > >> In D157572#4612141

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rG1561495cd128: [flang][driver] Mark -L as visible in Flang (authored by erjin, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/ne

[clang] 1561495 - [flang][driver] Mark -L as visible in Flang

Author: Hao Jin Date: 2023-08-25T13:01:49-04:00 New Revision: 1561495cd128a641b9efcbb9d19d36e5a9c5e952 URL: https://github.com/llvm/llvm-project/commit/1561495cd128a641b9efcbb9d19d36e5a9c5e952 DIFF: https://github.com/llvm/llvm-project/commit/1561495cd128a641b9efcbb9d19d36e5a9c5e952.diff LOG:

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added a comment. I published an initial version of my attempt at documenting this stuff here: https://wiki.winehq.org/ARM64ECToolchain. It's not yet complete, but I hope it's already useful. I plan to extend it in the future. If some clarification or more information would be useful, plea

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:195 + const NonLoc Idx = Ctx.getSValBuilder().makeArrayIndex(i); + auto CountReached = SVB.evalBinOp(State, BO_GE, Idx, Count, ASTCtx.BoolTy) +

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:192-198 +SVal Count = CE.getArgSVal(0); +for (size_t i = 0; i < ArrSize; ++i) { + const NonLoc Idx = Ctx.getSValBuilder().makeArrayIndex(i); + auto CountReac

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/test/Analysis/mpichecker.cpp:286-288 + for (int i = 0; i < 3; ++i) +MPI_Ireduce(MPI_IN_PLACE, &buf, 1, MPI_DOUBLE, MPI_SUM, 0, MPI_COMM_WORLD, +&rs.req[i]); steakhal wrote: > This loop here im

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:189-190 +ASTCtx.getCharWidth(); +const NonLoc MROffset = +SVB.makeArrayIndex(MR->getAsOffset().getOffset() / ElemSizeInBits); steakhal w

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:185-188 +CharUnits ElemSizeInChars = ASTCtx.getTypeSizeInChars(ElemType); +int64_t ElemSizeInBits = +(ElemSizeInChars.isZero() ? 1 : ElemSizeInChars.getQuantit

  1   2   >