sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Oh, this is surprising!
================
Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:142
+ // Do not proceed to try resolving the member in the expression's base type
+ // without regard to the qualifier, as that could produce incorrect
results.
+ return {};
----------------
I think the pattern from the testcase clarifies enough to be worth an extra line
> `void foo() { this->Base::foo(); }` shouldn't resolve to foo() itself!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158873/new/
https://reviews.llvm.org/D158873
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
