MaskRay added inline comments.
================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:718
;
- FeaturesMask |= (1ULL << Feature);
+ FeatureMask[Feature / 32] |= 1U << (Feature % 32);
}
----------------
pengfei wrote:
> Should we use vector for future expansion, or add an assert to make sure it
> won't exceed current limitation?
A resizable vector does not simplify code here. I've added an assert.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158811/new/
https://reviews.llvm.org/D158811
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
