[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3515409012fa: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3515409 - [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

Author: Fangrui Song Date: 2023-08-23T23:58:38-07:00 New Revision: 3515409012fa151481896e56c4fe0f32ef8391fc URL: https://github.com/llvm/llvm-project/commit/3515409012fa151481896e56c4fe0f32ef8391fc DIFF: https://github.com/llvm/llvm-project/commit/3515409012fa151481896e56c4fe0f32ef8391fc.diff

[PATCH] D158592: [clang][dataflow] Produce pointer values for callees of member operator calls.

mboehme added a comment. CI failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158592/new/ https://reviews.llvm.org/D158592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72da678d8c84: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros (authored by iana). Repository: rG LLVM Github Monorepo CHANGES

[clang] 72da678 - [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

Author: Ian Anderson Date: 2023-08-23T23:55:51-07:00 New Revision: 72da678d8c84c2cc442940a026ca50d0bb5c2b8e URL: https://github.com/llvm/llvm-project/commit/72da678d8c84c2cc442940a026ca50d0bb5c2b8e DIFF: https://github.com/llvm/llvm-project/commit/72da678d8c84c2cc442940a026ca50d0bb5c2b8e.diff

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG62f769aa82f6: [Headers] Add missing __need_ macros to stdarg.h (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews

[clang] 62f769a - [Headers] Add missing __need_ macros to stdarg.h

Author: Ian Anderson Date: 2023-08-23T23:55:30-07:00 New Revision: 62f769aa82f668a076fed2633e425631a4598a47 URL: https://github.com/llvm/llvm-project/commit/62f769aa82f668a076fed2633e425631a4598a47 DIFF: https://github.com/llvm/llvm-project/commit/62f769aa82f668a076fed2633e425631a4598a47.diff

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added a comment. Windows succeeding earlier, I'm pretty confident that the current crash isn't due to this review, so I'm going to go ahead and land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

owenpan added a comment. @sstwcw this patch caused a crash in `FormatTestJS.StringLiteralConcatenation`: Assertion failed: ((!RequiresNullTerminator || BufEnd[0] == 0) && "Buffer is not null terminated!"), function init, file MemoryBuffer.cpp, line 54. Can you revert it if you can reproduce t

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. In D149867#4612589 , @myhsu wrote: > In D149867#4603853 , @aaron.ballman > wrote: > >> In D149867#4544489 , @myhsu wrote: >> >>> Sorry I was bus

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. @sammccall here is a question (or double check) about the intended initial version. This is the requirement for the initial version: > Don't attempt any cross-file or cross-version coordination: i.e. don't try to > reuse BMIs between different files, don't try to reu

[PATCH] D158505: [clang-format] Fix weird handling of AfterColon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e77ba6c1e4d: [clang-format] Fix weird handling of AfterColon (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/

[clang] 6e77ba6 - [clang-format] Fix weird handling of AfterColon

Author: Björn Schäpers Date: 2023-08-24T08:34:22+02:00 New Revision: 6e77ba6c1e4d2945a37169f6c7b3531ba39898b5 URL: https://github.com/llvm/llvm-project/commit/6e77ba6c1e4d2945a37169f6c7b3531ba39898b5 DIFF: https://github.com/llvm/llvm-project/commit/6e77ba6c1e4d2945a37169f6c7b3531ba39898b5.diff

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501 if (CGF.Builder.getIsFPConstrained()) { CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E); Function *F = CGF.CGM.getIntrinsic(ConstrainedIntrinsicID, Src0->getType());

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 553003. iana added a comment. Try rebasing one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h clang/test/Headers/stddef.

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 created this revision. danix800 added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. danix800

[PATCH] D158706: [Driver] Remove Myriad.cpp

MaskRay created this revision. MaskRay added reviewers: brad, jyknight, waltl. Herald added subscribers: jrtc27, fedor.sergeev. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am trying to clean up GCC

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

MaskRay added a comment. @brad :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158461/new/ https://reviews.llvm.org/D158461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158697: [clang-format][doc] Correct typos

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangFormatStyleOptions.rst:5129 * ``bool AfterControlStatements`` If ``true``, put space between control statement keywords (for/if/w

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri marked an inline comment as done. sandeepkosuri added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:30 +// OMP51-NEXT: entry: +// OMP51-NEXT:[[DOTGLOBAL_TID__ADDR_I:%.*]] = alloca i32, align 4 +// OMP51-NEXT:[[DOTPAR

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a41af86041b: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute (authored by MaskRay). Changed prior to commit: https://reviews.

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

tetsuo-cpp added a comment. Thanks for the review @nridge! I'd really appreciate if you could help me with the commit (I don't have commit access). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://reviews.llvm.org/D157990 ___

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:20 + Finder->addMatcher( + functionDecl(unless(parameterCountIs(0)), hasBody(coroutineBodyStmt())) + .bind("fnt"), ---

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158329/new/ https://reviews.llvm.org/D158329

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4603853 , @aaron.ballman wrote: > In D149867#4544489 , @myhsu wrote: > >> Sorry I was busy on my phd defense (which I passed!) in the past month. I'll >> get back to this next w

[PATCH] D158698: [Clang][M68k] Use `DefineStd` for target-specific macros

myhsu created this revision. myhsu added reviewers: jrtc27, 0x59616e. Herald added a project: All. myhsu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. (From the comments of D149867 ) Use `DefineStd` for t

[PATCH] D158697: [clang-format][doc] Correct typos

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

yaxunl created this revision. yaxunl added reviewers: arsenm, rjmccall. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Fix: https://github.com/llvm/llvm-project/issues/64653 https://reviews.llvm.org/D158695 Files: clang/lib/CodeGen/CGBu

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 552971. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h clang/test/Headers/stddef.c clang/test/Heade

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16ccba51072b: [clang-format] Break long string literals in C#, etc. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG825cec2c0b1e: [clang-format] Add Verilog suffixes to the scripts (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 16ccba5 - [clang-format] Break long string literals in C#, etc.

Author: sstwcw Date: 2023-08-24T03:16:31Z New Revision: 16ccba51072bbc5ff4c66f91f939163dc91e5d96 URL: https://github.com/llvm/llvm-project/commit/16ccba51072bbc5ff4c66f91f939163dc91e5d96 DIFF: https://github.com/llvm/llvm-project/commit/16ccba51072bbc5ff4c66f91f939163dc91e5d96.diff LOG: [clang

[clang] 825cec2 - [clang-format] Add Verilog suffixes to the scripts

Author: sstwcw Date: 2023-08-24T03:06:45Z New Revision: 825cec2c0b1ecec49995126674a8e58cd813476c URL: https://github.com/llvm/llvm-project/commit/825cec2c0b1ecec49995126674a8e58cd813476c DIFF: https://github.com/llvm/llvm-project/commit/825cec2c0b1ecec49995126674a8e58cd813476c.diff LOG: [clang

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:20 + Finder->addMatcher( + functionDecl(unless(paramete

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-code-object-version-linking.cu:12 +// RUN: llvm-link %t_0 %t_5 -o -| llvm-dis -o - | FileCheck -check-prefix=LINKED5 %s + +#include "Inputs/cuda.h" need to test using clang -cc1 with -O3 and

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw abandoned this revision. sstwcw added a comment. I am closing it since no one seems to like it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 ___ cfe-c

[clang] 19ab266 - [NFC] [C++20] [Coroutines] Mention the side effect of a fix may bring regressions

Author: Chuanqi Xu Date: 2023-08-24T10:41:48+08:00 New Revision: 19ab2664ad3182ffa8fe3a95bb19765e4ae84653 URL: https://github.com/llvm/llvm-project/commit/19ab2664ad3182ffa8fe3a95bb19765e4ae84653 DIFF: https://github.com/llvm/llvm-project/commit/19ab2664ad3182ffa8fe3a95bb19765e4ae84653.diff LO

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155826/new/ https://reviews.llvm.org/D155826 ___ cfe-commits mailing list cfe-c

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne added a comment. The follow-up to the temporary workaround is going to be done tomorrow in D158694 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158690/new/ https://reviews.llvm.org/D158690

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6073c7e32b: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline (authored by ldionne). Repository: rG LLVM Github M

[clang] bb6073c - [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

Author: Louis Dionne Date: 2023-08-23T22:21:53-04:00 New Revision: bb6073c7e32b5062a6969242c6bd4fe859e2e5e0 URL: https://github.com/llvm/llvm-project/commit/bb6073c7e32b5062a6969242c6bd4fe859e2e5e0 DIFF: https://github.com/llvm/llvm-project/commit/bb6073c7e32b5062a6969242c6bd4fe859e2e5e0.diff

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Along with aa60b2687ce3b67e454ba7c8c58a8688247df0b8 , this will make the Clang CI green again. We'll figure out what's th

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ceaec3e8104: [PowerPC][altivec] Optimize codegen of vec_promote (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 1ceaec3 - [PowerPC][altivec] Optimize codegen of vec_promote

Author: Kai Luo Date: 2023-08-24T02:10:13Z New Revision: 1ceaec3e81044d8a671b28d1f556045cf7fe6ef0 URL: https://github.com/llvm/llvm-project/commit/1ceaec3e81044d8a671b28d1f556045cf7fe6ef0 DIFF: https://github.com/llvm/llvm-project/commit/1ceaec3e81044d8a671b28d1f556045cf7fe6ef0.diff LOG: [Powe

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552952. AlexVlx added a comment. Define the interpose macro iff in interpose mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155826/new/ https://reviews.llvm.org/D155826 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Preprocessor

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

lkail added a comment. > but it might be a good idea to improve codegen for the insert which might be > more common. Yes. Usually `insertelement` is transformed to `BUILD_VECTOR` is SDAG, currently we don't have much optimization for `BUILD_VECTOR` in special patterns. Repository: rG LLVM

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

rapidsna added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:17931 + auto It = llvm::find_if(RD->fields(), [&](const FieldDecl *Field) { +return Field->getName() == ECA->getCountedByField()->getName(); + }); What happens in this corner case where

[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We made some changes to the libc++ CI pipeline that take for granted that we're running on libc++'s own Docker images. This

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

rapidsna added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:7209 +/* ... */ +struct bar *fam[] __attribute__((counted_by(num_fam_elements))); + }; I don't think it's necessary for this patch but for [[ https://discourse.llvm.org/t/

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158601/new/ https://reviews.llvm.org/D158601

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet added a comment. Gcc can diagnose wider cases of overflow/truncation by specifying a higher level for it, like `-Wformat-overflow=2` (https://godbolt.org/z/n5facjW1c). The current clang counterpart only diagnoses when the format string is //always// larger than the buffer size. If we

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay created this revision. MaskRay added reviewers: chill, peter.smith, simon_tatham, stuij. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some options are

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1654634f6f8b: [clang][ASTImporter] Fix partially import of repeated friend templates (authored by dingfei ). Repository: rG LLVM

[clang] 1654634 - [clang][ASTImporter] Fix partially import of repeated friend templates

Author: dingfei Date: 2023-08-24T09:10:14+08:00 New Revision: 1654634f6f8bc9a78c6c47f58e4f067fa9a7faef URL: https://github.com/llvm/llvm-project/commit/1654634f6f8bc9a78c6c47f58e4f067fa9a7faef DIFF: https://github.com/llvm/llvm-project/commit/1654634f6f8bc9a78c6c47f58e4f067fa9a7faef.diff LOG:

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

rapidsna added a comment. > Future additions will include supporting, FAMs and counts in sub-structures. For sub-structures, are you referring to cases like this? struct outer { struct { int count; } sub; int flex[__attribute__((counted_by(sub.count)))]; }; For `-fbounds-

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157855/new/ https://reviews.llvm.org/D157855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

hazohelet updated this revision to Diff 552939. hazohelet marked 4 inline comments as done. hazohelet added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158562/new/ https://reviews.llvm.org/D158562 Files: clang/docs/ReleaseNotes.rst clang/include

[clang] 61c8af6 - AMDGPU: InstCombine amdgcn.sqrt.f16 to sqrt.f16

Author: Matt Arsenault Date: 2023-08-23T20:30:40-04:00 New Revision: 61c8af67924b02c8f2cf871439c24650a0207f29 URL: https://github.com/llvm/llvm-project/commit/61c8af67924b02c8f2cf871439c24650a0207f29 DIFF: https://github.com/llvm/llvm-project/commit/61c8af67924b02c8f2cf871439c24650a0207f29.diff

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:256 - foo(f(p, &p, a, a)[1]); // expected-warning{{unsafe buffer access}} - // FIXME: expected note@-1{{in instantiation of function template specialization 'f' reque

[clang] 8a62d6b - [ORC][clang-repl] Fix UnitTest after 122ebe3b500.

Author: Lang Hames Date: 2023-08-23T17:19:07-07:00 New Revision: 8a62d6ba7edc3a7d397e52884a9ce63b4e579ae1 URL: https://github.com/llvm/llvm-project/commit/8a62d6ba7edc3a7d397e52884a9ce63b4e579ae1 DIFF: https://github.com/llvm/llvm-project/commit/8a62d6ba7edc3a7d397e52884a9ce63b4e579ae1.diff LO

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >> This a

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. In D152279#4612099 , @craig.topper wrote: > In D152279#4612087 , @MaskRay wrote: > >> I am still interested in moving this forward. What should be done here? If >> the decision is to kee

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added a comment. Codegen parts LGTM, questions with the driver parts Comment at: clang/lib/Driver/ToolChain.cpp:1368 if (A->getOption().matches(options::OPT_m_Group)) { - if (SameTripleAsHost) + // Pass code objection version to device toolchain + //

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

craig.topper added a comment. In D152279#4612087 , @MaskRay wrote: > I am still interested in moving this forward. What should be done here? If > the decision is to keep the current odd default 8 for > `toolchains::RISCVToolChain`, I guess I'll have to

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 added a comment. In D158469#4612012 , @benlangmuir wrote: >> I tried that approach, but found it way too easy to keep `ModuleDeps` >> around, which keep scanning instances alive, and use tons of memory. > > It seems like the problem (too ea

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. I am still interested in moving this forward. What should be done here? If the decision is to keep the current odd default 8 for `toolchains::RISCVToolChain`, I guess I'll have to take the compromise as making a step forward is better than nothing. Repository: rG LL

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

MatzeB added a comment. > I'd also posit, that maybe since we're changing this we should reevaluate the > numbers we use as defaults. Heh, same here. Internally we have a handful of functions that end up using `[[likely]]` loop conditions in a triple-nested loops leading to the estimated block

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

dblaikie added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 32 - 8

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

paulkirth added a comment. In D158668#4611842 , @MatzeB wrote: >> My initial reaction to this was that we should keep the >> --unlikely-branch-weights flag available > > I don't feel strongly about it and can put it back. But can you give some > reasoni

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 552917. efriedma added a comment. Update to address issues found so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157547/new/ https://reviews.llvm.org/D157547 Files: clang/lib/CodeGen/CGCXX.cpp llvm/

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

benlangmuir added a comment. > I tried that approach, but found it way too easy to keep `ModuleDeps` around, > which keep scanning instances alive, and use tons of memory. It seems like the problem (too easy to keep around MD) is the same either way, it's just instead of wasting memory it's lea

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + ---

[PATCH] D158668: Add getLikelyBranchWeight helper function

MatzeB added a comment. And as another strawman / discussion-started I put up D158680 where I use `!{"branch_weights", i32 1, i32 0}` to represent likely branches and the actual "LikelyWeight" mostly becomes an internal implementation detail of the BranchProba

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 added a comment. Hmm, maybe we could avoid holding on to the whole `CompilerInstance`. For generating the command-line, we only need the `CompilerInvocation`. For collecting file dependencies, we could hold on to the `MemoryBuffer` (and maybe offset to the input files block), and d

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 added a comment. In D158469#4611923 , @benlangmuir wrote: > I find this a bit hard to understand as far as object lifetime is concerned: > you're storing the `ScanInstance` in `TranslationUnitDeps`, but that's a > layer above the actual co

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

benlangmuir added a comment. I find this a bit hard to understand as far as object lifetime is concerned: you're storing the `ScanInstance` in `TranslationUnitDeps`, but that's a layer above the actual consumer interface, which means every consumer needs to understand how this lifetime is manag

[PATCH] D158668: Add getLikelyBranchWeight helper function

MatzeB added a comment. > On the other hand, I dislike exposing some internal detail of a pass. I think the question to ask is whether a concept like "likely branch" or "unlikely branch" shouldn't be more universal and not be a pass internal detail? Otherwise it feels like my patches and other

[PATCH] D158668: Add getLikelyBranchWeight helper function

MatzeB added a comment. > My initial reaction to this was that we should keep the > --unlikely-branch-weights flag available I don't feel strongly about it and can put it back. But can you give some reasoning? I only see this flag having a real use to express small ratios like 3:2 which doesn'

[PATCH] D158668: Add getLikelyBranchWeight helper function

paulkirth added a comment. My initial reaction to this was that we should keep the `--unlikely-branch-weights` flag available, even if we decide to move forward with the other changes. but given that you haven't had to update many tests, I think its probably fine to go this way. Probably just a

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 552899. ZijunZhao marked 2 inline comments as done. ZijunZhao added a comment. 1. define __STDC_VERSION_STDCKDINT_H__ 2. check short type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://revi

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:326 def err_unsupported_abi_for_opt : Error<"'%0' can only be used with the '%1' ABI">; +def err_unsupported_opt_for_execute_only_target +: Error<"unsupported option '%0' for the e

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

rsundahl accepted this revision. rsundahl added a comment. This revision is now accepted and ready to land. LGTM since we ship the shim with the toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158570/new/ https://reviews.llvm.org/D158570

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

aeubanks added a comment. In D61670#4607313 , @mstorsjo wrote: >> I expected the answer would be "yes", so I said "lgtm" and then phrased my >> question very awkwardly. > > Ah, thanks for the clarification! > > Any opinion on the name, `-fno-autoimport` v

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1169 + writeSignature(Sig, Out); + std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset); +}; benlangmuir wr

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 updated this revision to Diff 552897. jansvoboda11 added a comment. Early return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158573/new/ https://reviews.llvm.org/D158573 Files: clang/include/clang/Basic/Module.h clang/include/c

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added a comment. In D157757#4611492 , @iana wrote: > In D157757#4611425 , @ldionne wrote: > >> Also we should figure out why the Clang modules build is failing on top of >> this, it doesn't look like a false

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 updated this revision to Diff 552896. jansvoboda11 added a comment. Use `Stream::BackpatchWord()` instead of manipulating `Buffer` directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158573/new/ https://reviews.llvm.org/D158573 Fi

[clang] 3197357 - Revert "[clang] Match -isysroot behaviour with system compiler on Darwin"

Author: Alex Lorenz Date: 2023-08-23T14:50:02-07:00 New Revision: 3197357b7e39a58bc7eb0600eb337ac2a1c8c225 URL: https://github.com/llvm/llvm-project/commit/3197357b7e39a58bc7eb0600eb337ac2a1c8c225 DIFF: https://github.com/llvm/llvm-project/commit/3197357b7e39a58bc7eb0600eb337ac2a1c8c225.diff L

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 updated this revision to Diff 552894. jansvoboda11 added a comment. Initialize absolute offsets in `ASTReader`/`ModuleFile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158572/new/ https://reviews.llvm.org/D158572 Files: clang/inc

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

arphaman added a comment. I will revert this for now, as this change broke Darwin CI: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/37169/ Clang.Tooling.clang-check-mac-libcxx-abspath.cpp Clang.Tooling.clang-check-mac-libcxx-relpath.cpp @ldionne has a patch for these te

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

cjdb added a comment. In D151575#4607047 , @aaron.ballman wrote: > I am wrestling with this one because I think the status quo is unfortunate > (we silently drop relevant information in ways the user may not immediately > understand) but I think always

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added a comment. In D158641#4611731 , @rprichard wrote: > [...] > > I suspect Bionic ought to apply relocations to libraries in a bottom-up > fashion, so that libc.so is relocated before the executable or shared > objects, but I _think_ it's cur

[libunwind] 5eb44df - Make _LIBUNWIND_SUPPORT_FRAME_APIS a build-time option

Author: Sterling Augustine Date: 2023-08-23T14:34:40-07:00 New Revision: 5eb44df1b64dbd1a86b099128092a7fd2001c0ba URL: https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba DIFF: https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba.

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added inline comments. Comment at: clang/test/Driver/aarch64-features.c:10 // Check Function Multi Versioning option and rtlib dependency. -// RUN: %clang --target=aarch64-linux-android -rtlib=compiler-rt \ +// RUN: %clang --target=aarch64-linux-android23 -rtlib=compiler

  1   2   3   >