MatzeB added a comment. > On the other hand, I dislike exposing some internal detail of a pass.
I think the question to ask is whether a concept like "likely branch" or "unlikely branch" shouldn't be more universal and not be a pass internal detail? Otherwise it feels like my patches and other places would need to insert new `llvm.expect` usages into the IR and litter the pass pipeline with more instances of the LowerExpect pass which seems overkill for little gain to me... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158668/new/ https://reviews.llvm.org/D158668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits