[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Please give @aaron.ballman a few days to get another look, but otherwise LGTM Thanks a lot for working on this and your patience during the review. Repository: rG LLVM Github Monorepo C

[PATCH] D153714: [NFC] Add missing cpu tests in predefined-arch-macros.c

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153714/new/ https://reviews.llvm.org/D153714 ___ cfe

[clang] 43baa59 - Pre-commit test for D151696.

Author: Freddy Ye Date: 2023-06-28T13:53:35+08:00 New Revision: 43baa5986c20aa510144c0de9b7782050ccba530 URL: https://github.com/llvm/llvm-project/commit/43baa5986c20aa510144c0de9b7782050ccba530 DIFF: https://github.com/llvm/llvm-project/commit/43baa5986c20aa510144c0de9b7782050ccba530.diff LOG

[PATCH] D152989: Pre-commit test for D151696.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43baa5986c20: Pre-commit test for D151696. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. Hi, there is a compiling error introduced recently as like following when files under clang/lib/Analysis/FlowSensitive/ are being compiled such as TypeErasedDataflowAnalysis.cpp and Transfer.cpp. Does anybody meet also? > from /usr/include/c++/7/functional:60, > f

[clang] e9fb7d6 - [Fuchsia] Enable libcxx filesystem on Windows for stage 1 build

Author: Petr Hosek Date: 2023-06-28T05:43:16Z New Revision: e9fb7d6972b9a48918ebffb61ef1472e1b1d7636 URL: https://github.com/llvm/llvm-project/commit/e9fb7d6972b9a48918ebffb61ef1472e1b1d7636 DIFF: https://github.com/llvm/llvm-project/commit/e9fb7d6972b9a48918ebffb61ef1472e1b1d7636.diff LOG: [F

[clang] 2241146 - [NFC] [C++20] [Modules] Add a test for merging lambda types

Author: Chuanqi Xu Date: 2023-06-28T13:41:39+08:00 New Revision: 2241146752f9260d077a6ac38f43069f945e85b4 URL: https://github.com/llvm/llvm-project/commit/2241146752f9260d077a6ac38f43069f945e85b4 DIFF: https://github.com/llvm/llvm-project/commit/2241146752f9260d077a6ac38f43069f945e85b4.diff LO

[PATCH] D153714: [NFC] Add missing cpu tests in predefined-arch-macros.c

FreddyYe added a comment. ping this thread, too. Notice that this is an independent patch :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153714/new/ https://reviews.llvm.org/D153714 ___ cfe-commits ma

[PATCH] D152989: Pre-commit test for D151696.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535223. FreddyYe added a comment. Seperate ALIAS CPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecific-cpus.c clang/te

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:432 + "Target '%0' does not support exception handling." + " To allow code generation for '%0', 'catch' statement will be replaced by a no operation instruction.">; } -

[clang] d39b4ce - [test] Replace aarch64-*-eabi with aarch64

Author: Fangrui Song Date: 2023-06-27T20:02:52-07:00 New Revision: d39b4ce3ce8a3c256e01bdec2b140777a332a633 URL: https://github.com/llvm/llvm-project/commit/d39b4ce3ce8a3c256e01bdec2b140777a332a633 DIFF: https://github.com/llvm/llvm-project/commit/d39b4ce3ce8a3c256e01bdec2b140777a332a633.diff

[PATCH] D152989: Pre-commit test for D151696.

skan added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} FreddyYe wrote: > skan wrote: > > Shouldn't we use the same function name? > Emmm

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} skan wrote: > Shouldn't we use the same function name? Emmm... it would invo

[PATCH] D152989: Pre-commit test for D151696.

skan added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} Shouldn't we use the same function name? Repository: rG LLVM Github Monorepo

[clang] 02e9441 - [test] Replace -triple aarch64-arm-none-eabi with -triple aarch64

Author: Fangrui Song Date: 2023-06-27T19:21:41-07:00 New Revision: 02e9441d6ca73314afa1973a234dce1e390da1da URL: https://github.com/llvm/llvm-project/commit/02e9441d6ca73314afa1973a234dce1e390da1da DIFF: https://github.com/llvm/llvm-project/commit/02e9441d6ca73314afa1973a234dce1e390da1da.diff

[PATCH] D152989: Pre-commit test for D151696.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

eastb233 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153321/new/ https://reviews.llvm.org/D153321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535215. FreddyYe added a comment. Change into a more simplified style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecific-c

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP updated this revision to Diff 535214. SeanP added a comment. Generalize path names in test cases so \\ on windows match. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Tar

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. It came to me a better style: ATTR(cpu_specific(generic)) void CPU1(void){} ATTR(cpu_specific(pentium_pro)) void CPU2(void){} ATTR(cpu_specific(pentium_mmx)) void CPU3(void){} ATTR(cpu_specific(pentium_ii)) void CPU4(void){} ATTR(cpu_specific(pentium_iii)) void

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535213. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/Co

[PATCH] D152989: Pre-commit test for D151696.

pengfei added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:1-2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s +// RUN: %clang_cc1 -triple x86_64-windows-pc -fms-compatibility -emit-llvm -o - %s + Is it only to check no

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 535202. ormris added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/lib/CodeGen/C

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa872aa221e2: [Fuchsia] Enable libcxx filesystem on Windows build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] fa872aa - [Fuchsia] Enable libcxx filesystem on Windows build.

Author: Haowei Wu Date: 2023-06-27T16:57:58-07:00 New Revision: fa872aa221e2c632048517e5580b059ce7fc6900 URL: https://github.com/llvm/llvm-project/commit/fa872aa221e2c632048517e5580b059ce7fc6900 DIFF: https://github.com/llvm/llvm-project/commit/fa872aa221e2c632048517e5580b059ce7fc6900.diff LOG

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153931/new/ https://reviews.llvm.org/D153931 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

haowei updated this revision to Diff 535194. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153931/new/ https://reviews.llvm.org/D153931 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D153931: [Fuchsia] Enable libcxx filesystem on Windows build.

haowei created this revision. haowei added reviewers: phosek, Prabhuk. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables the libcxx filesystem when bu

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 535191. BeMg marked 8 inline comments as done. BeMg added a comment. Add const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603 +// deallocation call of __kmpc_free_shared() is emitted later. +if (getLangOpts().OpenMP && getTarget().getTriple().isAMDGCN()) { + // Emit call to __kmpc_alloc_shared() instead of the allo

[PATCH] D153909: [AMDGPU] Always pass `-mcpu` to the `lld` linker

jhuber6 added a comment. In D153909#4454383 , @JonChesterfield wrote: > I thought lld did the right thing if you pass it raw IR, without specifying > an arch, but on reflection it might just be silently miscompiling things. The > test doesn't seem to i

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl marked an inline comment as not done. brendandahl added inline comments. Comment at: llvm/test/MC/WebAssembly/func-attr.s:21 +# CHECK-OBJ-NEXT: Offset: 0x0 +# CHECK-OBJ-NEXT: Name:func_attr.custom0 sbc100 wrote: > Sho

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl updated this revision to Diff 535187. brendandahl added a comment. Remove annotate arguments. Change name from func_attr to llvm.func_attr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 File

[PATCH] D153909: [AMDGPU] Always pass `-mcpu` to the `lld` linker

JonChesterfield added a comment. I thought lld did the right thing if you pass it raw IR, without specifying an arch, but on reflection it might just be silently miscompiling things. The test doesn't seem to involve a specific type of input file, does clang foo.ll -o a.out pass a mcpu flag alon

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603 +// deallocation call of __kmpc_free_shared() is emitted later. +if (getLangOpts().OpenMP && getTarget().getTriple().isAMDGCN()) { + // Emit call to __kmpc_alloc_shared() instead of the all

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 updated this revision to Diff 535186. doru1004 marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

alexfh added a comment. After the patch, LLVM still has a number of `aarch64-arm-none-eabi` usages in tests, which is also considered invalid now: https://gcc.godbolt.org/z/z8cY5j68M Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https:

[PATCH] D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast

owenpan added a comment. In D153745#4448113 , @rymiel wrote: > It appears other operators aren't affected, after D153641 > I would have not been surprised if && had > become unary :) `&&` doesn't become unary because

[PATCH] D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a4cdbeafb4c: [clang-format] Fix bugs in annotating r_paren as C-style cast (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153745/new/

[clang] 7a4cdbe - [clang-format] Fix bugs in annotating r_paren as C-style cast

Author: Owen Pan Date: 2023-06-27T16:16:36-07:00 New Revision: 7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe URL: https://github.com/llvm/llvm-project/commit/7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe DIFF: https://github.com/llvm/llvm-project/commit/7a4cdbeafb4c2c9fae2ac69d362d22d431404bbe.diff LOG:

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:585-598 +// The fifth field is an optional pointer to the arguments. Append each +// argument to the name separated by a '.'. +auto *ArgsVar = dyn_cast(CS->getOperand(4)->

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:585-598 +// The fifth field is an optional pointer to the arguments. Append each +// argument to the name separated by a '.'. +auto *ArgsVar = dyn_cast(CS->getOperand

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir created this revision. schittir added reviewers: erichkeane, aaron.ballman, tahonermann, shafik. Herald added subscribers: cfe-commits, steakhal, martong. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owen

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added a comment. In D150803#4454164 , @brendandahl wrote: > In D150803#4440802 , @aaron.ballman > wrote: > >> Marking as requested changes so it's clear there's more worth discussing, so >> we don't acci

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added a comment. In D150803#4440802 , @aaron.ballman wrote: > Marking as requested changes so it's clear there's more worth discussing, so > we don't accidentally land this. I've switched to using `annotate` now. Let me know if there's anyt

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl created this revision. AntonRydahl added reviewers: jdoerfert, jhuber6. Herald added subscribers: sunshaoce, mattd, gchakrabarti, asavonic, guansong, tpr, yaxunl, rampitec. Herald added a project: All. AntonRydahl requested review of this revision. Herald added subscribers: cfe-commits

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535144. ivanmurashko added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLists.txt clang-t

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

shafik added a comment. MSVC rejects the first but accepts the second which I think is wrong but worth testing: alignof(struct B {}); sizeof(struct B{}); https://godbolt.org/z/153jYqaPM Comment at: clang/include/clang/Parse/Parser.h:2359 case DeclSpecContext::DSC_te

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535138. ivanmurashko added a comment. Rebase + apply suggestions from @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535132. ychen marked 3 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNot

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

shafik added a comment. What about template struct A { }; void foo() { new struct A {}; } I think this should be allowed, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153857/new/ https://reviews.llvm.org/D153857 ___

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 535126. brendandahl added a comment. Use the annotate attribute to generate custom sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: lld/test/was

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 abandoned this revision. sbc100 added a comment. Yes, on further investigation is seems that there is precedent for having `alignof(max_align_t)` and `__BIGGEST_ALIGNMENT__` be different. See https://github.com/emscripten-core/emscripten/pull/19728 Repository: rG LLVM Github Monorepo

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a comment. After local discussion, I guess we decided to leave this as-is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151820/new/ https://reviews.llvm.org/D151820 ___ cfe-commits mailing

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

MaskRay added a comment. Thank you for implementing this warning. Side note: it would be better to (a) fix the tests separately from (b) implementing the warning and (c) adding tests to demonstrate the warning. This way the patch is more focused. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin marked 14 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:340-342 + /// Whether this declaration denotes a placeholder that can be + /// redefined in the same scope. + unsigned IsPlaceholder : 1;

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3048 }]; + let ParseArgumentsAsUnevaluated = 1; } cor3ntin wrote: > aaron.ballman wrote: > > I don't think we should reuse this flag this way. This flag is for the > > tradit

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 535116. cor3ntin added a comment. - Address more feedback - reword diag - remove diag for unused init capture - Remove the IsPlaceholder bit, as placeholder variables can be determined without data Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added a comment. GitHub issue: https://github.com/llvm/llvm-project/issues/63563 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 ___ cfe-commits mailin

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt created this revision. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153914 Files: clang/include/clang/Basic/DiagnosticGrou

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa42ce094d903: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] a42ce09 - [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

Author: David Goldman Date: 2023-06-27T16:25:40-04:00 New Revision: a42ce094d90341f88a845740b2e5783060f23e3e URL: https://github.com/llvm/llvm-project/commit/a42ce094d90341f88a845740b2e5783060f23e3e DIFF: https://github.com/llvm/llvm-project/commit/a42ce094d90341f88a845740b2e5783060f23e3e.diff

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe updated this revision to Diff 535106. mikecrowe added a comment. Fix test failures on PS4 and PS5 and improve tests - Ensure that exceptions are available so the test can use try/catch - Remove unwanted -NOT checks - Add more return value tests Repository: rG LLVM Github Monorepo C

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:135-136 - Compiler flags ``-std=c++2c`` and ``-std=gnu++2c`` have been added for experimental C++2c implementation work. +- Implemented `P2169R4: A nice placeholder with no name

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe marked an inline comment as done. mikecrowe added a comment. In D153860#4453572 , @dyung wrote: > @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 > Windows build bots. Can you take a look and fix or revert if you need

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings updated this revision to Diff 535102. michaelplatings added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153885/new/ https://reviews.llvm.org/D153885 Files: clang/include/clang/Basic/DiagnosticDriverKi

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3048 }]; + let ParseArgumentsAsUnevaluated = 1; } aaron.ballman wrote: > I don't think we should reuse this flag this way. This flag is for the > traditional sense of "unevaluated

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:316 + // line can't be a declaration. bool OperatorCalledAsMemberFunction = + (Prev->Previous && Nuu wrot

[PATCH] D153130: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/AArch64.cpp:420 +Builder.defineMacro("__ARM_FEATURE_RCPC", "3"); + else if (HasRCPC) Builder.defineMacro("__ARM_FEATU

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} aaronpuchert wrote: > tbaeder wrote: > > This handles the function call, bu

[clang-tools-extra] 43fa7ea - Revert "[clang-tidy] Fix modernize-use-std-print check when return value used"

Author: Piotr Zegar Date: 2023-06-27T19:25:52Z New Revision: 43fa7ea9df3a7b3bdc9d0129bcc3bed4db52dba0 URL: https://github.com/llvm/llvm-project/commit/43fa7ea9df3a7b3bdc9d0129bcc3bed4db52dba0 DIFF: https://github.com/llvm/llvm-project/commit/43fa7ea9df3a7b3bdc9d0129bcc3bed4db52dba0.diff LOG: R

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Clearing the "accepted" status so it's not confusing as to the state of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. In D105759#4453440 , @cor3ntin wrote: > Parse attribute as unevaluated string if they > are declare StringLiteralArgument in the Attr.td file. > > WIP > > @aaron.ballman Do we agree on direction before I > fix the remainin

[PATCH] D153909: [AMDGPU] Always pass `-mcpu` to the `lld` linker

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, yaxunl, tra. Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a pr

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon added a comment. > With code like struct A {}; , the expressions > were parsed as redefining struct A and failed. However, as clarified by > CWG2141, new-expression cannot define a type, so both these expressions > should be considered as valid references to the previously declared st

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

ldionne added inline comments. Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:20-31 + - label: "Format" +commands: + - "! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs || false" + +agents: + queue: "libcxx-builders" + os: "linux" -

[PATCH] D153908: [dataflow] Use consistent, symmetrical, non-mutating erased signature for join()

sammccall created this revision. sammccall added reviewers: ymandel, xazax.hun. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Mutatin

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 535089. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address some of Aarons comments before getting rid of the bit in Decl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ http

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

dyung added a comment. @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 Windows build bots. Can you take a look and fix or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/43856 https://lab.llvm.org/buildbot/#/builders/216/buil

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin marked 14 inline comments as done. cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:135-136 - Compiler flags ``-std=c++2c`` and ``-std=gnu++2c`` have been added for experimental C++2c implementation work. +- Implemented `P2169R4: A nice placehold

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris created this revision. ormris added reviewers: efriedma, rjmccall, MaskRay, aaron.ballman. Herald added subscribers: steven_wu, hiraditya. Herald added a project: All. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang curr

[clang] 1e010c5 - Reland "[dataflow] avoid more accidental copies of Environment"

Author: Sam McCall Date: 2023-06-27T20:31:40+02:00 New Revision: 1e010c5c4fae43c52d6f5f1c8e8920c26bcc6cc7 URL: https://github.com/llvm/llvm-project/commit/1e010c5c4fae43c52d6f5f1c8e8920c26bcc6cc7 DIFF: https://github.com/llvm/llvm-project/commit/1e010c5c4fae43c52d6f5f1c8e8920c26bcc6cc7.diff LO

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. @bkramer Ben, PTAL when you get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153375/new/ https://reviews.llvm.org/D153375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall added a comment. Thanks! I'll land this to eliminate the variables, and follow up with trying to simplify join(). In D153493#4450440 , @ymandel wrote: > In D153493#4450358 , @sammccall > wrote: > >>>

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 535073. cor3ntin added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Parse attribute as unevaluated string if they are declare StringLiteralArgument in the Attr.td file. WIP @aaron.ballman Do we agree on direction before

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. OK to land this? (With a provision that I will add something to the emscripten changelog?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151820/new/ https://reviews.llvm.org/D151820 ___

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

rnk accepted this revision. rnk added subscribers: MaskRay, dblaikie. rnk added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but I want to get a second opinion from @dblaikie and @maskray for some debug info and BPF perspective. Repository: rG LLVM

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

chiyuze created this revision. chiyuze added a reviewer: rnk. Herald added a project: All. chiyuze requested review of this revision. Herald added a project: clang. Debug info emission for extern variables in C++ was previously disabled when the functionality was added in https://reviews.llvm.org/

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

aaron.ballman added a comment. In D153857#4453092 , @aaron.ballman wrote: > Thank you for the fix! Just to clarify some things before diving into the > review too much... From the patch summary: > > Expressions like > > new struct A {}; > struc

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir updated this revision to Diff 535050. schittir added a comment. Remove stale comment about default constructor not initializing members in a useful way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 Files: clang/lib/Analysis/CFG.

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e12b2e207cf: [clang-tidy] Fix modernize-use-std-print check when return value used (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] 3e12b2e - [clang-tidy] Fix modernize-use-std-print check when return value used

Author: Mike Crowe Date: 2023-06-27T17:23:52Z New Revision: 3e12b2e207cfa802937488a2c0b90d482eaf00a9 URL: https://github.com/llvm/llvm-project/commit/3e12b2e207cfa802937488a2c0b90d482eaf00a9 DIFF: https://github.com/llvm/llvm-project/commit/3e12b2e207cfa802937488a2c0b90d482eaf00a9.diff LOG: [c

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153560/new/ https://reviews.llvm.org/D153560 ___

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rGf4cf51c99c74: [clang][CFG] Add support for partitioning CFG into intervals. (authored by ymandel). Reposit

  1   2   3   >